Skip to content

[State Restoration] CupertinoModalPopupRoute #74805

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 5 commits into from
Jan 27, 2021
Merged

[State Restoration] CupertinoModalPopupRoute #74805

merged 5 commits into from
Jan 27, 2021

Conversation

shihaohong
Copy link
Contributor

Allows CupertinoModalPopupRoute to be state restorable. This unblocks making Cupertino action sheets state restorable in the gallery.

See #62916.

Pre-launch Checklist

  • I read the Contributor Guide and followed the process outlined there for submitting PRs.
  • I read the Tree Hygiene wiki page, which explains my responsibilities.
  • I read and followed the Flutter Style Guide, including Features we expect every widget to implement.
  • I listed at least one issue that this PR fixes in the description above.
  • I added new tests to check the change I am making or feature I am adding, or Hixie said the PR is test exempt.
  • I updated/added relevant documentation (doc comments with ///).
  • I signed the CLA.
  • All existing and new tests are passing.

If you need help, consider asking for advice on the #hackers-new channel on Discord.

@flutter-dashboard flutter-dashboard bot added f: cupertino flutter/packages/flutter/cupertino repository framework flutter/packages/flutter repository. See also f: labels. labels Jan 27, 2021
@shihaohong shihaohong requested a review from goderbauer January 27, 2021 12:00
@google-cla google-cla bot added the cla: yes label Jan 27, 2021
@shihaohong shihaohong mentioned this pull request Jan 27, 2021
Merged
goderbauer
goderbauer approved these changes Jan 27, 2021
View reviewed changes
Copy link
Member

@goderbauer goderbauer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@shihaohong shihaohong merged commit c6a428d into flutter:master Jan 27, 2021
@shihaohong shihaohong deleted the cupertino-modal branch January 27, 2021 19:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@goderbauer goderbauer goderbauer approved these changes

Assignees
No one assigned
Labels
f: cupertino flutter/packages/flutter/cupertino repository framework flutter/packages/flutter repository. See also f: labels.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@shihaohong @goderbauer