Skip to content

Set slider semantics flag for sliders #68019

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Oct 19, 2020
Merged

Set slider semantics flag for sliders #68019

merged 3 commits into from
Oct 19, 2020

Conversation

apomalyn
Copy link
Contributor

@apomalyn apomalyn commented Oct 13, 2020 •
edited by guidezpl
Loading

Description

Add the semantics flag for the sliders (Slider, RangeSlider and CupertinoSlider).

Related Issues

Replace this paragraph with a list of issues related to this PR from our issue database. Indicate, which of these issues are resolved or fixed by this PR. There should be at least one issue listed here.
Linked to:

Tests

I didn't add any tests but changed the following tests:

  • cupertino/slider_test.dart: Slider Semantics and Slider Semantics can be updated
  • material/range_slider_test.dart: Range Slider Semantics
  • material/slider_test.dart: Slider Semantics (l.1314 and l.1474) and Slider semantics with custom formatter

Checklist

Before you create this PR, confirm that it meets all requirements listed below by checking the relevant checkboxes ([x]). This will ensure a smooth and quick review process.

  • I read the Contributor Guide and followed the process outlined there for submitting PRs.
  • I signed the CLA.
  • I read and followed the Flutter Style Guide, including Features we expect every widget to implement.
  • I read the Tree Hygiene wiki page, which explains my responsibilities.
  • I updated/added relevant documentation (doc comments with ///). I don't know what to add or update
  • All existing and new tests are passing.
  • The analyzer (flutter analyze --flutter-repo) does not report any problems on my PR.
  • I am willing to follow-up on review comments in a timely manner.

Breaking Change

Did any tests fail when you ran them? Please read Handling breaking changes.

  • No, no existing tests failed, so this is not a breaking change.

Other information

After reviewing this PR if this is possible to add the label: hacktoberfest-accepted that would be wonderful. This is for the hacktoberfest challenge

@flutter-dashboard flutter-dashboard bot added a: tests "flutter test", flutter_test, or one of our tests f: cupertino flutter/packages/flutter/cupertino repository f: material design flutter/packages/flutter/material repository. framework flutter/packages/flutter repository. See also f: labels. labels Oct 13, 2020
@google-cla google-cla bot added the cla: yes label Oct 13, 2020
guidezpl
guidezpl approved these changes Oct 14, 2020
View reviewed changes
Copy link
Member

@guidezpl guidezpl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for contributing!

  _    ___ _____ __  __ 
 | |  / __|_   _|  \/  |
 | |_| (_ | | | | |\/| |
 |____\___| |_| |_|  |_|

@apomalyn
Copy link
Contributor Author

Thanks for contributing!

  _    ___ _____ __  __ 
 | |  / __|_   _|  \/  |
 | |_| (_ | | | | |\/| |
 |____\___| |_| |_|  |_|

Thanks!! Just quick question 😅 is it possible to add the label hacktoberfest-accepted so it count for the challenge? 😅

@guidezpl
Copy link
Member

I don't think we're a participating repo, but let me ask. cc @kf6gpe

@kf6gpe
Copy link
Contributor

kf6gpe commented Oct 14, 2020

Yeah, unfortunately we're not participating!! It's a good idea, though --- and thanks for your contribution!

@apomalyn
Copy link
Contributor Author

Alright, maybe next year! Thanks for letting us contribute to this repo!

@fluttergithubbot fluttergithubbot merged commit f26fbb6 into flutter:master Oct 19, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@guidezpl guidezpl guidezpl approved these changes

Assignees
No one assigned
Labels
a: tests "flutter test", flutter_test, or one of our tests f: cupertino flutter/packages/flutter/cupertino repository f: material design flutter/packages/flutter/material repository. framework flutter/packages/flutter repository. See also f: labels.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Set slider semantics flag for sliders Ensure sliders have useful a11y labels
4 participants
@apomalyn @guidezpl @kf6gpe @fluttergithubbot