Make CupertinoTabScaffold restorable #67770
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
24 tasks
justinmc
approved these changes
Oct 12, 2020
| @@ -289,43 +292,80 @@ class CupertinoTabScaffold extends StatefulWidget { | |||
| /// Defaults to true and cannot be null. | |||
| final bool resizeToAvoidBottomInset; | |||
|
|
|||
| /// Restoration ID to save and restore the state of the [CupertinoTabScaffold]. | |||
| /// | |||
| /// This property only has an affect when no [controller] has been provided: | |||
| /// will persist and restore the currently selected tab index. If a | ||
| /// [controller] has been provided, it is the responsibility of the owner of | ||
| /// that controller to persist and restore it, e.g. by using a | ||
| /// [RestorableCupertinoTabController]. |
There was a problem hiding this comment.
Are there a bunch of new restorable versions of classes now to support state restoration? This is the first state restoration PR I've taken a close look at.
There was a problem hiding this comment.
There are a few. Another example is the RestorableTextEditingController.
There was a problem hiding this comment.
Ah thanks, will study up.
| } | ||
|
|
||
| _internalController?.dispose(); |
There was a problem hiding this comment.
I think the indentation is off here if I'm seeing this right.
| if (_value != null) { | ||
| // Scheduling a microtask for dispose to give other entities a chance | ||
| // to remove their listeners first. | ||
| scheduleMicrotask(_value!.dispose); |
There was a problem hiding this comment.
I had never heard of scheduleMicrotask before, good to know.
| expect(find.text('Content 3'), findsNothing); | ||
| }); | ||
|
|
||
| testWidgets('switch from internal to external controller with state restoration', (WidgetTester tester) async { |
There was a problem hiding this comment.
Thanks for testing the controller swap too! That logic was a bit complicated.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
CupertinoTabScaffold can now restore the currently selected tab index.
Related Issues
#62916
Tests
I added the following tests:
Checklist
Before you create this PR, confirm that it meets all requirements listed below by checking the relevant checkboxes (
[x]). This will ensure a smooth and quick review process.///).flutter analyze --flutter-repo) does not report any problems on my PR.Breaking Change
Did any tests fail when you ran them? Please read Handling breaking changes.