Make CupertinoTabView restorable #67169
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
24 tasks
shihaohong
approved these changes
Oct 6, 2020
| /// Restoration ID to save and restore the state of the [Navigator] built by | ||
| /// this [CupertinoTabView]. | ||
| /// | ||
| /// {@macro flutter.widgets.navigator.restorationScopeId} |
There was a problem hiding this comment.
How does one unfamiliar with State Restoration go about learning about how to use it? I'm thinking that naturally, developers look for code samples to play around with how to use this. I personally used the test code in this PR to familiarize myself with how to use state restoration with the Navigator/CupertinoTabView.
There is a code sample at Navigator.restorablePush and Navigatoor.restorablePushNamed, so maybe we could link there?
There was a problem hiding this comment.
Good idea. I added three more links to the "see also" section in the macro.
84fe408 to
03b6484
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
CupertinoTabViewcan now restore the state of its internal Navigator if provided with e restoration ID.Related Issues
#62916
Tests
I added the following tests:
Checklist
Before you create this PR, confirm that it meets all requirements listed below by checking the relevant checkboxes (
[x]). This will ensure a smooth and quick review process.///).flutter analyze --flutter-repo) does not report any problems on my PR.Breaking Change
Did any tests fail when you ran them? Please read Handling breaking changes.