-
Notifications
You must be signed in to change notification settings - Fork 29.1k
[Material] Fix a jumping animation in the beginning of the extended Navigation Rail transition #65659
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
fluttergithubbot
merged 6 commits into
flutter:master
from
clocksmith:nav-rail-extended-fix
Sep 15, 2020
Merged
[Material] Fix a jumping animation in the beginning of the extended Navigation Rail transition #65659
fluttergithubbot
merged 6 commits into
flutter:master
from
clocksmith:nav-rail-extended-fix
Sep 15, 2020
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
perclasson
approved these changes
Sep 14, 2020
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Renzo-Olivares
approved these changes
Sep 14, 2020
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
HansMuller
approved these changes
Sep 14, 2020
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
…rail-extended-fix
rami-a
approved these changes
Sep 15, 2020
This was referenced Sep 15, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
f: material design
flutter/packages/flutter/material repository.
framework
flutter/packages/flutter repository. See also f: labels.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This change lerps the width in a SizedBox that is used as spacing in the extended nav rail, rather than using a constant value. This fixes a bug in the animation of the extended rail, which also can cause inconsistencies with the leading/trailing widgets.
Before (slowed down 15x):

After fix (slowed down 15x):

Note that the change is subtle, but it is more apparent, and causes more issues, when there are animated widgets in the leading/trailing slots of the rail.
Related Issues
closes #65657
Tests
I added the following tests:
I added 'Extended rail transition does not jump from the beginning' to navigation_rail_test.dart
Checklist
Before you create this PR, confirm that it meets all requirements listed below by checking the relevant checkboxes (
[x]
). This will ensure a smooth and quick review process.///
).flutter analyze --flutter-repo
) does not report any problems on my PR.Breaking Change
Did any tests fail when you ran them? Please read Handling breaking changes.
Since the animation does not jump, the width of the rail is slightly different mid-animation, so one of the width values had to be updated.