Skip to content

[WIP] ScaffoldMessenger Migration #64170

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 20 commits into from
Closed

[WIP] ScaffoldMessenger Migration #64170

wants to merge 20 commits into from

Conversation

Piinks
Copy link
Contributor

@Piinks Piinks commented Aug 19, 2020

Description

WIP
This migrates the integration tests and demos to use the ScaffoldMessenger API proposed in #64101

Related Issues

#62921

Tests

This should just be a refactoring, all existing tests should pass.

Checklist

Before you create this PR, confirm that it meets all requirements listed below by checking the relevant checkboxes ([x]). This will ensure a smooth and quick review process.

  • I read the Contributor Guide and followed the process outlined there for submitting PRs.
  • I signed the CLA.
  • I read and followed the Flutter Style Guide, including Features we expect every widget to implement.
  • I read the Tree Hygiene wiki page, which explains my responsibilities.
  • I updated/added relevant documentation (doc comments with ///).
  • All existing and new tests are passing.
  • The analyzer (flutter analyze --flutter-repo) does not report any problems on my PR.
  • I am willing to follow-up on review comments in a timely manner.

Breaking Change

Did any tests fail when you ran them? Please read Handling breaking changes.

Piinks added 20 commits July 20, 2020 13:47
@Piinks Piinks added framework flutter/packages/flutter repository. See also f: labels. work in progress; do not review labels Aug 19, 2020
@flutter-dashboard flutter-dashboard bot added f: material design flutter/packages/flutter/material repository. c: contributor-productivity Team-specific productivity, code health, technical debt. labels Aug 19, 2020
@flutter-dashboard
Copy link

It looks like this pull request may not have tests. Please make sure to add tests before merging. If you need an exemption to this rule, contact Hixie on the #hackers channel in Chat.

Reviewers: Read the Tree Hygiene page and make sure this patch meets those guidelines before LGTMing.

@Piinks Piinks removed the f: material design flutter/packages/flutter/material repository. label Aug 19, 2020
@Piinks Piinks mentioned this pull request Aug 25, 2020
Merged
Piinks
Piinks commented Aug 25, 2020
View reviewed changes
dev/integration_tests/flutter_gallery/lib/demo/material/snack_bar_demo.dart
@@ -44,12 +44,12 @@ class _SnackBarDemoState extends State<SnackBarDemo> {
child: const Text('SHOW A SNACKBAR'),
onPressed: () {
final int thisSnackBarIndex = _snackBarIndex++;
Scaffold.of(context).showSnackBar(SnackBar(
ScaffoldMessenger.of(context).showSnackBar(SnackBar(
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

See below on line 82, that comment needs correcting

@Piinks Piinks mentioned this pull request Aug 26, 2020
Merged
12 tasks
@fluttergithubbot
Copy link
Contributor

This pull request is not suitable for automatic merging in its current state.

  • Please get at least one approved review before re-applying this label. Reviewers: If you left a comment approving, please use the "approve" review action instead.
  • The status or check suite Linux analyze has failed. Please fix the issues identified (or deflake) before re-applying this label.
  • The status or check suite Linux build_tests has failed. Please fix the issues identified (or deflake) before re-applying this label.
  • The status or check suite Linux framework_tests has failed. Please fix the issues identified (or deflake) before re-applying this label.
  • The status or check suite Windows build_tests has failed. Please fix the issues identified (or deflake) before re-applying this label.
  • The status or check suite Windows framework_tests has failed. Please fix the issues identified (or deflake) before re-applying this label.
  • The status or check suite analyze-linux has failed. Please fix the issues identified (or deflake) before re-applying this label.
  • The status or check suite framework_tests-widgets-linux has failed. Please fix the issues identified (or deflake) before re-applying this label.
  • The status or check suite framework_tests-misc-linux has failed. Please fix the issues identified (or deflake) before re-applying this label.
  • The status or check suite deploy_gallery-linux has failed. Please fix the issues identified (or deflake) before re-applying this label.
  • The status or check suite framework_tests-widgets-macos has failed. Please fix the issues identified (or deflake) before re-applying this label.
  • The status or check suite framework_tests-misc-macos has failed. Please fix the issues identified (or deflake) before re-applying this label.
  • The status or check suite build_tests-1_last-macos has failed. Please fix the issues identified (or deflake) before re-applying this label.
  • The status or check suite deploy_gallery-macos has failed. Please fix the issues identified (or deflake) before re-applying this label.

@Piinks Piinks mentioned this pull request Sep 1, 2020
Closed
@goderbauer
Copy link
Member

We're rethinking the migration. Closing for now.

@goderbauer goderbauer closed this Sep 16, 2020
@Piinks Piinks mentioned this pull request Sep 23, 2020
Merged
9 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
c: contributor-productivity Team-specific productivity, code health, technical debt. framework flutter/packages/flutter repository. See also f: labels.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@Piinks @fluttergithubbot @goderbauer @googlebot