Skip to content

[web] Support custom url strategies #59797

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 10 commits into from
Oct 9, 2020
Merged

[web] Support custom url strategies #59797

merged 10 commits into from
Oct 9, 2020

Conversation

mdebbar
Copy link
Contributor

@mdebbar mdebbar commented Jun 18, 2020 •
edited
Loading

Expose a Dart API allowing apps to customize the url strategy.

Companion PR: flutter/engine#19134

Fixes #33245

@mdebbar mdebbar added f: routes Navigator, Router, and related APIs. platform-web Web applications specifically labels Jun 18, 2020
@mdebbar mdebbar self-assigned this Jun 18, 2020
@fluttergithubbot fluttergithubbot added c: contributor-productivity Team-specific productivity, code health, technical debt. work in progress; do not review labels Jun 18, 2020
@mdebbar mdebbar force-pushed the custom_location_strategy branch from b7ec028 to 2c71b7b Compare June 18, 2020 21:28
@mdebbar mdebbar mentioned this pull request Jun 18, 2020
Closed
@fluttergithubbot
Copy link
Contributor

This pull request is not suitable for automatic merging in its current state.

  • Please get at least one approved review before re-applying this label. Reviewers: If you left a comment approving, please use the "approve" review action instead.
  • The status or check suite analyze-linux has failed. Please fix the issues identified (or deflake) before re-applying this label.
  • The status or check suite deploy_gallery-linux has failed. Please fix the issues identified (or deflake) before re-applying this label.
  • The status or check suite deploy_gallery-macos has failed. Please fix the issues identified (or deflake) before re-applying this label.

@mdebbar mdebbar mentioned this pull request Sep 9, 2020
Closed
@jumper423 jumper423 mentioned this pull request Sep 18, 2020
Closed
@flutter-dashboard
Copy link

This pull request has not been updated in a while. Please update this pull request to receive results from Gold, or close it.

@mdebbar mdebbar force-pushed the custom_location_strategy branch from 2c71b7b to 86a8f9c Compare September 21, 2020 18:33
@mdebbar mdebbar mentioned this pull request Sep 21, 2020
Merged
@mdebbar mdebbar marked this pull request as ready for review September 21, 2020 18:57
@flutter-dashboard
Copy link

It looks like this pull request may not have tests. Please make sure to add tests before merging. If you need an exemption to this rule, contact Hixie on the #hackers channel in Chat.

Reviewers: Read the Tree Hygiene page and make sure this patch meets those guidelines before LGTMing.

@jumper423 jumper423 mentioned this pull request Sep 24, 2020
Closed
10 tasks
@mdebbar mdebbar mentioned this pull request Sep 24, 2020
Merged
@mdebbar mdebbar force-pushed the custom_location_strategy branch 2 times, most recently from f52b10c to 1c19569 Compare September 25, 2020 19:13
@mdebbar
Copy link
Contributor Author

mdebbar commented Sep 25, 2020

@yjbanov @hterkelsen @chunhtai this PR is ready for review.

yjbanov
yjbanov reviewed Sep 25, 2020
View reviewed changes
@mdebbar mdebbar mentioned this pull request Sep 28, 2020
Open
@mdebbar mdebbar force-pushed the custom_location_strategy branch from 4c33113 to 6cb8a79 Compare October 1, 2020 18:39
@mdebbar
Copy link
Contributor Author

mdebbar commented Oct 1, 2020

@yjbanov this is ready for another pass. Main things I did:

  1. Tried to make it null safe but found out the tooling doesn't allow it yet.
  2. Update docs, rename methods, etc.

@mdebbar mdebbar requested a review from yjbanov October 2, 2020 20:49
@mdebbar mdebbar force-pushed the custom_location_strategy branch from 6cb8a79 to 46f2c3f Compare October 7, 2020 17:12
yjbanov
yjbanov approved these changes Oct 8, 2020
View reviewed changes
Copy link
Contributor

@yjbanov yjbanov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@mdebbar mdebbar force-pushed the custom_location_strategy branch from 348a6b4 to a82ab25 Compare October 8, 2020 23:47
@fluttergithubbot fluttergithubbot merged commit ffcf419 into flutter:master Oct 9, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@yjbanov yjbanov yjbanov approved these changes

@harryterkelsen harryterkelsen Awaiting requested review from harryterkelsen

@chunhtai chunhtai Awaiting requested review from chunhtai

Assignees

@mdebbar mdebbar

Labels
c: contributor-productivity Team-specific productivity, code health, technical debt. f: routes Navigator, Router, and related APIs. platform-web Web applications specifically
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Flutter_web navigation should provide a way to customize url strategy
4 participants
@mdebbar @fluttergithubbot @yjbanov @googlebot