Step 1 of 2: Warn about Flutter's FloatingActionButton dependency on ThemeData accent properties #48435
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…hemeData accent properties
gspencergoog
approved these changes
Jan 8, 2020
| @@ -411,6 +423,25 @@ class FloatingActionButton extends StatelessWidget { | |||
| final ThemeData theme = Theme.of(context); | |||
| final FloatingActionButtonThemeData floatingActionButtonTheme = theme.floatingActionButtonTheme; | |||
|
|
|||
| // Applications should no longer use accentIconTheme's color to configure | |||
| // the foreground color of floating action buttons. For more information, see | |||
| // flutter.dev/go/remove-fab-accent-theme-dependency. | |||
There was a problem hiding this comment.
Make it a link: add https:// in front of the URL, so it can be clicked on in IDEs.
| @@ -117,7 +118,17 @@ void main() { | |||
| expect(_getRawMaterialButton(tester).splashColor, splashColor); | |||
| }); | |||
|
|
|||
| // The feature checked by this test has been deprecated, see | |||
| // flutter.dev/go/remove-fab-accent-theme-dependency. This test will be | |||
There was a problem hiding this comment.
Same here (make it a link).
| debugPrint = (String message, { int wrapWidth }) { | ||
| log.add(message); | ||
| }; | ||
| debugPrintBuildScope = true; |
There was a problem hiding this comment.
Good point, it's not needed in this case.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Generate a warning if a FloatingActionButton's foreground color has been configured with the Theme's accentIconTheme.
This feature has been deprecated: https://flutter.dev/go/remove-fab-accent-theme-dependency . Apps can configure the appearance of FloatingActionButtons using the theme's FloatingActionButtonTheme instead. Support for configuring the foreground color of FloatingActionButton with the Theme's accentIconTheme will be removed in the future, with #46923.
Context
This is a small part of the "Update Material Theme System" project, flutter.dev/go/material-theme-system-updates.
Currently, the ThemeData accentIconTheme property is only used by FloatingActionButton. It's the default color of the text or icons that appear within the button.
FloatingActionButton also uses ThemeData accentTextTheme property, however this dependency is undocumented and unnecessary.
Both of these dependencies are apt to be confusing. For example if one configures the Theme's accentIconTheme to change the appearance of floating action buttons, it's difficult to know what other components will be affected. Or might be affected in the future.
The Material Design spec no longer includes an "accent" color. The ColorScheme's secondary color is now used instead.
Currently applications can configure the color of text and icons within FloatingActionButtons with the widget's foregroundColor property or with the FloatingActionButtonTheme's foregroundColor. If neither foregroundColor property is specified the foreground color currently defaults to the accentIconTheme's color. The #46923 PR will cause the default to be the color scheme's onSecondary color instead.
Description of change
Currently the accentIconTheme provides a default for the FloatingActionButton's foregroundColor property:
Apps that currently configure their theme's accentIconTheme to effectively configure the foregroundColor of all floating action buttons, can get the same effect by configuring the foregroundColor of their theme's floatingActionButtonTheme. This PR removes the line that contains accentIconTheme.
The FloatingActionButton's foregroundColor is used to configure the textStyle of the RawMaterialButton created by FloatingActionButton. Currently, this text style is based on the button style of ThemeData.accentTextTheme:
Except in a case where an app has explicitly configured the accentTextTheme to take advantage of this undocumented dependency, this use of accentTextTheme is unnecessary. The #46923 PR replaces this use of accentTextTheme with textTheme.
Migration guide
To configure the FloatingActionButton's foregroundColor for all FABs, apps can configure the theme's floatingActionButtonTheme instead of its accentIconTheme.
Before
After