Allow DSS to be dragged when its children do not fill extent #31832
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
HansMuller
approved these changes
Apr 30, 2019
| @@ -280,9 +280,6 @@ class _DraggableSheetExtent { | |||
| context: context, | |||
| ).dispatch(context); | |||
| } | |||
|
|
|||
| @override | |||
There was a problem hiding this comment.
Why remove this? Maybe it wasn't helpful?
There was a problem hiding this comment.
I used it for testing at one point and accidentally committed it. I'm not sure it's exposing the right params in the right order to be helpful for anything but the local test I was doing.
|
Is there a way to programmatically reset the DraggableScrollableSheet to its original state? I've looked a DraggableScrollableActuator but I'm not sure how to implement the reset via a click. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
A
DraggableScrollableSheetwhose children will never fill its full available child height today will get "stuck" when dragged up to the full available extent of the children in the list. This is because the scroll position ends up thinking it doesn't have any extent left to give. This PR adds to the available min/max extent if we're not actually at min/max extent.This results in the following behavior:
While working on this, I also noticed that setting the maxChildSize to < 1.0 will make the dragging not "stick" to the finger. This contains a fix for that - I'd split it out but then I'd have a weird merge conflict for the tests.
Related Issues
Fixes #31739
Tests
New test to cover this scenario (smaller sized list can still be dragged up and down and doesn't get stuck).
New tests to check where the top of the container ends up when dragging for some values of maxChildSize.
Checklist
Before you create this PR confirm that it meets all requirements listed below by checking the relevant checkboxes (
[x]). This will ensure a smooth and quick review process.///).flutter analyze --flutter-repo) does not report any problems on my PR.Breaking Change
Does your PR require Flutter developers to manually update their apps to accommodate your change?