Expose decorationThickness in TextStyle. Roll engine (12 commits) #28751
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Hixie
reviewed
Mar 4, 2019
|
Will require an engine roll with flutter/engine#8008 to make tests happy |
|
(for reference) Have spoken with Hixie and have approval on the addition of the new |
goderbauer
approved these changes
Mar 11, 2019
| /// The thickness of the decoration stroke as a muliplier of the thickness | ||
| /// defined by the font. | ||
| /// | ||
| /// The font provides a base stroke width for decorations which scales off |
There was a problem hiding this comment.
This doc would probably be slightly more accessible if it gave one or two concrete examples of what a decoration stroke may be that's affected by this property.
|
Mistake fixed in flutter/engine#8141, will need to be rolled to it in order to pass. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes part of #28704
This exposes decorationThickness to painting TextStyle, which is an already implemented but hidden property in LibTxt.
Tests verify dart:ui receives the decoration thickness. The LibTxt tests verify that the thickness is respected.
git log --oneline --no-merges 5ccee95..31b289f
31b289f Fix indexing error in dart:ui TextStyle.toString (flutter/engine#8143)
fc2e6b6 Typo "fast an inline" to "fast and inline" (flutter/engine#8142)
0f19b2d Reland PerformanceOverlayLayer golden test (flutter/engine#8140)
073aadd Fix TextStyle decode misalignment (flutter/engine#8141)
d87d290 Roll src/third_party/skia 406b068942f0..2eecc3ea3d71 (11 commits) (flutter/engine#8138)
5cef4a0 Use final state passed to dart before initialization as the initial lifecycleState. (flutter/engine#8124)
ffef51b Roll src/third_party/skia 665bc64a2dc4..406b068942f0 (8 commits) (flutter/engine#8137)
48efd0f Roll src/third_party/skia 762ddd7e4352..665bc64a2dc4 (2 commits) (flutter/engine#8129)
f666adb Roll src/third_party/skia 2932a458957d..762ddd7e4352 (3 commits) (flutter/engine#8128)
8b0df6d Bugfix #29203: NPE in getAccessibilityProvider in old FlutterView. (flutter/engine#8126)
8f7b183 Roll src/third_party/skia c6d8781c4036..2932a458957d (2 commits) (flutter/engine#8125)
52b67fd Expose decorationThickness to dart:ui (flutter/engine#8008)