-
Notifications
You must be signed in to change notification settings - Fork 29.2k
Update RadioListTile
tests to M3
#129718
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update RadioListTile
tests to M3
#129718
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the change. Just left one comment:)
RadioListTile
overlay test to M3RadioListTile
tests to M3
595ca05
to
ccdebde
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! Thanks:)
4aa8677
to
96e5740
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
flutter/flutter@51bef1b...ff838bc 2023-06-29 thkim1011@users.noreply.github.com Add locale-specific DateTime formatting syntax (flutter/flutter#129573) 2023-06-29 tessertaha@gmail.com Update `RadioListTile` tests to M3 (flutter/flutter#129718) 2023-06-29 engine-flutter-autoroll@skia.org Roll Flutter Engine from 7fd0e9522ea1 to eabb22900b44 (1 revision) (flutter/flutter#129754) 2023-06-29 engine-flutter-autoroll@skia.org Roll Flutter Engine from d5c25ead07e9 to 7fd0e9522ea1 (2 revisions) (flutter/flutter#129752) 2023-06-29 tjtanjia.tan@gmail.com Fix typos in ListTile examples. (flutter/flutter#129606) 2023-06-29 engine-flutter-autoroll@skia.org Roll Flutter Engine from 4e49b9deb72d to d5c25ead07e9 (7 revisions) (flutter/flutter#129750) 2023-06-29 engine-flutter-autoroll@skia.org Roll Flutter Engine from 241ca5c1d6be to 4e49b9deb72d (1 revision) (flutter/flutter#129730) 2023-06-29 jacksongardner@google.com Skwasm benchmarks. (flutter/flutter#129681) 2023-06-28 jmccandless@google.com RTL InputDecoration fix (flutter/flutter#129661) 2023-06-28 christopherfujino@gmail.com mark autoroller flaky (flutter/flutter#129745) 2023-06-28 fluttergithubbot@gmail.com Roll pub packages (flutter/flutter#129380) 2023-06-28 109253501+pdblasi-google@users.noreply.github.com Removes deprecated APIs from AnimationBuilder (flutter/flutter#129657) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-packages Please CC camillesimon@google.com,rmistry@google.com,stuartmorgan@google.com on the revert to ensure that a human is aware of the problem. To file a bug in Packages: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md --------- Co-authored-by: Camille Simon <43054281+camsim99@users.noreply.github.com>
We might need to update the tests in this file to have a consistent format with others. |
Thanks for the ping! Updating it now. |
Update tests format context: #129718 (comment)
Update tests format context: flutter#129718 (comment)
This updates the
RadioListTile
test which was modified in #128839Description
MaterialApp
->Material
->RadioListTile
Pre-launch Checklist
///
).If you need help, consider asking for advice on the #hackers-new channel on Discord.