Skip to content

Conversation

christopherfujino
Copy link
Contributor

@christopherfujino christopherfujino commented Jun 29, 2023

Fixes #129782

Linux flutter_plugins is currently broken https://ci.chromium.org/p/flutter/builders/prod/Linux%20flutter_plugins/12884

On an analysis error that was ignored upstream in flutter/packages@5d6e48c

@flutter-dashboard
Copy link

It looks like this pull request may not have tests. Please make sure to add tests before merging. If you need an exemption to this rule, contact Hixie on the #hackers channel in Chat (don't just cc him here, he won't see it! He's on Discord!).

If you are not sure if you need tests, consider this rule of thumb: the purpose of a test is to make sure someone doesn't accidentally revert the fix. Ask yourself, is there anything in your PR that you feel it is important we not accidentally revert back to how it was before your fix?

Reviewers: Read the Tree Hygiene page and make sure this patch meets those guidelines before LGTMing.

@christopherfujino christopherfujino added warning: land on red to fix tree breakage autosubmit Merge PR when tree becomes green via auto submit App labels Jun 29, 2023
@auto-submit auto-submit bot removed the autosubmit Merge PR when tree becomes green via auto submit App label Jun 29, 2023
@auto-submit
Copy link
Contributor

auto-submit bot commented Jun 29, 2023

auto label is removed for flutter/flutter, pr: 129781, due to This PR has not met approval requirements for merging. You are a member of flutter-hackers and need 1 more review(s) in order to merge this PR.

  • Merge guidelines: You need at least one approved review if you are already part of flutter-hackers or two member reviews if you are not a flutter-hacker before re-applying the autosubmit label. Reviewers: If you left a comment approving, please use the "approve" review action instead.

@Hixie
Copy link
Contributor

Hixie commented Jun 29, 2023

test-exempt: roll

@Hixie Hixie added the autosubmit Merge PR when tree becomes green via auto submit App label Jun 29, 2023
@christopherfujino
Copy link
Contributor Author

Merging on pending Windows tool_integration_tests as this change shouldn't affect this test and this will fix the tree.

@christopherfujino christopherfujino merged commit 8b54878 into flutter:master Jun 29, 2023
@christopherfujino christopherfujino deleted the roll-packages-version branch June 29, 2023 19:27
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jul 1, 2023
auto-submit bot pushed a commit to flutter/packages that referenced this pull request Jul 1, 2023
flutter/flutter@ff838bc...aa5f4a2

2023-07-01 goderbauer@google.com Enable no_wildcard_variable_uses lint (flutter/flutter#129858)
2023-06-30 christopherfujino@gmail.com mark packages-autoroller bringup again (flutter/flutter#129859)
2023-06-30 36861262+QuncCccccc@users.noreply.github.com Update `SwitchTheme` tests for M2/M3 (flutter/flutter#129811)
2023-06-30 christopherfujino@gmail.com Change pub roller bot to push to flutter-pub-roller-bot/flutter.git (flutter/flutter#129844)
2023-06-30 greg@zulip.com Fix NetworkImage causing spurious warning in tests (flutter/flutter#129537)
2023-06-30 engine-flutter-autoroll@skia.org Roll Flutter Engine from 54b573e9c4e5 to e6b8292705a8 (4 revisions) (flutter/flutter#129852)
2023-06-30 34871572+gmackall@users.noreply.github.com Upgrade integration tests to use AGP 7.3/Gradle 7.4 (flutter/flutter#129642)
2023-06-30 engine-flutter-autoroll@skia.org Roll Packages from d4752c4 to 53ed5a0 (5 revisions) (flutter/flutter#129837)
2023-06-30 32242716+ricardoamador@users.noreply.github.com Updated correct tasks for test ownership fix (flutter/flutter#129812)
2023-06-30 hans.muller@gmail.com Updated some golden image tests for M2/M3 (flutter/flutter#129794)
2023-06-30 nbosch@google.com Remove an unnecessary assert (flutter/flutter#129796)
2023-06-30 36861262+QuncCccccc@users.noreply.github.com Update `Radio` tests for M2/M3 (flutter/flutter#129814)
2023-06-30 36861262+QuncCccccc@users.noreply.github.com Update `Switch` tests for M2/M3 (flutter/flutter#129810)
2023-06-30 engine-flutter-autoroll@skia.org Roll Flutter Engine from 099a70ebbc60 to 54b573e9c4e5 (1 revision) (flutter/flutter#129821)
2023-06-30 36861262+QuncCccccc@users.noreply.github.com Update `SwitchListTile` tests for M2/M3 (flutter/flutter#129809)
2023-06-30 tessertaha@gmail.com Fix `NavigationDrawer` selected item has wrong icon color (flutter/flutter#129625)
2023-06-30 leroux_bruno@yahoo.fr Update basic_test.dart for M3 compliance (flutter/flutter#129714)
2023-06-30 engine-flutter-autoroll@skia.org Roll Flutter Engine from d33343430f18 to 099a70ebbc60 (7 revisions) (flutter/flutter#129818)
2023-06-30 engine-flutter-autoroll@skia.org Roll Flutter Engine from 68cc1a7971d5 to d33343430f18 (2 revisions) (flutter/flutter#129801)
2023-06-30 godofredoc@google.com Revert no-response to fork. (flutter/flutter#129775)
2023-06-30 36861262+QuncCccccc@users.noreply.github.com Make `DropdownMenu` be able to scroll to the highlighted item when searching. (flutter/flutter#129740)
2023-06-29 engine-flutter-autoroll@skia.org Roll Flutter Engine from cd9ce66db14a to 68cc1a7971d5 (10 revisions) (flutter/flutter#129799)
2023-06-29 49699333+dependabot[bot]@users.noreply.github.com Bump actions/labeler from 4.1.0 to 4.2.0 (flutter/flutter#129797)
2023-06-29 engine-flutter-autoroll@skia.org Roll Flutter Engine from eabb22900b44 to cd9ce66db14a (1 revision) (flutter/flutter#129756)
2023-06-29 5236035+fzyzcjy@users.noreply.github.com Remove `@NonNull` to avoid warning (flutter/flutter#129472)
2023-06-29 32242716+ricardoamador@users.noreply.github.com Remove use of any (flutter/flutter#129793)
2023-06-29 kustermann@google.com Prepare for utf8.encode() to return more precise Uint8List type (flutter/flutter#129769)
2023-06-29 lsaudon@gmail.com Deletes files that should be ignored (flutter/flutter#127984)
2023-06-29 christopherfujino@gmail.com Fix flutter_plugins by rolling revision (flutter/flutter#129781)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-packages
Please CC dit@google.com,rmistry@google.com,stuartmorgan@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Packages: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Aug 16, 2023
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Aug 17, 2023
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Aug 17, 2023
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Aug 17, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
autosubmit Merge PR when tree becomes green via auto submit App
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Tree is red on flutter_plugins
2 participants