Skip to content

Unpin path_provider_android #129205

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 8 commits into from
Jun 22, 2023
Merged

Unpin path_provider_android #129205

merged 8 commits into from
Jun 22, 2023

Conversation

gmackall
Copy link
Member

@gmackall gmackall commented Jun 20, 2023 •
edited
Loading

Unpins path_provider_android where it is pinned. Follows the same steps as #128898.

Fixes #116376

Pre-launch Checklist

  • I read the Contributor Guide and followed the process outlined there for submitting PRs.
  • I read the Tree Hygiene wiki page, which explains my responsibilities.
  • I read and followed the Flutter Style Guide, including Features we expect every widget to implement.
  • I signed the CLA.
  • I listed at least one issue that this PR fixes in the description above.
  • I updated/added relevant documentation (doc comments with ///).
  • I added new tests to check the change I am making, or this PR is test-exempt.
  • All existing and new tests are passing.

If you need help, consider asking for advice on the #hackers-new channel on Discord.

running flutter update-packages --force-upgrade followed by ./gradlew…
4c3dfcb 
… :generateLockfiles for tests which had a path_provider_android version bump
@github-actions github-actions bot added c: contributor-productivity Team-specific productivity, code health, technical debt. tool Affects the "flutter" command-line tool. See also t: labels. labels Jun 20, 2023
christopherfujino
christopherfujino approved these changes Jun 20, 2023
View reviewed changes
Copy link
Contributor

@christopherfujino christopherfujino left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

@gmackall
Copy link
Member Author

Additional changes since the PR was created:

  1. I had forgotten to change the test that covers the pinned dependencies, so I updated that to remove path_provider_android (as it is no longer pinned).
  2. After updating the packages and re-generating lockfiles, the android_views test was failing with the error here: wonderous app fails to build: ':app:processDebugMainManifest' #128277, namely the Unable to make field private final java.lang.String java.io.File.path accessible. So I updated the AGP version the test uses to 7.3.0, which fixes this.
  3. The AGP upgrade required me to increase the java version used in the test from 8 to 11, so I added a dependency on open_jdk 11 in the .ci.yaml configuration for the android_views test.

@gmackall gmackall added the autosubmit Merge PR when tree becomes green via auto submit App label Jun 22, 2023
@auto-submit auto-submit bot removed the autosubmit Merge PR when tree becomes green via auto submit App label Jun 22, 2023
@auto-submit
Copy link
Contributor

auto-submit bot commented Jun 22, 2023

auto label is removed for flutter/flutter, pr: 129205, Mergeability of pull request flutter/flutter/129205 could not be determined at time of merge..

@gmackall
Copy link
Member Author

auto label is removed for flutter/flutter, pr: 129205, Mergeability of pull request flutter/flutter/129205 could not be determined at time of merge..

All checks are passing, has approvals, and does not have conflicts at this time, so it should be mergable. I'll try re-adding to see if it resolves

@gmackall gmackall added the autosubmit Merge PR when tree becomes green via auto submit App label Jun 22, 2023
@auto-submit auto-submit bot merged commit 51f6598 into flutter:master Jun 22, 2023
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Jun 23, 2023
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jun 23, 2023
@engine-flutter-autoroll
51f6598 Unpin path_provider_android (flutter/flutter#129205)
a9e0a6e
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Jun 23, 2023
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jun 23, 2023
@engine-flutter-autoroll
51f6598 Unpin path_provider_android (flutter/flutter#129205)
6093bfe
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Jun 23, 2023
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jun 23, 2023
@engine-flutter-autoroll
51f6598 Unpin path_provider_android (flutter/flutter#129205)
68db6ad
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Jun 23, 2023
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jun 23, 2023
@engine-flutter-autoroll
51f6598 Unpin path_provider_android (flutter/flutter#129205)
326e391
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Jun 23, 2023
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jun 23, 2023
@engine-flutter-autoroll
51f6598 Unpin path_provider_android (flutter/flutter#129205)
42d71d7
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Jun 24, 2023
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jun 24, 2023
@engine-flutter-autoroll
51f6598 Unpin path_provider_android (flutter/flutter#129205)
6bfc521
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Jun 24, 2023
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jun 24, 2023
@engine-flutter-autoroll
51f6598 Unpin path_provider_android (flutter/flutter#129205)
bd9f4f9
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Jun 24, 2023
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jun 24, 2023
@engine-flutter-autoroll
51f6598 Unpin path_provider_android (flutter/flutter#129205)
89cd212
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Jun 25, 2023
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jun 25, 2023
@engine-flutter-autoroll
51f6598 Unpin path_provider_android (flutter/flutter#129205)
22a22b5
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Jun 25, 2023
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jun 25, 2023
@engine-flutter-autoroll
51f6598 Unpin path_provider_android (flutter/flutter#129205)
a4a3de1
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Jun 25, 2023
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jun 25, 2023
@engine-flutter-autoroll
51f6598 Unpin path_provider_android (flutter/flutter#129205)
ff0eb26
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jun 26, 2023
@engine-flutter-autoroll
51f6598 Unpin path_provider_android (flutter/flutter#129205)
cab0234
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jun 26, 2023
@engine-flutter-autoroll
51f6598 Unpin path_provider_android (flutter/flutter#129205)
decadf6
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jun 26, 2023
@engine-flutter-autoroll
51f6598 Unpin path_provider_android (flutter/flutter#129205)
9c614cc
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jun 26, 2023
@engine-flutter-autoroll
51f6598 Unpin path_provider_android (flutter/flutter#129205)
b1fcd18
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jun 26, 2023
@engine-flutter-autoroll
51f6598 Unpin path_provider_android (flutter/flutter#129205)
4b1b689
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Aug 16, 2023
@engine-flutter-autoroll
51f6598 Unpin path_provider_android (flutter/flutter#129205)
40ab94b
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Aug 17, 2023
@engine-flutter-autoroll
51f6598 Unpin path_provider_android (flutter/flutter#129205)
f7971af
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Aug 17, 2023
@engine-flutter-autoroll
51f6598 Unpin path_provider_android (flutter/flutter#129205)
d34d8c3
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Aug 17, 2023
@engine-flutter-autoroll
51f6598 Unpin path_provider_android (flutter/flutter#129205)
d4941f0
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@johnmccutchan johnmccutchan johnmccutchan approved these changes

@reidbaker reidbaker Awaiting requested review from reidbaker

@camsim99 camsim99 Awaiting requested review from camsim99

+1 more reviewer

@christopherfujino christopherfujino christopherfujino approved these changes

Reviewers whose approvals may not affect merge requirements
Assignees
No one assigned
Labels
autosubmit Merge PR when tree becomes green via auto submit App c: contributor-productivity Team-specific productivity, code health, technical debt. tool Affects the "flutter" command-line tool. See also t: labels.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

path_provider_android 2.0.22 requires gradle lockfiles to be regenerated
3 participants
@gmackall @johnmccutchan @christopherfujino