Updating cirrus docker image to ubuntu focal. #128291

yusuf-goog · 2023-06-05T22:12:49Z

Bug:https://bugs.chromium.org/p/chromium/issues/detail?id=1446086

Pre-launch Checklist

I read the Contributor Guide and followed the process outlined there for submitting PRs.
I read the Tree Hygiene wiki page, which explains my responsibilities.
I read and followed the Flutter Style Guide, including Features we expect every widget to implement.
I signed the CLA.
I listed at least one issue that this PR fixes in the description above.
I updated/added relevant documentation (doc comments with ///).
I added new tests to check the change I am making, or this PR is test-exempt.
All existing and new tests are passing.

If you need help, consider asking for advice on the #hackers-new channel on Discord.

flutter-dashboard · 2023-06-05T22:12:52Z

It looks like this pull request may not have tests. Please make sure to add tests before merging. If you need an exemption to this rule, contact Hixie on the #hackers channel in Chat (don't just cc him here, he won't see it! He's on Discord!).

If you are not sure if you need tests, consider this rule of thumb: the purpose of a test is to make sure someone doesn't accidentally revert the fix. Ask yourself, is there anything in your PR that you feel it is important we not accidentally revert back to how it was before your fix?

Reviewers: Read the Tree Hygiene page and make sure this patch meets those guidelines before LGTMing.

keyonghan · 2023-06-05T22:30:13Z

Seems all cirrus tasks got cancelled:

docker build --tag gcr.io/flutter-cirrus/flutter/flutter/dev/ci/docker_linux/dockerfile:a3534cc79008c4fde2f5c4d977f2c02e --file dev/ci/docker_linux/Dockerfile ${CIRRUS_DOCKER_CONTEXT:-$CIRRUS_WORKING_DIR}
Sending build context to Docker daemon  12.26MB
Step 1/43 : FROM ubuntu:focal@sha256:b795f8e0caaaacad9859a9a38fe1c78154f8301fdaf0872eaf1520d66d9c0b9
invalid checksum digest length

yusuf-goog · 2023-06-05T22:41:30Z

Seems all cirrus tasks got cancelled:

docker build --tag gcr.io/flutter-cirrus/flutter/flutter/dev/ci/docker_linux/dockerfile:a3534cc79008c4fde2f5c4d977f2c02e --file dev/ci/docker_linux/Dockerfile ${CIRRUS_DOCKER_CONTEXT:-$CIRRUS_WORKING_DIR}
Sending build context to Docker daemon  12.26MB
Step 1/43 : FROM ubuntu:focal@sha256:b795f8e0caaaacad9859a9a38fe1c78154f8301fdaf0872eaf1520d66d9c0b9
invalid checksum digest length

Missed a char.

ricardoamador

LGTM

Adding TZ envs into Dockerfile to fix command input requirement during build. Bug:https://bugs.chromium.org/p/chromium/issues/detail?id=1446086

auto-submit · 2023-06-06T07:35:31Z

auto label is removed for flutter/flutter, pr: 128291, due to - The status or check suite Google testing has failed. Please fix the issues identified (or deflake) before re-applying this label.

…r#128291)

Roll Flutter from 0b74153 to 8a5c22e (46 revisions) flutter/flutter@0b74153...8a5c22e 2023-06-07 5236035+fzyzcjy@users.noreply.github.com Super tiny MediaQuery doc update (flutter/flutter#127904) 2023-06-07 jacksongardner@google.com Revert "Make inspector weakly referencing the inspected objects." (flutter/flutter#128436) 2023-06-07 leigha.jarett@gmail.com Update menu API docs to help developers migrate to m3 (flutter/flutter#128351) 2023-06-07 andrewrkolos@gmail.com [tools] allow explicitly specifying the JDK to use via a new config setting (flutter/flutter#128264) 2023-06-07 engine-flutter-autoroll@skia.org Roll Flutter Engine from 6f9df0f988c1 to 59d5444cf06c (3 revisions) (flutter/flutter#128376) 2023-06-07 andrewrkolos@gmail.com Do not try to load main/default asset image if only higher-res variants exist (flutter/flutter#128143) 2023-06-07 92602467+99spark@users.noreply.github.com Addressed Ambiguity in transform.scale constructor docs (flutter/flutter#128182) 2023-06-07 5236035+fzyzcjy@users.noreply.github.com Super tiny fix of dead link (flutter/flutter#128160) 2023-06-07 goderbauer@google.com Refactor tests (flutter/flutter#128371) 2023-06-07 polinach@google.com Make inspector weakly referencing the inspected objects. (flutter/flutter#128095) 2023-06-07 goderbauer@google.com Add viewId to PointerEvents (flutter/flutter#128287) 2023-06-07 5236035+fzyzcjy@users.noreply.github.com Show error message in release mode when box is not laid out without losing performance (flutter/flutter#126302) 2023-06-06 engine-flutter-autoroll@skia.org Roll Flutter Engine from ca499463ec2e to 6f9df0f988c1 (1 revision) (flutter/flutter#128363) 2023-06-06 khanhnwin@gmail.com Update Draggable YouTube video link (flutter/flutter#128078) 2023-06-06 31859944+LongCatIsLooong@users.noreply.github.com Remove more rounding hacks from TextPainter (flutter/flutter#127826) 2023-06-06 engine-flutter-autoroll@skia.org Roll Flutter Engine from 4571695f9e76 to ca499463ec2e (1 revision) (flutter/flutter#128356) 2023-06-06 43054281+camsim99@users.noreply.github.com [Android] Update plugin and module templates to use Flutter constant for `compileSdkVersion` (flutter/flutter#128073) 2023-06-06 rmolivares@renzo-olivares.dev handleSelectWord in MultiSelectableSelectionContainerDelegate should handle rects inside of rects (flutter/flutter#127478) 2023-06-06 christopherfujino@gmail.com [flutter_tools] never tree shake 0x20 (space) font codepoints on web (flutter/flutter#128302) 2023-06-06 31859944+LongCatIsLooong@users.noreply.github.com Remove `textScaleFactor` dependent logic from `AppBar` (flutter/flutter#128112) 2023-06-06 engine-flutter-autoroll@skia.org Roll Flutter Engine from b6d37f8f74ad to 4571695f9e76 (6 revisions) (flutter/flutter#128350) 2023-06-06 5236035+fzyzcjy@users.noreply.github.com Fix `Null check operator used on a null value` on TextField with contextMenuBuilder (flutter/flutter#128114) 2023-06-06 engine-flutter-autoroll@skia.org Roll Packages from db4e5c2 to da72219 (10 revisions) (flutter/flutter#128348) 2023-06-06 91688203+yusuf-goog@users.noreply.github.com Updating cirrus docker image to ubuntu focal. (flutter/flutter#128291) 2023-06-06 leigha.jarett@gmail.com Adding example for migrating to navigation drawer (flutter/flutter#128295) 2023-06-06 engine-flutter-autoroll@skia.org Roll Flutter Engine from 722aad83e5fe to b6d37f8f74ad (2 revisions) (flutter/flutter#128341) 2023-06-06 goderbauer@google.com Clean-up viewId casts in flutter_test (flutter/flutter#128256) 2023-06-06 kevinjchisholm@google.com Update cherry-pick issue template to more uniform labels. (flutter/flutter#128333) 2023-06-06 hans.muller@gmail.com Use Material3 in the 2D viewport tests (flutter/flutter#128155) 2023-06-06 nbosch@google.com Use a `show` over a `hide` for `test_api` exports (flutter/flutter#128298) 2023-06-06 engine-flutter-autoroll@skia.org Roll Flutter Engine from aaa7574375a6 to 722aad83e5fe (1 revision) (flutter/flutter#128307) 2023-06-06 leigha.jarett@gmail.com Migration guide for moving from BottomNavigationBar to NavigationBar (flutter/flutter#128263) 2023-06-06 mdebbar@google.com [web] Use 'Uri' instead of 'dart:html' to extract pathname (flutter/flutter#127983) 2023-06-06 engine-flutter-autoroll@skia.org Roll Flutter Engine from 2b353ae90731 to aaa7574375a6 (4 revisions) (flutter/flutter#128301) 2023-06-05 engine-flutter-autoroll@skia.org Roll Flutter Engine from 220ece4d9faa to 2b353ae90731 (1 revision) (flutter/flutter#128293) 2023-06-05 49699333+dependabot[bot]@users.noreply.github.com Bump actions/labeler from 4.0.4 to 4.1.0 (flutter/flutter#128290) 2023-06-05 engine-flutter-autoroll@skia.org Roll Flutter Engine from 7f12e3497428 to 220ece4d9faa (6 revisions) (flutter/flutter#128282) 2023-06-05 jonahwilliams@google.com [framework] attempt non-key solution (flutter/flutter#128273) 2023-06-05 chillers@google.com [labeler] Fix adding labels when name is directory (flutter/flutter#128243) 2023-06-05 katelovett@google.com Remove scrollbar deprecations isAlwaysShown and hoverThickness (flutter/flutter#127351) 2023-06-05 katelovett@google.com Fix update drag error that made NestedScrollView un-scrollable (flutter/flutter#127718) 2023-06-05 engine-flutter-autoroll@skia.org Roll Flutter Engine from f9f72388a4da to 7f12e3497428 (4 revisions) (flutter/flutter#128271) 2023-06-05 goderbauer@google.com Migrate SemanticsBinding to onSemanticsActionEvent (flutter/flutter#128254) 2023-06-05 engine-flutter-autoroll@skia.org Roll Flutter Engine from c838a1b05924 to f9f72388a4da (19 revisions) (flutter/flutter#128252) 2023-06-05 jonahwilliams@google.com [framework] force flexible space background to rebuild. (flutter/flutter#128138) 2023-06-05 engine-flutter-autoroll@skia.org Roll Packages from 75085ed to db4e5c2 (4 revisions) (flutter/flutter#128246) ...

…r#128291)

flutter-dashboard bot added the c: contributor-productivity Team-specific productivity, code health, technical debt. label Jun 5, 2023

yusuf-goog requested review from ricardoamador, godofredoc and keyonghan June 5, 2023 22:13

yusuf-goog force-pushed the cirrus_focal branch from 3e17e33 to 6c80979 Compare June 5, 2023 22:40

ricardoamador approved these changes Jun 5, 2023

View reviewed changes

Updating cirrus docker image to ubuntu focal.

a6e1830

Adding TZ envs into Dockerfile to fix command input requirement during build. Bug:https://bugs.chromium.org/p/chromium/issues/detail?id=1446086

yusuf-goog force-pushed the cirrus_focal branch from 6c80979 to a6e1830 Compare June 6, 2023 01:16

godofredoc approved these changes Jun 6, 2023

View reviewed changes

yusuf-goog self-assigned this Jun 6, 2023

yusuf-goog added the autosubmit Merge PR when tree becomes green via auto submit App label Jun 6, 2023

auto-submit bot removed the autosubmit Merge PR when tree becomes green via auto submit App label Jun 6, 2023

Merge branch 'master' into cirrus_focal

766860b

yusuf-goog added the autosubmit Merge PR when tree becomes green via auto submit App label Jun 6, 2023

auto-submit bot merged commit c2e6200 into flutter:master Jun 6, 2023

engine-flutter-autoroll mentioned this pull request Jun 7, 2023

Roll Flutter from 0b7415356e07 to 6848110ff3a9 (44 revisions) flutter/packages#4156

Closed

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jun 7, 2023

c2e6200 Updating cirrus docker image to ubuntu focal. (flutter/flutte…

a208993

…r#128291)

engine-flutter-autoroll mentioned this pull request Jun 7, 2023

Roll Flutter from 0b7415356e07 to 2830f0734d6c (45 revisions) flutter/packages#4158

Closed

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jun 7, 2023

c2e6200 Updating cirrus docker image to ubuntu focal. (flutter/flutte…

4b7557c

…r#128291)

engine-flutter-autoroll mentioned this pull request Jun 7, 2023

Roll Flutter from 0b7415356e07 to 8a5c22e282db (46 revisions) flutter/packages#4160

Merged

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jun 7, 2023

c2e6200 Updating cirrus docker image to ubuntu focal. (flutter/flutte…

60ad2db

…r#128291)

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Aug 16, 2023

c2e6200 Updating cirrus docker image to ubuntu focal. (flutter/flutte…

a37391a

…r#128291)

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Aug 17, 2023

c2e6200 Updating cirrus docker image to ubuntu focal. (flutter/flutte…

3769cb4

…r#128291)

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Aug 17, 2023

c2e6200 Updating cirrus docker image to ubuntu focal. (flutter/flutte…

b6235df

…r#128291)

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Aug 17, 2023

c2e6200 Updating cirrus docker image to ubuntu focal. (flutter/flutte…

cc90894

…r#128291)

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Updating cirrus docker image to ubuntu focal. #128291

Updating cirrus docker image to ubuntu focal. #128291

Uh oh!

yusuf-goog commented Jun 5, 2023

Uh oh!

flutter-dashboard bot commented Jun 5, 2023

Uh oh!

keyonghan commented Jun 5, 2023

Uh oh!

yusuf-goog commented Jun 5, 2023

Uh oh!

ricardoamador left a comment

Uh oh!

auto-submit bot commented Jun 6, 2023

Uh oh!

Uh oh!

Updating cirrus docker image to ubuntu focal. #128291

Updating cirrus docker image to ubuntu focal. #128291

Uh oh!

Conversation

yusuf-goog commented Jun 5, 2023

Pre-launch Checklist

Uh oh!

flutter-dashboard bot commented Jun 5, 2023

Uh oh!

keyonghan commented Jun 5, 2023

Uh oh!

yusuf-goog commented Jun 5, 2023

Uh oh!

ricardoamador left a comment

Choose a reason for hiding this comment

Uh oh!

auto-submit bot commented Jun 6, 2023

Uh oh!

Uh oh!