Skip to content

Reland "Migrate benchmarks to package:web" #128266

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 20 commits into from
Jun 8, 2023
Merged

Reland "Migrate benchmarks to package:web" #128266

merged 20 commits into from
Jun 8, 2023

Conversation

eyebrowsoffire
Copy link
Contributor

This attempts to reland #126848

This was reverted because it made some unexpected changes to our perf measurements. After landing #127900, we have much less noise in our benchmarks, so I'd like to reland this and see if there is still a significant measurement difference.

@flutter-dashboard flutter-dashboard bot added f: scrolling Viewports, list views, slivers, etc. c: contributor-productivity Team-specific productivity, code health, technical debt. labels Jun 5, 2023
@github-actions github-actions bot added a: tests "flutter test", flutter_test, or one of our tests d: api docs Issues with https://api.flutter.dev/ d: examples Sample code and demos documentation framework flutter/packages/flutter repository. See also f: labels. f: integration_test The flutter/packages/integration_test plugin tool Affects the "flutter" command-line tool. See also t: labels. labels Jun 5, 2023
christopherfujino
christopherfujino approved these changes Jun 5, 2023
View reviewed changes
Copy link
Contributor

@christopherfujino christopherfujino left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@christopherfujino
Copy link
Contributor

You have some import errors:

warning • Unused import: 'package:web/web.dart' • dev/benchmarks/macrobenchmarks/lib/src/web/bench_platform_view_infinite_scroll.dart:10:8 • unused_import
  error • Undefined class 'Element' • dev/benchmarks/macrobenchmarks/lib/src/web/bench_platform_view_infinite_scroll.dart:18:11 • undefined_class
  error • Undefined name 'html' • dev/benchmarks/macrobenchmarks/lib/src/web/bench_platform_view_infinite_scroll.dart:18:38 • undefined_identifier

https://ci.chromium.org/p/flutter/builders/try/Linux%20analyze/57506?

@eyebrowsoffire
Copy link
Contributor Author

You have some import errors:

warning • Unused import: 'package:web/web.dart' • dev/benchmarks/macrobenchmarks/lib/src/web/bench_platform_view_infinite_scroll.dart:10:8 • unused_import
  error • Undefined class 'Element' • dev/benchmarks/macrobenchmarks/lib/src/web/bench_platform_view_infinite_scroll.dart:18:11 • undefined_class
  error • Undefined name 'html' • dev/benchmarks/macrobenchmarks/lib/src/web/bench_platform_view_infinite_scroll.dart:18:38 • undefined_identifier

https://ci.chromium.org/p/flutter/builders/try/Linux%20analyze/57506?

Thanks! Yeah I had an issue with my rebase, I think I got it resolved.

@eyebrowsoffire
Copy link
Contributor Author

Unfortunately, the benchmark runs from the try bot still show the discrepancy on totalUiFrame: https://ci.chromium.org/ui/p/flutter/builders/try/Linux%20web_benchmarks_html/21744/overview

Looking a little closer to see if I can find the culprit.

@eyebrowsoffire eyebrowsoffire added the autosubmit Merge PR when tree becomes green via auto submit App label Jun 8, 2023
@auto-submit auto-submit bot merged commit 7c15a26 into flutter:master Jun 8, 2023
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Jun 9, 2023
Merged
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jun 9, 2023
@engine-flutter-autoroll
7c15a26 Reland "Migrate benchmarks to package:web" (flutter/flutter#1…
49a2d71 
…28266)
auto-submit bot pushed a commit to flutter/packages that referenced this pull request Jun 9, 2023
@engine-flutter-autoroll
Roll Flutter from 6e254a3 to da127f1 (28 revisions) (#4170)
914d120 
flutter/flutter@6e254a3...da127f1

2023-06-09 hans.muller@gmail.com Updated material button theme tests for Material3 (flutter/flutter#128543)
2023-06-09 engine-flutter-autoroll@skia.org Roll Flutter Engine from cb93477008d6 to 93afba901b3b (2 revisions) (flutter/flutter#128573)
2023-06-09 6655696+guidezpl@users.noreply.github.com Improve defaults generation with logging, stats, and token validation (flutter/flutter#128244)
2023-06-09 whesse@google.com [testing] Make the FLUTTER_STORAGE_BASE_URL warning non-fatal (flutter/flutter#128335)
2023-06-09 danny@tuppeny.com [flutter_tools] [DAP] Don't try to restart/reload if app hasn't started yet (flutter/flutter#128267)
2023-06-09 engine-flutter-autoroll@skia.org Roll Flutter Engine from 8f9e608d39ab to cb93477008d6 (3 revisions) (flutter/flutter#128568)
2023-06-09 tessertaha@gmail.com Replace `MaterialButton` from test classes (flutter/flutter#128466)
2023-06-09 tessertaha@gmail.com Fix `showBottomSheet` doesn't remove scrim when draggable sheet is dismissed (flutter/flutter#128455)
2023-06-09 engine-flutter-autoroll@skia.org Manual roll Flutter Engine from a5f7d5d75ff2 to 8f9e608d39ab (31 revisions) (flutter/flutter#128554)
2023-06-09 ychris@google.com Revert "test owners: cyanglaz -> vashworth" (flutter/flutter#128462)
2023-06-09 43054281+camsim99@users.noreply.github.com [Android] Bump integration tests using `compileSdkVersion` 31 to 33 (flutter/flutter#128072)
2023-06-09 dkwingsmt@users.noreply.github.com Remove single view assumption from MouseTracker, and unify its hit testing code flow (flutter/flutter#127060)
2023-06-09 christopherfujino@gmail.com [flutter_tools] Precache after channel switch (flutter/flutter#118129)
2023-06-08 leigha.jarett@gmail.com Adding migration guide for Material 3 colors (flutter/flutter#128429)
2023-06-08 gspencergoog@users.noreply.github.com Add `AppLifecycleListener`, with support for application exit handling (flutter/flutter#123274)
2023-06-08 thkim1011@users.noreply.github.com Sliver Main Axis Group (flutter/flutter#126596)
2023-06-08 31859944+LongCatIsLooong@users.noreply.github.com Reduce `_DoubleClampVisitor` false positives (flutter/flutter#128539)
2023-06-08 leigha.jarett@gmail.com Advise developers to use OverflowBar instead of ButtonBar (flutter/flutter#128437)
2023-06-08 jacksongardner@google.com Reland "Migrate benchmarks to package:web" (flutter/flutter#128266)
2023-06-08 53684884+mhbdev@users.noreply.github.com Navigator.pop before PopupMenuItem onTap call (flutter/flutter#127446)
2023-06-08 leroux_bruno@yahoo.fr Fix navigation rail with long labels misplaced highlights (flutter/flutter#128324)
2023-06-08 tessertaha@gmail.com Update `chip.dart` to use set of `MaterialState` (flutter/flutter#128507)
2023-06-08 jcollins@google.com Update flutter to dartdoc 6.3.0 and hide Icons implementation from doc pages (flutter/flutter#128442)
2023-06-08 31859944+LongCatIsLooong@users.noreply.github.com Disable blinking cursor when `EditableText.showCursor` is false (flutter/flutter#127562)
2023-06-08 41930132+hellohuanlin@users.noreply.github.com [floating_cursor_selection]add more comments on the tricky part (flutter/flutter#127227)
2023-06-08 goderbauer@google.com Move RenderObjectElement.updateChildren to Element (flutter/flutter#128458)
2023-06-08 goderbauer@google.com Fix PointerEventConverter doc (flutter/flutter#128452)
2023-06-08 engine-flutter-autoroll@skia.org Roll Packages from a84b2c2 to e13b8c4 (9 revisions) (flutter/flutter#128508)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-packages
Please CC rmistry@google.com,stuartmorgan@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Packages: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Aug 16, 2023
@engine-flutter-autoroll
7c15a26 Reland "Migrate benchmarks to package:web" (flutter/flutter#1…
a981a89 
…28266)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Aug 17, 2023
@engine-flutter-autoroll
7c15a26 Reland "Migrate benchmarks to package:web" (flutter/flutter#1…
a37fbba 
…28266)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Aug 17, 2023
@engine-flutter-autoroll
7c15a26 Reland "Migrate benchmarks to package:web" (flutter/flutter#1…
0d5049e 
…28266)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Aug 17, 2023
@engine-flutter-autoroll
7c15a26 Reland "Migrate benchmarks to package:web" (flutter/flutter#1…
d348775 
…28266)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
1 more reviewer

@christopherfujino christopherfujino christopherfujino approved these changes

Reviewers whose approvals may not affect merge requirements
Assignees
No one assigned
Labels
a: tests "flutter test", flutter_test, or one of our tests autosubmit Merge PR when tree becomes green via auto submit App c: contributor-productivity Team-specific productivity, code health, technical debt. d: api docs Issues with https://api.flutter.dev/ d: examples Sample code and demos f: integration_test The flutter/packages/integration_test plugin f: scrolling Viewports, list views, slivers, etc. framework flutter/packages/flutter repository. See also f: labels. tool Affects the "flutter" command-line tool. See also t: labels.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@eyebrowsoffire @christopherfujino