Skip to content

Conversation

aam
Copy link
Member

@aam aam commented Jun 2, 2023

The fix is coming as part of https://dart-review.git.corp.google.com/c/sdk/+/306908 dart sdk roll as well as #128084.

BUG=dart-lang/sdk#52522

@aam aam requested a review from christopherfujino as a code owner June 2, 2023 16:37
@flutter-dashboard flutter-dashboard bot added the c: contributor-productivity Team-specific productivity, code health, technical debt. label Jun 2, 2023
@github-actions github-actions bot added the tool Affects the "flutter" command-line tool. See also t: labels. label Jun 2, 2023
Copy link
Contributor

@christopherfujino christopherfujino left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@christopherfujino
Copy link
Contributor

Looks like this is gonna require import updates in the tool:

  error • Target of URI doesn't exist: 'package:dds/src/dap/protocol_generated.dart' • packages/flutter_tools/test/integration.shard/debug_adapter/flutter_adapter_test.dart:8:8 • uri_does_not_exist
  error • Target of URI doesn't exist: 'package:dds/src/dap/protocol_generated.dart' • packages/flutter_tools/test/integration.shard/debug_adapter/test_adapter_test.dart:5:8 • uri_does_not_exist

https://logs.chromium.org/logs/flutter/buildbucket/cr-buildbucket/8779384083340504225/+/u/Analyze/analyze/test_stdout

@aam
Copy link
Member Author

aam commented Jun 2, 2023

Pending Google testing seems to due to fix to AppLifecycleState.hidden not making it all the way to g3 yet. Not sure what it the right way of handling that for this PR.

cc @gspencergoog

@christopherfujino
Copy link
Contributor

Pending Google testing seems to due to fix to AppLifecycleState.hidden not making it all the to g3 yet. Not sure what it the right way of handling that for this PR.

cc @gspencergoog

looks to me like presubmit tests are still running?

STILL RUNNING     66% complete
ETA:     Jun 02, 14:32 PDT ±2min

@christopherfujino
Copy link
Contributor

christopherfujino commented Jun 2, 2023

but you're right, once it finishes there WILL be unrelated failures. once testing finishes if the only failures are due to greg's change, i'll update the github status manually in FRoB.

@christopherfujino
Copy link
Contributor

Google testing CL finished in https://cl/537415064 and the two failures are due to a257efc, so I manually set "Google testing" to green in go/flutter-rob.

@christopherfujino christopherfujino added the autosubmit Merge PR when tree becomes green via auto submit App label Jun 2, 2023
@auto-submit auto-submit bot merged commit 581ebe2 into flutter:master Jun 2, 2023
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jun 3, 2023
auto-submit bot pushed a commit to flutter/packages that referenced this pull request Jun 5, 2023
Roll Flutter from 3db9504 to 0b74153 (108 revisions)

flutter/flutter@3db9504...0b74153

2023-06-03 engine-flutter-autoroll@skia.org Roll Flutter Engine from 54293721816a to c838a1b05924 (2 revisions) (flutter/flutter#128161)
2023-06-03 engine-flutter-autoroll@skia.org Roll Flutter Engine from 8769e9ce3a90 to 54293721816a (8 revisions) (flutter/flutter#128158)
2023-06-03 goderbauer@google.com Prefix for dart:ui multiview change (flutter/flutter#128152)
2023-06-02 aam@google.com Roll dds dependency to 2.8.3 for expression evaluation upcoming fixes. (flutter/flutter#128124)
2023-06-02 engine-flutter-autoroll@skia.org Roll Flutter Engine from f3f6a020595d to 8769e9ce3a90 (3 revisions) (flutter/flutter#128149)
2023-06-02 engine-flutter-autoroll@skia.org Roll Flutter Engine from b4250acbf3ca to f3f6a020595d (3 revisions) (flutter/flutter#128147)
2023-06-02 flar@google.com Reland "Remove obsolete drawShadow bounds workaround (#127052)" (flutter/flutter#127231)
2023-06-02 engine-flutter-autoroll@skia.org Roll Flutter Engine from c6e9383f2143 to b4250acbf3ca (8 revisions) (flutter/flutter#128142)
2023-06-02 goderbauer@google.com Pre-migration for dart:ui multi view changes (flutter/flutter#128092)
2023-06-02 goderbauer@google.com Remove LiveTestRenderView (flutter/flutter#127882)
2023-06-02 engine-flutter-autoroll@skia.org Roll Flutter Engine from 02d6fbb68b69 to c6e9383f2143 (15 revisions) (flutter/flutter#128119)
2023-06-02 5236035+fzyzcjy@users.noreply.github.com Tiny remove unnecessary method in text_selection.dart (flutter/flutter#127480)
2023-06-02 vashworth@google.com Workaround for Dart VM timeout (flutter/flutter#127875)
2023-06-02 goderbauer@google.com Make --flutter-repo analyze whole repo (flutter/flutter#127990)
2023-06-02 engine-flutter-autoroll@skia.org Roll Packages from f0513ae to 75085ed (3 revisions) (flutter/flutter#128121)
2023-06-02 50433979+natsuk4ze@users.noreply.github.com [Refactor] fix quote style in template (flutter/flutter#127762)
2023-06-02 engine-flutter-autoroll@skia.org Roll Flutter Engine from 3a453f2ccb77 to 02d6fbb68b69 (14 revisions) (flutter/flutter#128089)
2023-06-02 goderbauer@google.com Fix typos in labels (flutter/flutter#128093)
2023-06-02 zanderso@users.noreply.github.com Revert "Fix issue where DevTools would not be immediately available when using --start-paused" (flutter/flutter#128117)
2023-06-02 goderbauer@google.com Sync Lints (flutter/flutter#127976)
2023-06-02 hans.muller@gmail.com Updated TabBar and ToggleButtons examples (flutter/flutter#128088)
2023-06-02 36861262+QuncCccccc@users.noreply.github.com Text should still be centered when search bar height is less than 48 (flutter/flutter#128068)
2023-06-02 fluttergithubbot@gmail.com Roll pub packages (flutter/flutter#128053)
2023-06-01 tessertaha@gmail.com Add `FilterChip.elevated`, `ChoiceChip.elevated`, & `ActionChip.elevated` variants (flutter/flutter#128049)
2023-06-01 hans.muller@gmail.com Updated custom ListTile examples (flutter/flutter#128071)
2023-06-01 bkonyi@google.com Fix issue where DevTools would not be immediately available when using --start-paused (flutter/flutter#126698)
2023-06-01 katelovett@google.com Add error message when sliver overlap absorber is missing (flutter/flutter#128075)
2023-06-01 hans.muller@gmail.com Updated Menu examples (flutter/flutter#128080)
2023-06-01 5236035+fzyzcjy@users.noreply.github.com Add retry flag to flutter_test (flutter/flutter#125851)
2023-06-01 christopherfujino@gmail.com [flutter_tools] Use process matcher for multidex test (flutter/flutter#127996)
2023-06-01 hans.muller@gmail.com Updated InputDecoratorExamples for M3 (flutter/flutter#128065)
2023-06-01 engine-flutter-autoroll@skia.org Roll Flutter Engine from 7c0a639efd0a to 3a453f2ccb77 (1 revision) (flutter/flutter#128064)
2023-06-01 christopherfujino@gmail.com migrate the package_autoroller from querying by label to title (flutter/flutter#128066)
2023-06-01 hans.muller@gmail.com Revised Floating Action Button examples (flutter/flutter#128058)
2023-06-01 engine-flutter-autoroll@skia.org Roll Flutter Engine from fdd39c421fb9 to 7c0a639efd0a (2 revisions) (flutter/flutter#128056)
2023-06-01 engine-flutter-autoroll@skia.org Roll Flutter Engine from c8e1a8d6fb57 to fdd39c421fb9 (1 revision) (flutter/flutter#128050)
2023-06-01 chillers@google.com [labeler] Remove use of any (flutter/flutter#128011)
2023-06-01 jonahwilliams@google.com [framework] remove reference to closed issue. (flutter/flutter#128007)
2023-06-01 engine-flutter-autoroll@skia.org Roll Packages from 95bb793 to f0513ae (3 revisions) (flutter/flutter#128045)
2023-06-01 vasilich6107@users.noreply.github.com Add fallback font to IconData class (flutter/flutter#127269)
2023-06-01 mdebbar@google.com [web] Assert route names start with / if using PathUrlStrategy (flutter/flutter#127986)
2023-06-01 andrewrkolos@gmail.com [tool] In `flutter doctor -v`, warn when Android Studio version could not be detected. (flutter/flutter#126395)
2023-06-01 engine-flutter-autoroll@skia.org Roll Flutter Engine from 8339c71a963c to c8e1a8d6fb57 (1 revision) (flutter/flutter#128035)
2023-06-01 engine-flutter-autoroll@skia.org Roll Flutter Engine from bc81133892a6 to 8339c71a963c (1 revision) (flutter/flutter#128034)
2023-06-01 engine-flutter-autoroll@skia.org Roll Flutter Engine from e235f47164fa to bc81133892a6 (1 revision) (flutter/flutter#128026)
2023-06-01 72562119+tgucio@users.noreply.github.com Fixes in Cupertino translations (flutter/flutter#127872)
...
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Aug 16, 2023
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Aug 17, 2023
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Aug 17, 2023
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Aug 17, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
autosubmit Merge PR when tree becomes green via auto submit App c: contributor-productivity Team-specific productivity, code health, technical debt. tool Affects the "flutter" command-line tool. See also t: labels.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants