Use Material3 in the 2D viewport tests #128155

HansMuller · 2023-06-03T00:26:38Z

Set useMaterial3: true' for the MaterialApp used in the 2D tests to enable making useMaterial3: true' the default for ThemeData in a future PR.

Piinks · 2023-06-05T15:37:00Z

packages/flutter/test/widgets/two_dimensional_viewport_test.dart

+        // TwoDimensionalChildListDelegate - builds 1 unless addRepaintBoundaries is false
+        // ModalRoute - builds 2
+        // GlowingOverscrollIndicator - builds 2
+        // RawScrollbar - builds 2


There are no scrollbars in this test.

That's correct, my mistake.

Piinks · 2023-06-05T15:37:29Z

packages/flutter/test/widgets/two_dimensional_viewport_test.dart

+        // In the tests below the number of RepaintBoundary widgets depends on:
+        // TwoDimensionalChildListDelegate - builds 1 unless addRepaintBoundaries is false
+        // ModalRoute - builds 2
+        // GlowingOverscrollIndicator - builds 2


If useMaterial 3 is true, then there is no glowing overscroll indicator, it is the stretching one.

That is correct.

packages/flutter/test/widgets/two_dimensional_viewport_test.dart

Piinks · 2023-06-05T15:38:05Z

packages/flutter/test/widgets/two_dimensional_viewport_test.dart

          case TargetPlatform.fuchsia:
+            // Includes a scrollbar and an overscroll glow


There is no scrollbar or glow.

There are two overscroll glows in this case.

Piinks · 2023-06-05T15:39:25Z

packages/flutter/test/widgets/two_dimensional_viewport_test.dart

            expect(find.byType(RepaintBoundary), findsNWidgets(7));
+
+          case TargetPlatform.android:


What makes the difference when switching to material 3 on Android here?

For Material3 a StretchingOverscrollIndicator is used and it does not create a RepaintBoundary.

Gotcha, that accounts for 2 of them, what about the other 2? since it is going from 7 to 3 on android for material 3. Just want to make sure we know what is changing here with material 3.

7 repaint boundaries:
4 - 2 GlowingOverscrollIndicators (not included in M3)
2 - 1 ModalRoute
1 - the table's cell

3 repaint boundaries:
2 - 1 ModalRoute
1 - the table's cell

Piinks · 2023-06-05T15:39:35Z

packages/flutter/test/widgets/two_dimensional_viewport_test.dart

+            // Includes a scrollbar and and overscroll glow
            expect(find.byType(RepaintBoundary), findsNWidgets(6));
+
+          case TargetPlatform.android:


Piinks

LGTM

Roll Flutter from 0b74153 to 8a5c22e (46 revisions) flutter/flutter@0b74153...8a5c22e 2023-06-07 5236035+fzyzcjy@users.noreply.github.com Super tiny MediaQuery doc update (flutter/flutter#127904) 2023-06-07 jacksongardner@google.com Revert "Make inspector weakly referencing the inspected objects." (flutter/flutter#128436) 2023-06-07 leigha.jarett@gmail.com Update menu API docs to help developers migrate to m3 (flutter/flutter#128351) 2023-06-07 andrewrkolos@gmail.com [tools] allow explicitly specifying the JDK to use via a new config setting (flutter/flutter#128264) 2023-06-07 engine-flutter-autoroll@skia.org Roll Flutter Engine from 6f9df0f988c1 to 59d5444cf06c (3 revisions) (flutter/flutter#128376) 2023-06-07 andrewrkolos@gmail.com Do not try to load main/default asset image if only higher-res variants exist (flutter/flutter#128143) 2023-06-07 92602467+99spark@users.noreply.github.com Addressed Ambiguity in transform.scale constructor docs (flutter/flutter#128182) 2023-06-07 5236035+fzyzcjy@users.noreply.github.com Super tiny fix of dead link (flutter/flutter#128160) 2023-06-07 goderbauer@google.com Refactor tests (flutter/flutter#128371) 2023-06-07 polinach@google.com Make inspector weakly referencing the inspected objects. (flutter/flutter#128095) 2023-06-07 goderbauer@google.com Add viewId to PointerEvents (flutter/flutter#128287) 2023-06-07 5236035+fzyzcjy@users.noreply.github.com Show error message in release mode when box is not laid out without losing performance (flutter/flutter#126302) 2023-06-06 engine-flutter-autoroll@skia.org Roll Flutter Engine from ca499463ec2e to 6f9df0f988c1 (1 revision) (flutter/flutter#128363) 2023-06-06 khanhnwin@gmail.com Update Draggable YouTube video link (flutter/flutter#128078) 2023-06-06 31859944+LongCatIsLooong@users.noreply.github.com Remove more rounding hacks from TextPainter (flutter/flutter#127826) 2023-06-06 engine-flutter-autoroll@skia.org Roll Flutter Engine from 4571695f9e76 to ca499463ec2e (1 revision) (flutter/flutter#128356) 2023-06-06 43054281+camsim99@users.noreply.github.com [Android] Update plugin and module templates to use Flutter constant for `compileSdkVersion` (flutter/flutter#128073) 2023-06-06 rmolivares@renzo-olivares.dev handleSelectWord in MultiSelectableSelectionContainerDelegate should handle rects inside of rects (flutter/flutter#127478) 2023-06-06 christopherfujino@gmail.com [flutter_tools] never tree shake 0x20 (space) font codepoints on web (flutter/flutter#128302) 2023-06-06 31859944+LongCatIsLooong@users.noreply.github.com Remove `textScaleFactor` dependent logic from `AppBar` (flutter/flutter#128112) 2023-06-06 engine-flutter-autoroll@skia.org Roll Flutter Engine from b6d37f8f74ad to 4571695f9e76 (6 revisions) (flutter/flutter#128350) 2023-06-06 5236035+fzyzcjy@users.noreply.github.com Fix `Null check operator used on a null value` on TextField with contextMenuBuilder (flutter/flutter#128114) 2023-06-06 engine-flutter-autoroll@skia.org Roll Packages from db4e5c2 to da72219 (10 revisions) (flutter/flutter#128348) 2023-06-06 91688203+yusuf-goog@users.noreply.github.com Updating cirrus docker image to ubuntu focal. (flutter/flutter#128291) 2023-06-06 leigha.jarett@gmail.com Adding example for migrating to navigation drawer (flutter/flutter#128295) 2023-06-06 engine-flutter-autoroll@skia.org Roll Flutter Engine from 722aad83e5fe to b6d37f8f74ad (2 revisions) (flutter/flutter#128341) 2023-06-06 goderbauer@google.com Clean-up viewId casts in flutter_test (flutter/flutter#128256) 2023-06-06 kevinjchisholm@google.com Update cherry-pick issue template to more uniform labels. (flutter/flutter#128333) 2023-06-06 hans.muller@gmail.com Use Material3 in the 2D viewport tests (flutter/flutter#128155) 2023-06-06 nbosch@google.com Use a `show` over a `hide` for `test_api` exports (flutter/flutter#128298) 2023-06-06 engine-flutter-autoroll@skia.org Roll Flutter Engine from aaa7574375a6 to 722aad83e5fe (1 revision) (flutter/flutter#128307) 2023-06-06 leigha.jarett@gmail.com Migration guide for moving from BottomNavigationBar to NavigationBar (flutter/flutter#128263) 2023-06-06 mdebbar@google.com [web] Use 'Uri' instead of 'dart:html' to extract pathname (flutter/flutter#127983) 2023-06-06 engine-flutter-autoroll@skia.org Roll Flutter Engine from 2b353ae90731 to aaa7574375a6 (4 revisions) (flutter/flutter#128301) 2023-06-05 engine-flutter-autoroll@skia.org Roll Flutter Engine from 220ece4d9faa to 2b353ae90731 (1 revision) (flutter/flutter#128293) 2023-06-05 49699333+dependabot[bot]@users.noreply.github.com Bump actions/labeler from 4.0.4 to 4.1.0 (flutter/flutter#128290) 2023-06-05 engine-flutter-autoroll@skia.org Roll Flutter Engine from 7f12e3497428 to 220ece4d9faa (6 revisions) (flutter/flutter#128282) 2023-06-05 jonahwilliams@google.com [framework] attempt non-key solution (flutter/flutter#128273) 2023-06-05 chillers@google.com [labeler] Fix adding labels when name is directory (flutter/flutter#128243) 2023-06-05 katelovett@google.com Remove scrollbar deprecations isAlwaysShown and hoverThickness (flutter/flutter#127351) 2023-06-05 katelovett@google.com Fix update drag error that made NestedScrollView un-scrollable (flutter/flutter#127718) 2023-06-05 engine-flutter-autoroll@skia.org Roll Flutter Engine from f9f72388a4da to 7f12e3497428 (4 revisions) (flutter/flutter#128271) 2023-06-05 goderbauer@google.com Migrate SemanticsBinding to onSemanticsActionEvent (flutter/flutter#128254) 2023-06-05 engine-flutter-autoroll@skia.org Roll Flutter Engine from c838a1b05924 to f9f72388a4da (19 revisions) (flutter/flutter#128252) 2023-06-05 jonahwilliams@google.com [framework] force flexible space background to rebuild. (flutter/flutter#128138) 2023-06-05 engine-flutter-autoroll@skia.org Roll Packages from 75085ed to db4e5c2 (4 revisions) (flutter/flutter#128246) ...

flutter-dashboard bot added f: scrolling Viewports, list views, slivers, etc. framework flutter/packages/flutter repository. See also f: labels. labels Jun 3, 2023

HansMuller requested a review from Piinks June 3, 2023 17:04

Piinks reviewed Jun 5, 2023

View reviewed changes

HansMuller added 3 commits June 5, 2023 10:28

Use Material3 in the 2D viewport tests

8ae64c7

fixed a typo

09b4ae8

fixed a typo

9938db9

HansMuller force-pushed the update_2d_scroll_test branch from a636642 to 9938db9 Compare June 5, 2023 18:50

Updated per review feedback

c5924b4

Piinks approved these changes Jun 6, 2023

View reviewed changes

Piinks added the autosubmit Merge PR when tree becomes green via auto submit App label Jun 6, 2023

auto-submit bot merged commit e72b471 into flutter:master Jun 6, 2023

engine-flutter-autoroll mentioned this pull request Jun 6, 2023

Roll Flutter from 0b7415356e07 to ffab83e6f3b7 (19 revisions) flutter/packages#4149

Closed

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jun 6, 2023

e72b471 Use Material3 in the 2D viewport tests (flutter/flutter#128155)

2516590

HansMuller deleted the update_2d_scroll_test branch June 6, 2023 17:22

engine-flutter-autoroll mentioned this pull request Jun 6, 2023

Roll Flutter from 0b7415356e07 to 4c5db40ff57e (20 revisions) flutter/packages#4150

Closed

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jun 6, 2023

e72b471 Use Material3 in the 2D viewport tests (flutter/flutter#128155)

5f75d47

engine-flutter-autoroll mentioned this pull request Jun 6, 2023

Roll Flutter from 0b7415356e07 to 42cf3e371a27 (21 revisions) flutter/packages#4151

Closed

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jun 6, 2023

e72b471 Use Material3 in the 2D viewport tests (flutter/flutter#128155)

9cc16b3

engine-flutter-autoroll mentioned this pull request Jun 7, 2023

Roll Flutter from 0b7415356e07 to 6848110ff3a9 (44 revisions) flutter/packages#4156

Closed

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jun 7, 2023

e72b471 Use Material3 in the 2D viewport tests (flutter/flutter#128155)

09b8ebd

engine-flutter-autoroll mentioned this pull request Jun 7, 2023

Roll Flutter from 0b7415356e07 to 2830f0734d6c (45 revisions) flutter/packages#4158

Closed

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jun 7, 2023

e72b471 Use Material3 in the 2D viewport tests (flutter/flutter#128155)

139bb17

engine-flutter-autoroll mentioned this pull request Jun 7, 2023

Roll Flutter from 0b7415356e07 to 8a5c22e282db (46 revisions) flutter/packages#4160

Merged

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jun 7, 2023

e72b471 Use Material3 in the 2D viewport tests (flutter/flutter#128155)

e295e8d

HansMuller mentioned this pull request May 18, 2023

☂️ Make useMaterial3: true by default #127064

Closed

25 tasks

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Aug 16, 2023

e72b471 Use Material3 in the 2D viewport tests (flutter/flutter#128155)

126353c

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Aug 17, 2023

e72b471 Use Material3 in the 2D viewport tests (flutter/flutter#128155)

d48ead8

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Aug 17, 2023

e72b471 Use Material3 in the 2D viewport tests (flutter/flutter#128155)

a09cae4

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Aug 17, 2023

e72b471 Use Material3 in the 2D viewport tests (flutter/flutter#128155)

b3147c9

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Use Material3 in the 2D viewport tests #128155

Use Material3 in the 2D viewport tests #128155

Uh oh!

HansMuller commented Jun 3, 2023

Uh oh!

Piinks Jun 5, 2023

Uh oh!

HansMuller Jun 5, 2023

Uh oh!

Piinks Jun 5, 2023

Uh oh!

HansMuller Jun 5, 2023

Uh oh!

Uh oh!

Piinks Jun 5, 2023

Uh oh!

HansMuller Jun 5, 2023 •

edited

Loading

Uh oh!

Piinks Jun 5, 2023

Uh oh!

HansMuller Jun 5, 2023

Uh oh!

Piinks Jun 6, 2023

Uh oh!

HansMuller Jun 6, 2023

Uh oh!

Piinks Jun 5, 2023

Uh oh!

HansMuller Jun 5, 2023

Uh oh!

Piinks left a comment

Uh oh!

Uh oh!

		case TargetPlatform.fuchsia:
		// Includes a scrollbar and an overscroll glow

		expect(find.byType(RepaintBoundary), findsNWidgets(7));

		case TargetPlatform.android:

Use Material3 in the 2D viewport tests #128155

Use Material3 in the 2D viewport tests #128155

Uh oh!

Conversation

HansMuller commented Jun 3, 2023

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

HansMuller Jun 5, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Piinks left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

HansMuller Jun 5, 2023 •

edited

Loading