Skip to content

Fix handling of AppLifecycleState.hidden #127987

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
May 31, 2023
Merged

Fix handling of AppLifecycleState.hidden #127987

merged 1 commit into from
May 31, 2023

Conversation

gspencergoog
Copy link
Contributor

Description

This fixes the parsing of AppLifecycleState in the services binding so that it knows what it is.

Related Issues

Tests

  • Added a test that causes parsing of all the different app lifecycle states.

@flutter-dashboard flutter-dashboard bot added a: tests "flutter test", flutter_test, or one of our tests framework flutter/packages/flutter repository. See also f: labels. labels May 31, 2023
@gspencergoog gspencergoog requested a review from CaseyHillers May 31, 2023 19:52
@github-actions github-actions bot removed the framework flutter/packages/flutter repository. See also f: labels. label May 31, 2023
@gspencergoog gspencergoog added autosubmit Merge PR when tree becomes green via auto submit App a: desktop Running on desktop and removed a: desktop Running on desktop labels May 31, 2023
@auto-submit auto-submit bot merged commit a257efc into flutter:master May 31, 2023
@HansMuller HansMuller mentioned this pull request Jun 2, 2023
Closed
@aam aam mentioned this pull request Jun 2, 2023
Merged
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jun 3, 2023
@engine-flutter-autoroll
a257efc Fix handling of AppLifecycleState.hidden (flutter/flutter#127987
b93d170 
)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Aug 16, 2023
@engine-flutter-autoroll
a257efc Fix handling of AppLifecycleState.hidden (flutter/flutter#127987
02eafb4 
)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Aug 17, 2023
@engine-flutter-autoroll
a257efc Fix handling of AppLifecycleState.hidden (flutter/flutter#127987
c7e52d4 
)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Aug 17, 2023
@engine-flutter-autoroll
a257efc Fix handling of AppLifecycleState.hidden (flutter/flutter#127987
c058b9f 
)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Aug 17, 2023
@engine-flutter-autoroll
a257efc Fix handling of AppLifecycleState.hidden (flutter/flutter#127987
9cc2de8 
)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
1 more reviewer

@CaseyHillers CaseyHillers CaseyHillers approved these changes

Reviewers whose approvals may not affect merge requirements
Assignees
No one assigned
Labels
a: tests "flutter test", flutter_test, or one of our tests autosubmit Merge PR when tree becomes green via auto submit App
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Asserts in ServicesBinding on receiving a lifecycle message on macOS
2 participants
@gspencergoog @CaseyHillers