Skip to content

Fix focus behavior and provided thumb and focus color aren't applied to Cupertino variant of Switch.adaptive #126688

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
May 12, 2023
Merged

Fix focus behavior and provided thumb and focus color aren't applied to Cupertino variant of Switch.adaptive #126688

merged 1 commit into from
May 12, 2023

Conversation

TahaTesser
Copy link
Member

@TahaTesser TahaTesser commented May 12, 2023 •
edited
Loading

fixes #126637
fixes #126669

To be merged after #126684

Description

  1. Fix the Cupertino variant of Switch.adaptive requires two tab key presses to focus.
  2. Fix thumbColor & focusColor aren't applied.

Before

Requires two tab presses to focus. and thumbColor & focusColor aren't applied.

Screen.Recording.2023-05-12.at.19.27.38.mov

After

Single tab key to focus (no additional focus node) and thumbColor & focusColor are applied.

Screen.Recording.2023-05-12.at.19.25.52.mov

Pre-launch Checklist

  • I read the Contributor Guide and followed the process outlined there for submitting PRs.
  • I read the Tree Hygiene wiki page, which explains my responsibilities.
  • I read and followed the Flutter Style Guide, including Features we expect every widget to implement.
  • I signed the CLA.
  • I listed at least one issue that this PR fixes in the description above.
  • I updated/added relevant documentation (doc comments with ///).
  • I added new tests to check the change I am making, or this PR is test-exempt.
  • All existing and new tests are passing.

If you need help, consider asking for advice on the #hackers-new channel on Discord.

@flutter-dashboard flutter-dashboard bot added f: material design flutter/packages/flutter/material repository. framework flutter/packages/flutter repository. See also f: labels. labels May 12, 2023
@TahaTesser TahaTesser marked this pull request as draft May 12, 2023 16:48
@TahaTesser TahaTesser marked this pull request as ready for review May 12, 2023 16:48
@TahaTesser TahaTesser force-pushed the fix_switch_adaptive_fix branch from d4414d5 to 4a02260 Compare May 12, 2023 17:32
@TahaTesser
Copy link
Member Author

@MitchellGoodwin this is good to go now

MitchellGoodwin
MitchellGoodwin approved these changes May 12, 2023
View reviewed changes
Copy link
Contributor

@MitchellGoodwin MitchellGoodwin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@TahaTesser TahaTesser changed the title Fix focus behavior and provided thumb and focus color aren't applied Cupertino variant of Switch.adaptive Fix focus behavior and provided thumb and focus color aren't applied to Cupertino variant of Switch.adaptive May 12, 2023
@TahaTesser TahaTesser added the autosubmit Merge PR when tree becomes green via auto submit App label May 12, 2023
@auto-submit auto-submit bot merged commit 96dae5e into flutter:master May 12, 2023
@TahaTesser TahaTesser deleted the fix_switch_adaptive_fix branch May 12, 2023 18:49
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request May 13, 2023
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request May 13, 2023
@engine-flutter-autoroll
96dae5e Fix focus behavior and provided thumb and focus color aren't …
e1abebc 
…applied to Cupertino variant of `Switch.adaptive` (flutter/flutter#126688)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request May 13, 2023
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request May 13, 2023
@engine-flutter-autoroll
96dae5e Fix focus behavior and provided thumb and focus color aren't …
156e9b7 
…applied to Cupertino variant of `Switch.adaptive` (flutter/flutter#126688)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request May 14, 2023
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request May 14, 2023
@engine-flutter-autoroll
96dae5e Fix focus behavior and provided thumb and focus color aren't …
f2f5569 
…applied to Cupertino variant of `Switch.adaptive` (flutter/flutter#126688)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request May 14, 2023
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request May 14, 2023
@engine-flutter-autoroll
96dae5e Fix focus behavior and provided thumb and focus color aren't …
3c1df3c 
…applied to Cupertino variant of `Switch.adaptive` (flutter/flutter#126688)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request May 14, 2023
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request May 14, 2023
@engine-flutter-autoroll
96dae5e Fix focus behavior and provided thumb and focus color aren't …
efb428b 
…applied to Cupertino variant of `Switch.adaptive` (flutter/flutter#126688)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request May 15, 2023
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request May 15, 2023
@engine-flutter-autoroll
96dae5e Fix focus behavior and provided thumb and focus color aren't …
3d5169d 
…applied to Cupertino variant of `Switch.adaptive` (flutter/flutter#126688)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request May 15, 2023
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request May 15, 2023
@engine-flutter-autoroll
96dae5e Fix focus behavior and provided thumb and focus color aren't …
ca70318 
…applied to Cupertino variant of `Switch.adaptive` (flutter/flutter#126688)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request May 15, 2023
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request May 15, 2023
@engine-flutter-autoroll
96dae5e Fix focus behavior and provided thumb and focus color aren't …
a0d4f94 
…applied to Cupertino variant of `Switch.adaptive` (flutter/flutter#126688)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request May 15, 2023
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request May 15, 2023
@engine-flutter-autoroll
96dae5e Fix focus behavior and provided thumb and focus color aren't …
d08dda3 
…applied to Cupertino variant of `Switch.adaptive` (flutter/flutter#126688)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request May 16, 2023
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request May 16, 2023
@engine-flutter-autoroll
96dae5e Fix focus behavior and provided thumb and focus color aren't …
ebc657e 
…applied to Cupertino variant of `Switch.adaptive` (flutter/flutter#126688)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request May 16, 2023
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request May 16, 2023
@engine-flutter-autoroll
96dae5e Fix focus behavior and provided thumb and focus color aren't …
1cf3c99 
…applied to Cupertino variant of `Switch.adaptive` (flutter/flutter#126688)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request May 16, 2023
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request May 16, 2023
@engine-flutter-autoroll
96dae5e Fix focus behavior and provided thumb and focus color aren't …
07b15ed 
…applied to Cupertino variant of `Switch.adaptive` (flutter/flutter#126688)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request May 16, 2023
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request May 16, 2023
@engine-flutter-autoroll
96dae5e Fix focus behavior and provided thumb and focus color aren't …
3b54fd4 
…applied to Cupertino variant of `Switch.adaptive` (flutter/flutter#126688)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request May 16, 2023
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request May 16, 2023
@engine-flutter-autoroll
96dae5e Fix focus behavior and provided thumb and focus color aren't …
088843e 
…applied to Cupertino variant of `Switch.adaptive` (flutter/flutter#126688)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request May 16, 2023
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request May 16, 2023
@engine-flutter-autoroll
96dae5e Fix focus behavior and provided thumb and focus color aren't …
781c94a 
…applied to Cupertino variant of `Switch.adaptive` (flutter/flutter#126688)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request May 16, 2023
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request May 16, 2023
@engine-flutter-autoroll
96dae5e Fix focus behavior and provided thumb and focus color aren't …
ef0afb0 
…applied to Cupertino variant of `Switch.adaptive` (flutter/flutter#126688)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request May 16, 2023
@engine-flutter-autoroll
96dae5e Fix focus behavior and provided thumb and focus color aren't …
7002f73 
…applied to Cupertino variant of `Switch.adaptive` (flutter/flutter#126688)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request May 16, 2023
@engine-flutter-autoroll
96dae5e Fix focus behavior and provided thumb and focus color aren't …
5764d0e 
…applied to Cupertino variant of `Switch.adaptive` (flutter/flutter#126688)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request May 16, 2023
@engine-flutter-autoroll
96dae5e Fix focus behavior and provided thumb and focus color aren't …
dc44a66 
…applied to Cupertino variant of `Switch.adaptive` (flutter/flutter#126688)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request May 16, 2023
@engine-flutter-autoroll
96dae5e Fix focus behavior and provided thumb and focus color aren't …
51c9a14 
…applied to Cupertino variant of `Switch.adaptive` (flutter/flutter#126688)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request May 16, 2023
@engine-flutter-autoroll
96dae5e Fix focus behavior and provided thumb and focus color aren't …
24eed7b 
…applied to Cupertino variant of `Switch.adaptive` (flutter/flutter#126688)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request May 16, 2023
@engine-flutter-autoroll
96dae5e Fix focus behavior and provided thumb and focus color aren't …
6963871 
…applied to Cupertino variant of `Switch.adaptive` (flutter/flutter#126688)
@HansMuller HansMuller mentioned this pull request May 19, 2023
Closed
CaseyHillers pushed a commit to CaseyHillers/flutter that referenced this pull request May 24, 2023
@TahaTesser
Fix focus behavior and provided thumb and focus color aren't applied …
a7043f9 
…to Cupertino variant of `Switch.adaptive` (flutter#126688)

fixes flutter#126637
fixes flutter#126669

##  ~~To be merged after flutter#126684

### Description

1.  Fix the Cupertino variant of `Switch.adaptive` requires two tab key presses to focus.
2.  Fix `thumbColor` & `focusColor` aren't applied.

### Before
Requires two tab presses to focus. and `thumbColor` & `focusColor` aren't applied.

https://github.com/flutter/flutter/assets/48603081/24635551-0794-443f-8320-32fdaa5de57a

### After
Single tab key to focus (no additional focus node) and `thumbColor` & `focusColor` are applied.

https://github.com/flutter/flutter/assets/48603081/9bf42fd8-c7e0-475a-b933-192a94650b0c
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Aug 16, 2023
@engine-flutter-autoroll
96dae5e Fix focus behavior and provided thumb and focus color aren't …
5447c3a 
…applied to Cupertino variant of `Switch.adaptive` (flutter/flutter#126688)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Aug 17, 2023
@engine-flutter-autoroll
96dae5e Fix focus behavior and provided thumb and focus color aren't …
f0a3019 
…applied to Cupertino variant of `Switch.adaptive` (flutter/flutter#126688)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Aug 17, 2023
@engine-flutter-autoroll
96dae5e Fix focus behavior and provided thumb and focus color aren't …
2835f7b 
…applied to Cupertino variant of `Switch.adaptive` (flutter/flutter#126688)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Aug 17, 2023
@engine-flutter-autoroll
96dae5e Fix focus behavior and provided thumb and focus color aren't …
4b088c5 
…applied to Cupertino variant of `Switch.adaptive` (flutter/flutter#126688)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@MitchellGoodwin MitchellGoodwin MitchellGoodwin approved these changes

@HansMuller HansMuller Awaiting requested review from HansMuller

Assignees
No one assigned
Labels
autosubmit Merge PR when tree becomes green via auto submit App f: material design flutter/packages/flutter/material repository. framework flutter/packages/flutter repository. See also f: labels.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

thumbColor & focusColor aren't provided to Cupertino variant of Switch.adaptive Switch.adaptive's _buildCupertinoSwitch adds additional focus node
2 participants
@TahaTesser @MitchellGoodwin