Sliver Main Axis Group #126596

thkim1011 · 2023-05-11T21:27:05Z

This widget implements the ability to place slivers one after another in a single ScrollView in a way that all child slivers are drawn within the bounds of the group itself (i.e. SliverPersistentHeaders aren't drawn outside of the scroll extent provided by all of the child slivers). The design document for SliverMainAxisGroup can be found here.

Fixes #33137.

Pre-launch Checklist

I read the Contributor Guide and followed the process outlined there for submitting PRs.
I read the Tree Hygiene wiki page, which explains my responsibilities.
I read and followed the Flutter Style Guide, including Features we expect every widget to implement.
I signed the CLA.
I listed at least one issue that this PR fixes in the description above.
I updated/added relevant documentation (doc comments with ///).
I added new tests to check the change I am making, or this PR is test-exempt.
All existing and new tests are passing.

If you need help, consider asking for advice on the #hackers-new channel on Discord.

flutter-dashboard · 2023-05-11T21:27:08Z

It looks like this pull request may not have tests. Please make sure to add tests before merging. If you need an exemption to this rule, contact Hixie on the #hackers channel in Chat (don't just cc him here, he won't see it! He's on Discord!).

If you are not sure if you need tests, consider this rule of thumb: the purpose of a test is to make sure someone doesn't accidentally revert the fix. Ask yourself, is there anything in your PR that you feel it is important we not accidentally revert back to how it was before your fix?

Reviewers: Read the Tree Hygiene page and make sure this patch meets those guidelines before LGTMing.

Piinks

@thkim1011 is this ready for a review?

packages/flutter/lib/src/rendering/sliver_group.dart

Piinks

Can you add some sample code that illustrates the pinned case?

Piinks · 2023-05-31T20:30:23Z

packages/flutter/lib/src/rendering/sliver_group.dart

+/// A sliver that places multiple sliver children in a linear array along the
+/// main axis.
+///
+/// Typically, the slivers will be laid out one at a time. Slivers that have been


In what case would this order of layout not occur?

I've updated the documentation to remove this line.

Piinks · 2023-05-31T20:31:25Z

packages/flutter/lib/src/rendering/sliver_group.dart

+/// main axis.
+///
+/// Typically, the slivers will be laid out one at a time. Slivers that have been
+/// scrolled past partially or entirely will be provided a nonzero scrollOffset that


Is this referring to the pinned header case? I am not sure I follow. Also, if scrollOffset is a reference, can you add a [breadcrumb]?

I've updated the documentation.

Piinks · 2023-05-31T20:32:34Z

packages/flutter/lib/src/rendering/sliver_group.dart

+/// the total layout extent of the sliver by painting slivers that are "out of
+/// bounds" with a negative [SliverPhysicalParentData.paintOffset].


I think I see now. It is bit difficult to discern which sliver you are referring to, the group as a whole or its children, can you clarify?

I clarified this point.

Piinks · 2023-05-31T20:40:59Z

packages/flutter/lib/src/rendering/sliver_group.dart

+
+  @override
+  void paint(PaintingContext context, Offset offset) {
+    RenderSliver? child = lastChild;


Can you share why this is the painting order?

I think visitChildForSemantics expects the children to be visited in paint order, so that may need to be overridden to work with this reverse paint order.

Gotcha. This is the paint order because this is how Viewport paints its sliver children. I think it's necessary for SliverPersistentHeader to be painted on top of the widgets that come after it.

Are you going to implement visitChildrenForSemantics?

Piinks · 2023-05-31T20:42:02Z

packages/flutter/lib/src/widgets/sliver.dart

+/// the main axis, one after another.
+///
+/// For pinned sliver children, the behavior is that the pinned sliver should
+/// scroll up after all of the main content has been scrolled through.


Can you add a See also for SliverCrossAxisGroup? And then add one for the cross axis group that refers back here?

Piinks · 2023-05-31T20:47:44Z

packages/flutter/lib/src/widgets/sliver.dart

+/// A sliver that places multiple sliver children in a linear array along
+/// the main axis, one after another.
+///
+/// For pinned sliver children, the behavior is that the pinned sliver should


Can you reference the API you are referring to here? Folks may not know what a pinned sliver child is in this context. Some sample code of this exact case would be really great actually. :)

packages/flutter/lib/src/rendering/sliver_group.dart

Piinks · 2023-06-02T20:16:27Z

packages/flutter/lib/src/rendering/sliver_group.dart

+/// The layout algorithm lays out slivers one by one. If the sliver is visible
+/// on the [Viewport] due to a sufficiently high [SliverConstraints.scrollOffset],
+/// then we compute a valid [SliverConstraints.scrollOffset] and
+/// [SliverConstraints.remainingPaintExtent] based on the total [SliverConstraints.scrollOffset]
+/// of all the sliver children laid out so far.


I am not sure what this paragraph is saying, can you elaborate?

packages/flutter/lib/src/rendering/sliver_group.dart

packages/flutter/lib/src/widgets/sliver.dart

brajas-quinnox · 2023-06-07T05:56:47Z

@Piinks I was wondering how to achieve the following. There are four nested listviews inside another external/parent listview. All vertical. When user starts scrolling the first nested listview and it reaches the end of scroll, now when trying to scroll the same nested listview will make the outer listview start scrolling. Is there a inbuilt solution for this in Flutter? Please let me know.

Piinks

LGTM

auto-submit · 2023-06-08T05:06:11Z

auto label is removed for flutter/flutter, pr: 126596, due to - The status or check suite Google testing has failed. Please fix the issues identified (or deflake) before re-applying this label.

flutter/flutter@6e254a3...da127f1 2023-06-09 hans.muller@gmail.com Updated material button theme tests for Material3 (flutter/flutter#128543) 2023-06-09 engine-flutter-autoroll@skia.org Roll Flutter Engine from cb93477008d6 to 93afba901b3b (2 revisions) (flutter/flutter#128573) 2023-06-09 6655696+guidezpl@users.noreply.github.com Improve defaults generation with logging, stats, and token validation (flutter/flutter#128244) 2023-06-09 whesse@google.com [testing] Make the FLUTTER_STORAGE_BASE_URL warning non-fatal (flutter/flutter#128335) 2023-06-09 danny@tuppeny.com [flutter_tools] [DAP] Don't try to restart/reload if app hasn't started yet (flutter/flutter#128267) 2023-06-09 engine-flutter-autoroll@skia.org Roll Flutter Engine from 8f9e608d39ab to cb93477008d6 (3 revisions) (flutter/flutter#128568) 2023-06-09 tessertaha@gmail.com Replace `MaterialButton` from test classes (flutter/flutter#128466) 2023-06-09 tessertaha@gmail.com Fix `showBottomSheet` doesn't remove scrim when draggable sheet is dismissed (flutter/flutter#128455) 2023-06-09 engine-flutter-autoroll@skia.org Manual roll Flutter Engine from a5f7d5d75ff2 to 8f9e608d39ab (31 revisions) (flutter/flutter#128554) 2023-06-09 ychris@google.com Revert "test owners: cyanglaz -> vashworth" (flutter/flutter#128462) 2023-06-09 43054281+camsim99@users.noreply.github.com [Android] Bump integration tests using `compileSdkVersion` 31 to 33 (flutter/flutter#128072) 2023-06-09 dkwingsmt@users.noreply.github.com Remove single view assumption from MouseTracker, and unify its hit testing code flow (flutter/flutter#127060) 2023-06-09 christopherfujino@gmail.com [flutter_tools] Precache after channel switch (flutter/flutter#118129) 2023-06-08 leigha.jarett@gmail.com Adding migration guide for Material 3 colors (flutter/flutter#128429) 2023-06-08 gspencergoog@users.noreply.github.com Add `AppLifecycleListener`, with support for application exit handling (flutter/flutter#123274) 2023-06-08 thkim1011@users.noreply.github.com Sliver Main Axis Group (flutter/flutter#126596) 2023-06-08 31859944+LongCatIsLooong@users.noreply.github.com Reduce `_DoubleClampVisitor` false positives (flutter/flutter#128539) 2023-06-08 leigha.jarett@gmail.com Advise developers to use OverflowBar instead of ButtonBar (flutter/flutter#128437) 2023-06-08 jacksongardner@google.com Reland "Migrate benchmarks to package:web" (flutter/flutter#128266) 2023-06-08 53684884+mhbdev@users.noreply.github.com Navigator.pop before PopupMenuItem onTap call (flutter/flutter#127446) 2023-06-08 leroux_bruno@yahoo.fr Fix navigation rail with long labels misplaced highlights (flutter/flutter#128324) 2023-06-08 tessertaha@gmail.com Update `chip.dart` to use set of `MaterialState` (flutter/flutter#128507) 2023-06-08 jcollins@google.com Update flutter to dartdoc 6.3.0 and hide Icons implementation from doc pages (flutter/flutter#128442) 2023-06-08 31859944+LongCatIsLooong@users.noreply.github.com Disable blinking cursor when `EditableText.showCursor` is false (flutter/flutter#127562) 2023-06-08 41930132+hellohuanlin@users.noreply.github.com [floating_cursor_selection]add more comments on the tricky part (flutter/flutter#127227) 2023-06-08 goderbauer@google.com Move RenderObjectElement.updateChildren to Element (flutter/flutter#128458) 2023-06-08 goderbauer@google.com Fix PointerEventConverter doc (flutter/flutter#128452) 2023-06-08 engine-flutter-autoroll@skia.org Roll Packages from a84b2c2 to e13b8c4 (9 revisions) (flutter/flutter#128508) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-packages Please CC rmistry@google.com,stuartmorgan@google.com on the revert to ensure that a human is aware of the problem. To file a bug in Packages: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

Areopagitics · 2023-07-02T04:27:57Z

I noticed issue #108289 regarding sticky headers was closed, since @Piinks mentioned that SliverMainAxisGroup resolved it. I just tested SliverMainAxisGroup using two pinned SliverPersistentHeaders in the main branch here using the following code and the sticky header feature still doesn't work:

import 'package:flutter/material.dart';

void main() => runApp(const SliverMainAxisGroupExampleApp());

class SliverMainAxisGroupExampleApp extends StatelessWidget {
  const SliverMainAxisGroupExampleApp({super.key});

  @override
  Widget build(BuildContext context) {
    return MaterialApp(
      home: Scaffold(
        appBar: AppBar(title: const Text('SliverMainAxisGroup Sample')),
        body: const SliverMainAxisGroupExample(),
      ),
    );
  }
}

class Delegate extends SliverPersistentHeaderDelegate {
  final Color backgroundColor;
  final String _title;

  Delegate(this.backgroundColor, this._title);

  @override
  Widget build(BuildContext context, double shrinkOffset, bool overlapsContent) {
    return Container(
      color: backgroundColor,
      child: Center(
        child: Text(
          _title,
          style: const TextStyle(
            color: Colors.black,
            fontSize: 25,
          ),
        ),
      ),
    );
  }

  @override
  double get maxExtent => 50;

  @override
  double get minExtent => 50;

  @override
  bool shouldRebuild(SliverPersistentHeaderDelegate oldDelegate) {
    return true;
  }
}

class SliverMainAxisGroupExample extends StatelessWidget {
  const SliverMainAxisGroupExample({super.key});

  @override
  Widget build(BuildContext context) {
    return CustomScrollView(
      slivers: <Widget>[
        SliverMainAxisGroup(
          slivers: <Widget>[
            SliverPersistentHeader(
              pinned: true,
              floating: false,
              delegate: Delegate(Colors.white, 'Test'),
          ),
            SliverList.builder(
              itemBuilder: (BuildContext context, int index) {
                return Container(
                  color: index.isEven ? Colors.amber[300] : Colors.blue[300],
                  height: 100.0,
                  child: Center(
                    child: Text(
                      'Item $index',
                      style: const TextStyle(fontSize: 24),
                    ),
                  ),
                );
              },
              itemCount: 5,
            ),
            SliverPersistentHeader(
                pinned: true,
                floating: false,
                delegate: Delegate(Colors.white, 'Test2'),
            ),
            SliverList.builder(
              itemBuilder: (BuildContext context, int index) {
                return Container(
                  color: index.isEven ? Colors.amber[300] : Colors.blue[300],
                  height: 100.0,
                  child: Center(
                    child: Text(
                      'Item $index',
                      style: const TextStyle(fontSize: 24),
                    ),
                  ),
                );
              },
              itemCount: 5,
            ),
            SliverToBoxAdapter(
              child: Container(
                color: Colors.cyan,
                height: 100,
                child: const Center(
                  child: Text('Another sliver child',
                      style: TextStyle(fontSize: 24)),
                ),
              ),
            )
          ],
        ),
        SliverToBoxAdapter(
          child: Container(
            height: 1000,
            decoration: const BoxDecoration(color: Colors.greenAccent),
            child: const Center(
              child: Text('Hello World!', style: TextStyle(fontSize: 24)),
            ),
          ),
        ),
      ],
    );
  }
}

rMozes · 2023-07-02T07:38:23Z

I noticed issue #108289 regarding sticky headers was closed, since @Piinks mentioned that SliverMainAxisGroup resolved it. I just tested SliverMainAxisGroup using two pinned SliverPersistentHeaders in the main branch here using the following code and the sticky header feature still doesn't work:

import 'package:flutter/material.dart';

void main() => runApp(const SliverMainAxisGroupExampleApp());

class SliverMainAxisGroupExampleApp extends StatelessWidget {
  const SliverMainAxisGroupExampleApp({super.key});

  @override
  Widget build(BuildContext context) {
    return MaterialApp(
      home: Scaffold(
        appBar: AppBar(title: const Text('SliverMainAxisGroup Sample')),
        body: const SliverMainAxisGroupExample(),
      ),
    );
  }
}

class Delegate extends SliverPersistentHeaderDelegate {
  final Color backgroundColor;
  final String _title;

  Delegate(this.backgroundColor, this._title);

  @override
  Widget build(BuildContext context, double shrinkOffset, bool overlapsContent) {
    return Container(
      color: backgroundColor,
      child: Center(
        child: Text(
          _title,
          style: const TextStyle(
            color: Colors.black,
            fontSize: 25,
          ),
        ),
      ),
    );
  }

  @override
  double get maxExtent => 50;

  @override
  double get minExtent => 50;

  @override
  bool shouldRebuild(SliverPersistentHeaderDelegate oldDelegate) {
    return true;
  }
}

class SliverMainAxisGroupExample extends StatelessWidget {
  const SliverMainAxisGroupExample({super.key});

  @override
  Widget build(BuildContext context) {
    return CustomScrollView(
      slivers: <Widget>[
        SliverMainAxisGroup(
          slivers: <Widget>[
            SliverPersistentHeader(
              pinned: true,
              floating: false,
              delegate: Delegate(Colors.white, 'Test'),
          ),
            SliverList.builder(
              itemBuilder: (BuildContext context, int index) {
                return Container(
                  color: index.isEven ? Colors.amber[300] : Colors.blue[300],
                  height: 100.0,
                  child: Center(
                    child: Text(
                      'Item $index',
                      style: const TextStyle(fontSize: 24),
                    ),
                  ),
                );
              },
              itemCount: 5,
            ),
            SliverPersistentHeader(
                pinned: true,
                floating: false,
                delegate: Delegate(Colors.white, 'Test2'),
            ),
            SliverList.builder(
              itemBuilder: (BuildContext context, int index) {
                return Container(
                  color: index.isEven ? Colors.amber[300] : Colors.blue[300],
                  height: 100.0,
                  child: Center(
                    child: Text(
                      'Item $index',
                      style: const TextStyle(fontSize: 24),
                    ),
                  ),
                );
              },
              itemCount: 5,
            ),
            SliverToBoxAdapter(
              child: Container(
                color: Colors.cyan,
                height: 100,
                child: const Center(
                  child: Text('Another sliver child',
                      style: TextStyle(fontSize: 24)),
                ),
              ),
            )
          ],
        ),
        SliverToBoxAdapter(
          child: Container(
            height: 1000,
            decoration: const BoxDecoration(color: Colors.greenAccent),
            child: const Center(
              child: Text('Hello World!', style: TextStyle(fontSize: 24)),
            ),
          ),
        ),
      ],
    );
  }
}

@Areopagitics probably you should wrap each header in different SliverMainAxisGroup in order to make it work

Areopagitics · 2023-07-03T17:48:35Z

@rMozes Thank you so much! I'm guessing, though, that this feature will take another month or so to land in the stable branch.

Here is some sample code for Sticky Headers that others can test here for future reference:

import 'package:flutter/material.dart';

void main() => runApp(const SliverMainAxisGroupExampleApp());

class SliverMainAxisGroupExampleApp extends StatelessWidget {
  const SliverMainAxisGroupExampleApp({super.key});

  @override
  Widget build(BuildContext context) {
    return MaterialApp(
      home: Scaffold(
        appBar: AppBar(title: const Text('SliverMainAxisGroup Sample')),
        body: const SliverMainAxisGroupExample(),
      ),
    );
  }
}

class Delegate extends SliverPersistentHeaderDelegate {
  final Color backgroundColor;
  final String _title;

  Delegate(this.backgroundColor, this._title);

  @override
  Widget build(BuildContext context, double shrinkOffset, bool overlapsContent) {
    return Container(
      color: backgroundColor,
      child: Center(
        child: Text(
          _title,
          style: const TextStyle(
            color: Colors.black,
            fontSize: 25,
          ),
        ),
      ),
    );
  }

  @override
  double get maxExtent => 50;

  @override
  double get minExtent => 50;

  @override
  bool shouldRebuild(SliverPersistentHeaderDelegate oldDelegate) {
    return true;
  }
}

class SliverMainAxisGroupExample extends StatelessWidget {
  const SliverMainAxisGroupExample({super.key});

  @override
  Widget build(BuildContext context) {
    return CustomScrollView(
      slivers: <Widget>[
        SliverMainAxisGroup(
          slivers: <Widget>[
            SliverPersistentHeader(
              pinned: true,
              floating: false,
              delegate: Delegate(Colors.white, 'Test'),
          ),
            SliverList.builder(
              itemBuilder: (BuildContext context, int index) {
                return Container(
                  color: index.isEven ? Colors.amber[300] : Colors.blue[300],
                  height: 100.0,
                  child: Center(
                    child: Text(
                      'Item $index',
                      style: const TextStyle(fontSize: 24),
                    ),
                  ),
                );
              },
              itemCount: 5,
            ),
          ],
        ),
       SliverMainAxisGroup(
          slivers: <Widget>[
            SliverPersistentHeader(
              pinned: true,
              floating: false,
              delegate: Delegate(Colors.white, 'Test 2'),
          ),
            SliverList.builder(
              itemBuilder: (BuildContext context, int index) {
                return Container(
                  color: index.isEven ? Colors.amber[300] : Colors.blue[300],
                  height: 100.0,
                  child: Center(
                    child: Text(
                      'Item $index',
                      style: const TextStyle(fontSize: 24),
                    ),
                  ),
                );
              },
              itemCount: 5,
            ),
          ],
        ),
      ],
    );
  }
}

Areopagitics · 2023-07-26T01:55:11Z

I've been testing SliverMainAxisGroup and it would be a nice feature if a Sliverlist inside a SliverMainAxisGroup could have a center key in CustomScrollView. For now only the immediate child of the CustomScrollView will work with its center key feature.

Piinks · 2023-07-26T20:40:27Z

probably you should wrap each header in different SliverMainAxisGroup in order to make it work

This is correct.

Regarding the behavior of center, that is the intended behavior and is not specific to SliverMainAxisGroup.

The center must be the key of one of the slivers built by buildSlivers.

https://api.flutter.dev/flutter/widgets/ScrollView/center.html

Please file an issue request if you would like to see this work differently. Comments on old PRs are typically not responded to.

Fixes #145068 The original tests for SliverMainAxisGroup did not actually check where the child was painted (#126596). Followed the same pattern in RenderSliverMultiBoxAdaptor: https://github.com/flutter/flutter/blob/11c034f0371eb28576d41a0c218ccae6b38e7702/packages/flutter/lib/src/rendering/sliver_multi_box_adaptor.dart#L666

flutter-dashboard bot added f: scrolling Viewports, list views, slivers, etc. framework flutter/packages/flutter repository. See also f: labels. labels May 11, 2023

thkim1011 marked this pull request as draft May 11, 2023 21:27

goderbauer requested a review from Piinks May 16, 2023 22:10

Piinks reviewed May 19, 2023

View reviewed changes

github-actions bot removed framework flutter/packages/flutter repository. See also f: labels. f: scrolling Viewports, list views, slivers, etc. labels May 29, 2023

flutter-dashboard bot added f: scrolling Viewports, list views, slivers, etc. framework flutter/packages/flutter repository. See also f: labels. labels May 30, 2023

thkim1011 marked this pull request as ready for review May 30, 2023 03:25

thkim1011 requested a review from Piinks May 30, 2023 03:25

github-actions bot removed f: scrolling Viewports, list views, slivers, etc. framework flutter/packages/flutter repository. See also f: labels. labels May 30, 2023

Piinks reviewed May 31, 2023

View reviewed changes

packages/flutter/lib/src/rendering/sliver_group.dart Outdated Show resolved Hide resolved

Piinks reviewed May 31, 2023

View reviewed changes

thkim1011 requested a review from Piinks June 1, 2023 20:36

Piinks reviewed Jun 2, 2023

View reviewed changes

packages/flutter/lib/src/rendering/sliver_group.dart Outdated Show resolved Hide resolved

Piinks reviewed Jun 2, 2023

View reviewed changes

packages/flutter/lib/src/rendering/sliver_group.dart Outdated Show resolved Hide resolved

Piinks reviewed Jun 2, 2023

View reviewed changes

packages/flutter/lib/src/widgets/sliver.dart Show resolved Hide resolved

thkim1011 requested a review from Piinks June 6, 2023 20:26

Piinks approved these changes Jun 7, 2023

View reviewed changes

Piinks and others added 3 commits June 7, 2023 13:09

Update packages/flutter/lib/src/widgets/sliver.dart

7a7c42b

make documentation clearer

1995244

visit children

adb1f06

Piinks force-pushed the tae/sliver-main-axis-group branch from 41a6d2d to adb1f06 Compare June 7, 2023 18:29

Piinks added the autosubmit Merge PR when tree becomes green via auto submit App label Jun 7, 2023

auto-submit bot removed the autosubmit Merge PR when tree becomes green via auto submit App label Jun 8, 2023

thkim1011 added 2 commits June 8, 2023 08:41

Merge branch 'master' into tae/sliver-main-axis-group

e98ff7f

Merge branch 'master' into tae/sliver-main-axis-group

7952c5d

thkim1011 merged commit f2351f6 into flutter:master Jun 8, 2023

This was referenced Jun 8, 2023

[Proposal]SliverPersistantHeader should support Sticky Headers #108289

Closed

NestedScrollView : is there any way to support multiple child for SliverOverlapAbsorber #22393

Closed

engine-flutter-autoroll mentioned this pull request Jun 9, 2023

Roll Flutter from 6e254a3f9fb7 to da127f15ad54 (28 revisions) flutter/packages#4170

Merged

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jun 9, 2023

f2351f6 Sliver Main Axis Group (flutter/flutter#126596)

527239d

HansMuller mentioned this pull request Jun 9, 2023

Flutter Framework Team: Notable Commits #121415

Closed

Areopagitics mentioned this pull request Jul 3, 2023

[BUG] Jumpy header inside CustomScrollView with center key fluttercommunity/flutter_sticky_headers#67

Open

thkim1011 deleted the tae/sliver-main-axis-group branch July 26, 2023 20:44

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Aug 16, 2023

f2351f6 Sliver Main Axis Group (flutter/flutter#126596)

cdcef69

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Aug 17, 2023

f2351f6 Sliver Main Axis Group (flutter/flutter#126596)

9de66c9

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Aug 17, 2023

f2351f6 Sliver Main Axis Group (flutter/flutter#126596)

0ed4300

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Aug 17, 2023

f2351f6 Sliver Main Axis Group (flutter/flutter#126596)

0da3f0a

Piinks mentioned this pull request Mar 21, 2024

Fix SliverMainAxisGroup layout in reverse #145572

Merged

9 tasks

Areopagitics mentioned this pull request Jul 19, 2024

ListView with sticky header and reordable items features #51107

Open

		/// the total layout extent of the sliver by painting slivers that are "out of
		/// bounds" with a negative [SliverPhysicalParentData.paintOffset].

Sliver Main Axis Group #126596

Sliver Main Axis Group #126596

Uh oh!

Conversation

thkim1011 commented May 11, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Pre-launch Checklist

Uh oh!

flutter-dashboard bot commented May 11, 2023

Uh oh!

Piinks left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Piinks left a comment

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

brajas-quinnox commented Jun 7, 2023

Uh oh!

Piinks left a comment

Choose a reason for hiding this comment

Uh oh!

auto-submit bot commented Jun 8, 2023

Uh oh!

Areopagitics commented Jul 2, 2023

Uh oh!

rMozes commented Jul 2, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Areopagitics commented Jul 3, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Areopagitics commented Jul 26, 2023

Uh oh!

Piinks commented Jul 26, 2023

Uh oh!

Uh oh!

thkim1011 commented May 11, 2023 •

edited

Loading

rMozes commented Jul 2, 2023 •

edited

Loading

Areopagitics commented Jul 3, 2023 •

edited

Loading