Skip to content

Remove unecessary reference to ClipboardStatusNotifier #125255

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Apr 21, 2023
Merged

Remove unecessary reference to ClipboardStatusNotifier #125255

merged 2 commits into from
Apr 21, 2023

Conversation

chunhtai
Copy link
Contributor

fixes #99360

Pre-launch Checklist

  • I read the Contributor Guide and followed the process outlined there for submitting PRs.
  • I read the Tree Hygiene wiki page, which explains my responsibilities.
  • I read and followed the Flutter Style Guide, including Features we expect every widget to implement.
  • I signed the CLA.
  • I listed at least one issue that this PR fixes in the description above.
  • I updated/added relevant documentation (doc comments with ///).
  • I added new tests to check the change I am making, or this PR is test-exempt.
  • All existing and new tests are passing.

If you need help, consider asking for advice on the #hackers-new channel on Discord.

@flutter-dashboard flutter-dashboard bot added a: text input Entering text in a text field or keyboard related problems f: cupertino flutter/packages/flutter/cupertino repository f: material design flutter/packages/flutter/material repository. framework flutter/packages/flutter repository. See also f: labels. labels Apr 20, 2023
@chunhtai chunhtai requested a review from justinmc April 20, 2023 22:31
justinmc
justinmc approved these changes Apr 20, 2023
View reviewed changes
Copy link
Contributor

@justinmc justinmc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

packages/flutter/lib/src/cupertino/text_selection.dart
@@ -209,7 +209,7 @@ class _CupertinoTextSelectionControlsToolbar extends StatefulWidget {
required this.textLineHeight,
});

final ValueNotifier<ClipboardStatus>? clipboardStatus;
final ValueListenable<ClipboardStatus>? clipboardStatus;
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why the changes from ValueNotifier to ValueListenable?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It is not using the notifier api, the builder should not be mutating the state of ClipboardStatus anyway.

@chunhtai chunhtai added the autosubmit Merge PR when tree becomes green via auto submit App label Apr 21, 2023
@auto-submit auto-submit bot removed the autosubmit Merge PR when tree becomes green via auto submit App label Apr 21, 2023
@auto-submit
Copy link
Contributor

auto-submit bot commented Apr 21, 2023

auto label is removed for flutter/flutter, pr: 125255, due to - The status or check suite Windows build_tests_1_3 has failed. Please fix the issues identified (or deflake) before re-applying this label.

@chunhtai chunhtai added the autosubmit Merge PR when tree becomes green via auto submit App label Apr 21, 2023
@auto-submit auto-submit bot merged commit 8a815c1 into flutter:master Apr 21, 2023
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Apr 22, 2023
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Apr 22, 2023
@engine-flutter-autoroll
8a815c1 Remove unecessary reference to ClipboardStatusNotifier (flutt…
ed2da91 
…er/flutter#125255)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Apr 22, 2023
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Apr 22, 2023
@engine-flutter-autoroll
8a815c1 Remove unecessary reference to ClipboardStatusNotifier (flutt…
a709290 
…er/flutter#125255)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Apr 23, 2023
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Apr 23, 2023
@engine-flutter-autoroll
8a815c1 Remove unecessary reference to ClipboardStatusNotifier (flutt…
49a749e 
…er/flutter#125255)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Apr 23, 2023
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Apr 23, 2023
@engine-flutter-autoroll
8a815c1 Remove unecessary reference to ClipboardStatusNotifier (flutt…
fa486b0 
…er/flutter#125255)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Apr 24, 2023
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Apr 24, 2023
@engine-flutter-autoroll
8a815c1 Remove unecessary reference to ClipboardStatusNotifier (flutt…
5aa1577 
…er/flutter#125255)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Apr 24, 2023
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Apr 24, 2023
@engine-flutter-autoroll
8a815c1 Remove unecessary reference to ClipboardStatusNotifier (flutt…
c42b309 
…er/flutter#125255)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Apr 24, 2023
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Apr 24, 2023
@engine-flutter-autoroll
8a815c1 Remove unecessary reference to ClipboardStatusNotifier (flutt…
3cf61e9 
…er/flutter#125255)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Apr 24, 2023
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Apr 24, 2023
@engine-flutter-autoroll
8a815c1 Remove unecessary reference to ClipboardStatusNotifier (flutt…
655172d 
…er/flutter#125255)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Apr 25, 2023
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Apr 25, 2023
@engine-flutter-autoroll
8a815c1 Remove unecessary reference to ClipboardStatusNotifier (flutt…
5b94783 
…er/flutter#125255)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Apr 25, 2023
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Apr 25, 2023
@engine-flutter-autoroll
8a815c1 Remove unecessary reference to ClipboardStatusNotifier (flutt…
93c7422 
…er/flutter#125255)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Apr 25, 2023
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Apr 25, 2023
@engine-flutter-autoroll
8a815c1 Remove unecessary reference to ClipboardStatusNotifier (flutt…
55ecd5d 
…er/flutter#125255)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Apr 26, 2023
@engine-flutter-autoroll
8a815c1 Remove unecessary reference to ClipboardStatusNotifier (flutt…
b742a0b 
…er/flutter#125255)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Apr 26, 2023
@engine-flutter-autoroll
8a815c1 Remove unecessary reference to ClipboardStatusNotifier (flutt…
9d6d5e8 
…er/flutter#125255)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Apr 26, 2023
@engine-flutter-autoroll
8a815c1 Remove unecessary reference to ClipboardStatusNotifier (flutt…
23fa358 
…er/flutter#125255)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@justinmc justinmc justinmc approved these changes

Assignees
No one assigned
Labels
a: text input Entering text in a text field or keyboard related problems autosubmit Merge PR when tree becomes green via auto submit App f: cupertino flutter/packages/flutter/cupertino repository f: material design flutter/packages/flutter/material repository. framework flutter/packages/flutter repository. See also f: labels.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Apply soft-transition to devtools for ClipboardStatusNotifier change
2 participants
@chunhtai @justinmc