Skip to content

Fix typos #121171

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 5 commits into from
Feb 23, 2023
Merged

Fix typos #121171

merged 5 commits into from
Feb 23, 2023

Conversation

Lioness100
Copy link
Contributor

@Lioness100 Lioness100 commented Feb 21, 2023 •
edited
Loading

This PR fixes some typos throughout the repo. I didn't change maxDescendentsTruncatableNode, since it looks public, but I think it should be maxDescendantsTruncatableNode?

Pre-launch Checklist

  • I read the [Contributor Guide] and followed the process outlined there for submitting PRs.
  • I read the [Tree Hygiene] wiki page, which explains my responsibilities.
  • I read and followed the [Flutter Style Guide], including [Features we expect every widget to implement].
  • I signed the [CLA].
  • I listed at least one issue that this PR fixes in the description above.
  • I updated/added relevant documentation (doc comments with ///).
  • I added new tests to check the change I am making, or this PR is [test-exempt].
  • All existing and new tests are passing.

@flutter-dashboard flutter-dashboard bot added a: accessibility Accessibility, e.g. VoiceOver or TalkBack. (aka a11y) a: animation Animation APIs a: tests "flutter test", flutter_test, or one of our tests a: text input Entering text in a text field or keyboard related problems d: api docs Issues with https://api.flutter.dev/ d: examples Sample code and demos documentation f: cupertino flutter/packages/flutter/cupertino repository f: focus Focus traversal, gaining or losing focus f: gestures flutter/packages/flutter/gestures repository. f: material design flutter/packages/flutter/material repository. f: scrolling Viewports, list views, slivers, etc. framework flutter/packages/flutter repository. See also f: labels. f: integration_test The flutter/packages/integration_test plugin platform-ios iOS applications specifically c: contributor-productivity Team-specific productivity, code health, technical debt. tool Affects the "flutter" command-line tool. See also t: labels. labels Feb 21, 2023
goderbauer
goderbauer approved these changes Feb 22, 2023
View reviewed changes
Copy link
Member

@goderbauer goderbauer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM and thank you so much!

How did you identify these spelling errors? Did you use any kind of automated tool?

@goderbauer
Copy link
Member

Looks like it is failing some checks, though. Can you take a look and make sure that none of the spelling errors were load-barring? :)

@Lioness100
Copy link
Contributor Author

Lioness100 commented Feb 22, 2023 •
edited
Loading

Sorry, I'm not sure which change is causing CI to fail 🤔.

How did you identify these spelling errors? Did you use any kind of automated tool?

This was a trial run for a CLI I made that helps find and fix typos :)

@goderbauer
Copy link
Member

Looks like the failures are actually caused by an infra issue: #121242 Our infra team is investigating. When you get a chance, can you resolve the merge conflict, though? Thanks!

gspencergoog
gspencergoog approved these changes Feb 22, 2023
View reviewed changes
Copy link
Contributor

@gspencergoog gspencergoog left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

32384589-a60f0e74-c078-11e7-9bc1-e5b5287aea9d

Bravo! Thanks for all the fixes. I make an API Docs pass for typos every year, but hadn't gotten around to regular comments and code.

@goderbauer goderbauer added the autosubmit Merge PR when tree becomes green via auto submit App label Feb 22, 2023
@goderbauer goderbauer mentioned this pull request Feb 22, 2023
Merged
@auto-submit auto-submit bot removed the autosubmit Merge PR when tree becomes green via auto submit App label Feb 23, 2023
@auto-submit
Copy link
Contributor

auto-submit bot commented Feb 23, 2023

auto label is removed for flutter/flutter, pr: 121171, due to - The status or check suite Linux web_tool_tests has failed. Please fix the issues identified (or deflake) before re-applying this label.

@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Feb 24, 2023
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Feb 24, 2023
@engine-flutter-autoroll
26b6c1b Fix typos (flutter/flutter#121171)
fd7c8d8
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Feb 24, 2023
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Feb 24, 2023
@engine-flutter-autoroll
26b6c1b Fix typos (flutter/flutter#121171)
7d7a059
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Feb 25, 2023
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Feb 25, 2023
@engine-flutter-autoroll
26b6c1b Fix typos (flutter/flutter#121171)
28e0683
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Feb 25, 2023
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Feb 25, 2023
@engine-flutter-autoroll
26b6c1b Fix typos (flutter/flutter#121171)
745fb3b
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Feb 26, 2023
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Feb 26, 2023
@engine-flutter-autoroll
26b6c1b Fix typos (flutter/flutter#121171)
ee01a1b
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Feb 26, 2023
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Feb 26, 2023
@engine-flutter-autoroll
26b6c1b Fix typos (flutter/flutter#121171)
4df58cd
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Feb 26, 2023
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Feb 26, 2023
@engine-flutter-autoroll
26b6c1b Fix typos (flutter/flutter#121171)
bcf42b9
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Feb 27, 2023
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Feb 27, 2023
@engine-flutter-autoroll
26b6c1b Fix typos (flutter/flutter#121171)
f9e32f3
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Feb 27, 2023
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Feb 27, 2023
@engine-flutter-autoroll
26b6c1b Fix typos (flutter/flutter#121171)
1831d50
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Feb 27, 2023
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Feb 27, 2023
@engine-flutter-autoroll
26b6c1b Fix typos (flutter/flutter#121171)
1af49f6
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Feb 27, 2023
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Feb 27, 2023
@engine-flutter-autoroll
26b6c1b Fix typos (flutter/flutter#121171)
c438712
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Feb 27, 2023
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Feb 27, 2023
@engine-flutter-autoroll
26b6c1b Fix typos (flutter/flutter#121171)
bdb5506
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Feb 27, 2023
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Feb 27, 2023
@engine-flutter-autoroll
26b6c1b Fix typos (flutter/flutter#121171)
8dd207a
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Feb 27, 2023
@engine-flutter-autoroll
26b6c1b Fix typos (flutter/flutter#121171)
9235da8
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request May 10, 2023
@engine-flutter-autoroll
26b6c1b Fix typos (flutter/flutter#121171)
b6ad140
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request May 10, 2023
@engine-flutter-autoroll
26b6c1b Fix typos (flutter/flutter#121171)
0d0b3ee
kekland
kekland reviewed May 15, 2023
View reviewed changes
packages/flutter/lib/src/widgets/implicit_animations.dart
// TODO(alangardner): Implement slerp for constant rotation
// TODO(alangardner): Implement lerp for constant rotation
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Lioness100 @goderbauer Not sure, but this could be a mistake, since slerp is a common shorthand for "spherical linear interpolation", which is used when linearly interpolating quaternions. See https://en.wikipedia.org/wiki/Slerp

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@goderbauer goderbauer goderbauer approved these changes

@gspencergoog gspencergoog gspencergoog approved these changes

+1 more reviewer

@kekland kekland kekland left review comments

Reviewers whose approvals may not affect merge requirements
Assignees
No one assigned
Labels
a: accessibility Accessibility, e.g. VoiceOver or TalkBack. (aka a11y) a: animation Animation APIs a: tests "flutter test", flutter_test, or one of our tests a: text input Entering text in a text field or keyboard related problems autosubmit Merge PR when tree becomes green via auto submit App c: contributor-productivity Team-specific productivity, code health, technical debt. d: api docs Issues with https://api.flutter.dev/ d: examples Sample code and demos f: cupertino flutter/packages/flutter/cupertino repository f: focus Focus traversal, gaining or losing focus f: gestures flutter/packages/flutter/gestures repository. f: integration_test The flutter/packages/integration_test plugin f: material design flutter/packages/flutter/material repository. f: scrolling Viewports, list views, slivers, etc. framework flutter/packages/flutter repository. See also f: labels. platform-ios iOS applications specifically tool Affects the "flutter" command-line tool. See also t: labels.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@Lioness100 @goderbauer @gspencergoog @kekland