[CP] Fix message type inconsistency between locales (#120129) #120678
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
I approve the overall cherrypicking of the upstream fix to this branch. I'll leave it @thkim1011 to give final approval that the conflict resolution is correct.
|
I think this cherry pick contains changes from #116625. I think the safest approach here is to cherry pick that PR first (commit hash 583a812), so that we include the test in |
This was referenced Feb 16, 2023
(cherry picked from commit becb6bd)
|
Rebased on the latest change. cc @thkim1011 |
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/plugins
that referenced
this pull request
Feb 22, 2023
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Feb 25, 2023
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Feb 26, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
(cherry picked from commit becb6bd)
packages/flutter_tools/lib/src/localizations/message_parser.dartcould be different from the master branch. @thkim1011 could you check to ensure it's working?Pre-launch Checklist
///).If you need help, consider asking for advice on the #hackers-new channel on Discord.