Expose callback that allows focus traversal customization #120235

JellyO1 · 2023-02-07T22:24:06Z

This PR exposes a requestFocusCallback on FocusTraversalPolicy and it's inheritors.

Pre-launch Checklist

I read the Contributor Guide and followed the process outlined there for submitting PRs.
I read the Tree Hygiene wiki page, which explains my responsibilities.
I read and followed the Flutter Style Guide, including Features we expect every widget to implement.
I signed the CLA.
I listed at least one issue that this PR fixes in the description above.
I updated/added relevant documentation (doc comments with ///).
I added new tests to check the change I am making, or this PR is test-exempt.
All existing and new tests are passing.

If you need help, consider asking for advice on the #hackers-new channel on Discord.

flutter-dashboard · 2023-02-07T22:24:10Z

It looks like this pull request may not have tests. Please make sure to add tests before merging. If you need an exemption to this rule, contact Hixie on the #hackers channel in Chat (don't just cc him here, he won't see it! He's on Discord!).

If you are not sure if you need tests, consider this rule of thumb: the purpose of a test is to make sure someone doesn't accidentally revert the fix. Ask yourself, is there anything in your PR that you feel it is important we not accidentally revert back to how it was before your fix?

Reviewers: Read the Tree Hygiene page and make sure this patch meets those guidelines before LGTMing.

gspencergoog

This is a nice idea, thanks for the PR! When I wrote It, I thought about doing something similar, but decided to wait until there was a clear use case to make it public. Do you have a specific use case in mind?

This PR will need to have tests before we can merge it.

gspencergoog · 2023-03-01T00:47:40Z

packages/flutter/lib/src/widgets/focus_traversal.dart

 }

+/// Signature for the callback that's called when a traversal policy is
+/// requesting focus.
+typedef RequestFocusCallback = void Function(


This should probably have a name that reflects that it is part of focus traversal, and not some version of the requestFocus on a focus node. Maybe TraversalRequestFocusCallback?

packages/flutter/lib/src/widgets/focus_traversal.dart

gspencergoog · 2023-03-01T00:49:06Z

packages/flutter/lib/src/widgets/focus_traversal.dart

+  }) : requestFocusCallback = requestFocusCallback ?? _focusAndEnsureVisible;
+
+  /// The callback used to move the focus from one focus node to another when
+  /// traversing them using a keyboard.


This needs to talk about what the default behavior is, and when it is invoked.

This still needs to be addressed in this doc comment. When the docs are built, this doc comment will be on its own page, and the user won't see the defaultTraversalRequestFocusCallback comment.

You might add a paragraph that talks about what the default value is, and what the default implementation does.

gspencergoog · 2023-03-01T00:51:08Z

packages/flutter/lib/src/widgets/focus_traversal.dart

@@ -38,11 +38,24 @@ BuildContext? _getAncestor(BuildContext context, {int count = 1}) {
 void _focusAndEnsureVisible(


If we're going to make a public value where this is the default, perhaps it makes sense to make this a static public function on FocusTraversalPolicy, called defaultTraversalRequestFocusCallback? Then people could implement their callback to call the default if all they want to do is log analytics or something.

Perhaps, but I'm partial to keeping this function as it is and duplicating it as a static one on FocusTraversalPolicy since the method is also used in RequestFocusAction.

Let's not duplicate code. Just call this from defaultTraversalRequestFocusCallback, since it's static, or eliminate this and call the static instead of this (the second one is probably preferable).

packages/flutter/lib/src/widgets/focus_traversal.dart

JellyO1 · 2023-03-01T10:40:00Z

Thanks for the feedback, I'll make the changes this weekend. My current use case is that I'm developing an Android TV application with stripe navigation and in the design requirements the selected element should always stay at the start so that it's clear what comes ahead.
I'll also write the tests which will probably require further feedback as I'm not sure what exactly how and what I should test.

flutter-dashboard · 2023-04-04T21:40:05Z

This pull request executed golden file tests, but it has not been updated in a while (20+ days). Test results from Gold expire after as many days, so this pull request will need to be updated with a fresh commit in order to get results from Gold.

For more guidance, visit Writing a golden file test for package:flutter.

Reviewers: Read the Tree Hygiene page and make sure this patch meets those guidelines before LGTMing.

gspencergoog · 2023-03-15T20:55:03Z

packages/flutter/lib/src/widgets/focus_traversal.dart

-  const FocusTraversalPolicy();
+  ///
+  /// {@template flutter.widgets.FocusTraversalPolicy.requestFocusCallback}
+  /// The `requestFocusCallback` can be used to overwrite the default behaviour


Suggested change

/// The `requestFocusCallback` can be used to overwrite the default behaviour

/// The `requestFocusCallback` can be used to override the default behaviour

gspencergoog · 2023-03-15T20:55:35Z

packages/flutter/lib/src/widgets/focus_traversal.dart

+  /// {@template flutter.widgets.FocusTraversalPolicy.requestFocusCallback}
+  /// The `requestFocusCallback` can be used to overwrite the default behaviour
+  /// of the focus requests. If `requestFocusCallback`
+  /// is null, defaults to [defaultTraversalRequestFocusCallback].


Suggested change

/// is null, defaults to [defaultTraversalRequestFocusCallback].

/// is null, it defaults to [defaultTraversalRequestFocusCallback].

gspencergoog · 2023-03-15T20:56:01Z

packages/flutter/lib/src/widgets/focus_traversal.dart

+  }) : requestFocusCallback = requestFocusCallback ?? _focusAndEnsureVisible;
+
+  /// The callback used to move the focus from one focus node to another when
+  /// traversing them using a keyboard.


This still needs to be addressed in this doc comment. When the docs are built, this doc comment will be on its own page, and the user won't see the defaultTraversalRequestFocusCallback comment.

You might add a paragraph that talks about what the default value is, and what the default implementation does.

gspencergoog · 2023-03-15T21:39:40Z

packages/flutter/lib/src/widgets/focus_traversal.dart

@@ -38,11 +38,24 @@ BuildContext? _getAncestor(BuildContext context, {int count = 1}) {
 void _focusAndEnsureVisible(


Let's not duplicate code. Just call this from defaultTraversalRequestFocusCallback, since it's static, or eliminate this and call the static instead of this (the second one is probably preferable).

goderbauer · 2023-04-25T09:28:20Z

(triage) @JellyO1 Do you still have plans to follow up on the feedback given above?

JellyO1 · 2023-04-25T10:18:36Z

Completely forgot about it, yes I'll finish it this week.

gspencergoog

gspencergoog · 2023-05-02T15:19:23Z

packages/flutter/lib/src/widgets/focus_traversal.dart

@@ -1712,7 +1754,7 @@ class RequestFocusIntent extends Intent {
 class RequestFocusAction extends Action<RequestFocusIntent> {
  @override
  void invoke(RequestFocusIntent intent) {


The RequestFocusIntent could take an optional TraversalRequestFocusCallback in its constructor, which you could call here. That would let the RequestFocusAction be customizable in the same way.

Of course, It would also need a test. Feel free to leave that for another PR if you don't have time.

That's a good catch, I'll do it on this PR since it makes the most sense.

gspencergoog

(again)

packages/flutter/lib/src/widgets/focus_traversal.dart

Piinks

Welcome @JellyO1, thanks for contributing!

auto-submit · 2023-05-08T17:30:14Z

auto label is removed for flutter/flutter, pr: 120235, due to - The status or check suite Linux docs_test has failed. Please fix the issues identified (or deflake) before re-applying this label.

packages/flutter/lib/src/widgets/focus_traversal.dart

goderbauer · 2023-05-16T22:23:20Z

(Triage) Looks like some tests are failing. @JellyO1 can you take a look?

JellyO1 · 2023-05-17T08:51:32Z

Yes, I'll take care of it.

This commit creates an optional TraversalRequestFocusCallback parameter on `RequestFocusIntent` while keeping the original behaviour intact. This allows you to change the behaviour of the focus request in the same way you can change it on the `FocusTraversalPolicy`.

Co-authored-by: Loïc Sharma <737941+loic-sharma@users.noreply.github.com>

Co-authored-by: Greg Spencer <gspencergoog@users.noreply.github.com>

…utter/flutter#120235)

Roll Flutter from d0d1feb to 5ae6438 (42 revisions) flutter/flutter@d0d1feb...5ae6438 2023-05-18 goderbauer@google.com Revert "Handle null return from WillPopCallback" (flutter/flutter#127112) 2023-05-18 engine-flutter-autoroll@skia.org Roll Flutter Engine from a22dd6438335 to 843ce0bba356 (6 revisions) (flutter/flutter#127116) 2023-05-18 christopherfujino@gmail.com mark windows build tests non-bringup (flutter/flutter#127059) 2023-05-18 engine-flutter-autoroll@skia.org Roll Flutter Engine from d97037077963 to a22dd6438335 (1 revision) (flutter/flutter#127071) 2023-05-18 engine-flutter-autoroll@skia.org Roll Packages from 5c69914 to b31a128 (9 revisions) (flutter/flutter#127109) 2023-05-18 jmccandless@google.com Revert "Remove obsolete drawShadow bounds workaround" (flutter/flutter#127110) 2023-05-18 36861262+QuncCccccc@users.noreply.github.com Clip search view content during animation (flutter/flutter#126975) 2023-05-18 flar@google.com Remove obsolete drawShadow bounds workaround (flutter/flutter#127052) 2023-05-17 737941+loic-sharma@users.noreply.github.com [Windows] Improve version migration message (flutter/flutter#127048) 2023-05-17 49699333+dependabot[bot]@users.noreply.github.com Bump actions/labeler from 9471598e3b7ff22b2fa181bd79addf94cb3e0847 to 6b107e7a7ee5e054e0bcce60de5181d21e2f00fb (flutter/flutter#127056) 2023-05-17 rmolivares@renzo-olivares.dev Remove deprecated fixTextFieldOutlineLabel (flutter/flutter#125893) 2023-05-17 engine-flutter-autoroll@skia.org Roll Flutter Engine from 331c5769e291 to d97037077963 (3 revisions) (flutter/flutter#127053) 2023-05-17 christopherfujino@gmail.com shard windows build tests 3 -> 4 (flutter/flutter#127057) 2023-05-17 engine-flutter-autoroll@skia.org Roll Flutter Engine from 0ae3719d7043 to 331c5769e291 (1 revision) (flutter/flutter#127049) 2023-05-17 srawlins@google.com Ignore unused_element_parameter (flutter/flutter#126926) 2023-05-17 engine-flutter-autoroll@skia.org Roll Flutter Engine from 47fd496c6f8d to 0ae3719d7043 (2 revisions) (flutter/flutter#127043) 2023-05-17 engine-flutter-autoroll@skia.org Roll Flutter Engine from 400a26ad8343 to 47fd496c6f8d (3 revisions) (flutter/flutter#127041) 2023-05-17 christopherfujino@gmail.com [flutter_tools] unpin and roll camera_android (flutter/flutter#126945) 2023-05-17 goderbauer@google.com Handle null return from WillPopCallback (flutter/flutter#127039) 2023-05-17 engine-flutter-autoroll@skia.org Roll Flutter Engine from 6048360c1837 to 400a26ad8343 (1 revision) (flutter/flutter#127036) 2023-05-17 goderbauer@google.com Remove unused (and untested) parameters from private _MasterDetailFlow (flutter/flutter#126935) 2023-05-17 jmccandless@google.com Autocomplete async examples (flutter/flutter#126283) 2023-05-17 danivangelis@hotmail.com Expose callback that allows focus traversal customization (flutter/flutter#120235) 2023-05-17 engine-flutter-autoroll@skia.org Roll Packages from b971830 to 5c69914 (5 revisions) (flutter/flutter#127034) 2023-05-17 engine-flutter-autoroll@skia.org Roll Flutter Engine from ea3f27383acc to 6048360c1837 (2 revisions) (flutter/flutter#127032) 2023-05-17 tessertaha@gmail.com Add missing `Switch.onFocusChange` test (flutter/flutter#126685) 2023-05-17 joshualitt@google.com Remove 'url_launcher' from pubspec.yaml. (flutter/flutter#126939) 2023-05-17 engine-flutter-autoroll@skia.org Roll Flutter Engine from 4b7c37532ea4 to ea3f27383acc (1 revision) (flutter/flutter#126994) 2023-05-17 engine-flutter-autoroll@skia.org Roll Flutter Engine from 170b45bae571 to 4b7c37532ea4 (1 revision) (flutter/flutter#126985) 2023-05-17 engine-flutter-autoroll@skia.org Roll Flutter Engine from 28b9dc993c30 to 170b45bae571 (1 revision) (flutter/flutter#126981) 2023-05-17 engine-flutter-autoroll@skia.org Roll Flutter Engine from 87a03e107df7 to 28b9dc993c30 (1 revision) (flutter/flutter#126974) 2023-05-17 engine-flutter-autoroll@skia.org Roll Flutter Engine from 1c775e34e2d5 to 87a03e107df7 (3 revisions) (flutter/flutter#126968) 2023-05-16 sigurdm@google.com Fix style issues (flutter/flutter#122586) 2023-05-16 engine-flutter-autoroll@skia.org Manual roll Flutter Engine from fe2476743b59 to 1c775e34e2d5 (10 revisions) (flutter/flutter#126961) 2023-05-16 ian@hixie.ch Make SlottedMultiChildRenderObjectWidgetMixin a concrete class (flutter/flutter#126108) 2023-05-16 ian@hixie.ch Add ScrollMetrics.extentTotal for completeness (flutter/flutter#126607) 2023-05-16 godofredoc@google.com Fix drone_dimensions. (flutter/flutter#126953) 2023-05-16 58190796+MitchellGoodwin@users.noreply.github.com Add checkmark style to CupertinoRadio (flutter/flutter#126480) 2023-05-16 54558023+keyonghan@users.noreply.github.com Move `Mac_build_test flutter_gallery__transition_perf_e2e_ios` to prod (flutter/flutter#126941) 2023-05-16 jason-simmons@users.noreply.github.com Fix DataTableThemeData.copyWith handling of dataRowHeight (flutter/flutter#126943) 2023-05-16 smushaheed@outlook.com Fix copyWith method of ActionIconThemeData (flutter/flutter#126763) 2023-05-16 zanderso@users.noreply.github.com Revert "Roll Flutter Engine from fe2476743b59 to 5cf141f7c03c (2 revisions)" (flutter/flutter#126954) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-packages ...

…0235) This PR exposes a requestFocusCallback on `FocusTraversalPolicy` and it's inheritors. Fixes flutter#83175.

Roll Flutter from d0d1feb to 5ae6438 (42 revisions) flutter/flutter@d0d1feb...5ae6438 2023-05-18 goderbauer@google.com Revert "Handle null return from WillPopCallback" (flutter/flutter#127112) 2023-05-18 engine-flutter-autoroll@skia.org Roll Flutter Engine from a22dd6438335 to 843ce0bba356 (6 revisions) (flutter/flutter#127116) 2023-05-18 christopherfujino@gmail.com mark windows build tests non-bringup (flutter/flutter#127059) 2023-05-18 engine-flutter-autoroll@skia.org Roll Flutter Engine from d97037077963 to a22dd6438335 (1 revision) (flutter/flutter#127071) 2023-05-18 engine-flutter-autoroll@skia.org Roll Packages from 5c69914 to b31a128 (9 revisions) (flutter/flutter#127109) 2023-05-18 jmccandless@google.com Revert "Remove obsolete drawShadow bounds workaround" (flutter/flutter#127110) 2023-05-18 36861262+QuncCccccc@users.noreply.github.com Clip search view content during animation (flutter/flutter#126975) 2023-05-18 flar@google.com Remove obsolete drawShadow bounds workaround (flutter/flutter#127052) 2023-05-17 737941+loic-sharma@users.noreply.github.com [Windows] Improve version migration message (flutter/flutter#127048) 2023-05-17 49699333+dependabot[bot]@users.noreply.github.com Bump actions/labeler from 9471598e3b7ff22b2fa181bd79addf94cb3e0847 to 6b107e7a7ee5e054e0bcce60de5181d21e2f00fb (flutter/flutter#127056) 2023-05-17 rmolivares@renzo-olivares.dev Remove deprecated fixTextFieldOutlineLabel (flutter/flutter#125893) 2023-05-17 engine-flutter-autoroll@skia.org Roll Flutter Engine from 331c5769e291 to d97037077963 (3 revisions) (flutter/flutter#127053) 2023-05-17 christopherfujino@gmail.com shard windows build tests 3 -> 4 (flutter/flutter#127057) 2023-05-17 engine-flutter-autoroll@skia.org Roll Flutter Engine from 0ae3719d7043 to 331c5769e291 (1 revision) (flutter/flutter#127049) 2023-05-17 srawlins@google.com Ignore unused_element_parameter (flutter/flutter#126926) 2023-05-17 engine-flutter-autoroll@skia.org Roll Flutter Engine from 47fd496c6f8d to 0ae3719d7043 (2 revisions) (flutter/flutter#127043) 2023-05-17 engine-flutter-autoroll@skia.org Roll Flutter Engine from 400a26ad8343 to 47fd496c6f8d (3 revisions) (flutter/flutter#127041) 2023-05-17 christopherfujino@gmail.com [flutter_tools] unpin and roll camera_android (flutter/flutter#126945) 2023-05-17 goderbauer@google.com Handle null return from WillPopCallback (flutter/flutter#127039) 2023-05-17 engine-flutter-autoroll@skia.org Roll Flutter Engine from 6048360c1837 to 400a26ad8343 (1 revision) (flutter/flutter#127036) 2023-05-17 goderbauer@google.com Remove unused (and untested) parameters from private _MasterDetailFlow (flutter/flutter#126935) 2023-05-17 jmccandless@google.com Autocomplete async examples (flutter/flutter#126283) 2023-05-17 danivangelis@hotmail.com Expose callback that allows focus traversal customization (flutter/flutter#120235) 2023-05-17 engine-flutter-autoroll@skia.org Roll Packages from b971830 to 5c69914 (5 revisions) (flutter/flutter#127034) 2023-05-17 engine-flutter-autoroll@skia.org Roll Flutter Engine from ea3f27383acc to 6048360c1837 (2 revisions) (flutter/flutter#127032) 2023-05-17 tessertaha@gmail.com Add missing `Switch.onFocusChange` test (flutter/flutter#126685) 2023-05-17 joshualitt@google.com Remove 'url_launcher' from pubspec.yaml. (flutter/flutter#126939) 2023-05-17 engine-flutter-autoroll@skia.org Roll Flutter Engine from 4b7c37532ea4 to ea3f27383acc (1 revision) (flutter/flutter#126994) 2023-05-17 engine-flutter-autoroll@skia.org Roll Flutter Engine from 170b45bae571 to 4b7c37532ea4 (1 revision) (flutter/flutter#126985) 2023-05-17 engine-flutter-autoroll@skia.org Roll Flutter Engine from 28b9dc993c30 to 170b45bae571 (1 revision) (flutter/flutter#126981) 2023-05-17 engine-flutter-autoroll@skia.org Roll Flutter Engine from 87a03e107df7 to 28b9dc993c30 (1 revision) (flutter/flutter#126974) 2023-05-17 engine-flutter-autoroll@skia.org Roll Flutter Engine from 1c775e34e2d5 to 87a03e107df7 (3 revisions) (flutter/flutter#126968) 2023-05-16 sigurdm@google.com Fix style issues (flutter/flutter#122586) 2023-05-16 engine-flutter-autoroll@skia.org Manual roll Flutter Engine from fe2476743b59 to 1c775e34e2d5 (10 revisions) (flutter/flutter#126961) 2023-05-16 ian@hixie.ch Make SlottedMultiChildRenderObjectWidgetMixin a concrete class (flutter/flutter#126108) 2023-05-16 ian@hixie.ch Add ScrollMetrics.extentTotal for completeness (flutter/flutter#126607) 2023-05-16 godofredoc@google.com Fix drone_dimensions. (flutter/flutter#126953) 2023-05-16 58190796+MitchellGoodwin@users.noreply.github.com Add checkmark style to CupertinoRadio (flutter/flutter#126480) 2023-05-16 54558023+keyonghan@users.noreply.github.com Move `Mac_build_test flutter_gallery__transition_perf_e2e_ios` to prod (flutter/flutter#126941) 2023-05-16 jason-simmons@users.noreply.github.com Fix DataTableThemeData.copyWith handling of dataRowHeight (flutter/flutter#126943) 2023-05-16 smushaheed@outlook.com Fix copyWith method of ActionIconThemeData (flutter/flutter#126763) 2023-05-16 zanderso@users.noreply.github.com Revert "Roll Flutter Engine from fe2476743b59 to 5cf141f7c03c (2 revisions)" (flutter/flutter#126954) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-packages ...

…utter/flutter#120235)

flutter-dashboard bot added f: focus Focus traversal, gaining or losing focus framework flutter/packages/flutter repository. See also f: labels. labels Feb 7, 2023

goderbauer requested a review from gspencergoog February 7, 2023 23:11

gspencergoog reviewed Mar 1, 2023

View reviewed changes

JellyO1 force-pushed the b83175 branch from b34c623 to ef3b5c3 Compare March 14, 2023 20:32

JellyO1 requested a review from gspencergoog March 14, 2023 20:33

gspencergoog reviewed Apr 4, 2023

View reviewed changes

goderbauer requested a review from gspencergoog May 2, 2023 10:16

gspencergoog approved these changes May 2, 2023

View reviewed changes

JellyO1 requested a review from gspencergoog May 6, 2023 17:36

gspencergoog approved these changes May 8, 2023

View reviewed changes

loic-sharma reviewed May 8, 2023

View reviewed changes

packages/flutter/lib/src/widgets/focus_traversal.dart Outdated Show resolved Hide resolved

loic-sharma reviewed May 8, 2023

View reviewed changes

packages/flutter/lib/src/widgets/focus_traversal.dart Outdated Show resolved Hide resolved

loic-sharma reviewed May 8, 2023

View reviewed changes

packages/flutter/lib/src/widgets/focus_traversal.dart Outdated Show resolved Hide resolved

loic-sharma reviewed May 8, 2023

View reviewed changes

packages/flutter/lib/src/widgets/focus_traversal.dart Outdated Show resolved Hide resolved

Piinks force-pushed the b83175 branch from 31af0c7 to 1c0ca4b Compare May 8, 2023 17:19

Piinks approved these changes May 8, 2023

View reviewed changes

Piinks added autosubmit Merge PR when tree becomes green via auto submit App c: new feature Nothing broken; request for a new capability labels May 8, 2023

auto-submit bot removed the autosubmit Merge PR when tree becomes green via auto submit App label May 8, 2023

gspencergoog reviewed May 8, 2023

View reviewed changes

packages/flutter/lib/src/widgets/focus_traversal.dart Outdated Show resolved Hide resolved

Expose callback that allows focus traversal customization

e9bba5a

JellyO1 and others added 8 commits May 17, 2023 10:45

Improve constructor and callback documentation

161c159

Update packages/flutter/lib/src/widgets/focus_traversal.dart

5329e67

Co-authored-by: Loïc Sharma <737941+loic-sharma@users.noreply.github.com>

Update packages/flutter/lib/src/widgets/focus_traversal.dart

a992765

Co-authored-by: Loïc Sharma <737941+loic-sharma@users.noreply.github.com>

Update packages/flutter/lib/src/widgets/focus_traversal.dart

f271bcf

Co-authored-by: Loïc Sharma <737941+loic-sharma@users.noreply.github.com>

Update packages/flutter/lib/src/widgets/focus_traversal.dart

93415a9

Co-authored-by: Loïc Sharma <737941+loic-sharma@users.noreply.github.com>

Update packages/flutter/lib/src/widgets/focus_traversal.dart

08df0db

Co-authored-by: Greg Spencer <gspencergoog@users.noreply.github.com>

Fix broken focus_traversal requestFocusCallback tests

41f6b58

JellyO1 force-pushed the b83175 branch from 4444b46 to 41f6b58 Compare May 17, 2023 09:45

Piinks added the autosubmit Merge PR when tree becomes green via auto submit App label May 17, 2023

auto-submit bot merged commit 561169e into flutter:master May 17, 2023

engine-flutter-autoroll mentioned this pull request May 18, 2023

Roll Flutter from d0d1feb6283f to f31dae2a8073 (36 revisions) flutter/packages#4034

Closed

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request May 18, 2023

561169e Expose callback that allows focus traversal customization (fl…

423c32b

…utter/flutter#120235)

engine-flutter-autoroll mentioned this pull request May 18, 2023

Roll Flutter from d0d1feb6283f to 6071f149b52f (37 revisions) flutter/packages#4036

Closed

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request May 18, 2023

561169e Expose callback that allows focus traversal customization (fl…

a548c37

…utter/flutter#120235)

engine-flutter-autoroll mentioned this pull request May 18, 2023

Roll Flutter from d0d1feb6283f to 344c9c6af298 (40 revisions) flutter/packages#4037

Closed

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request May 18, 2023

561169e Expose callback that allows focus traversal customization (fl…

dd702c8

…utter/flutter#120235)

engine-flutter-autoroll mentioned this pull request May 18, 2023

Roll Flutter from d0d1feb6283f to 5ae64381578c (42 revisions) flutter/packages#4038

Merged

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request May 18, 2023

561169e Expose callback that allows focus traversal customization (fl…

24e34cb

…utter/flutter#120235)

HansMuller mentioned this pull request May 19, 2023

Flutter Framework Team: Notable Commits #121415

Closed

This was referenced May 25, 2023

Support minifcation for apps that depend on AGP 8 and integration_test #127628

Merged

i127682 android api 33 test support #127689

Merged

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Aug 16, 2023

561169e Expose callback that allows focus traversal customization (fl…

904455b

…utter/flutter#120235)

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Aug 17, 2023

561169e Expose callback that allows focus traversal customization (fl…

ea88abc

…utter/flutter#120235)

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Aug 17, 2023

561169e Expose callback that allows focus traversal customization (fl…

d3e4a6a

…utter/flutter#120235)

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Aug 17, 2023

561169e Expose callback that allows focus traversal customization (fl…

bf4b37b

…utter/flutter#120235)

		@@ -38,11 +38,24 @@ BuildContext? _getAncestor(BuildContext context, {int count = 1}) {
		void _focusAndEnsureVisible(

	/// The `requestFocusCallback` can be used to overwrite the default behaviour
	/// The `requestFocusCallback` can be used to override the default behaviour

	/// is null, defaults to [defaultTraversalRequestFocusCallback].
	/// is null, it defaults to [defaultTraversalRequestFocusCallback].

Expose callback that allows focus traversal customization #120235

Expose callback that allows focus traversal customization #120235

Uh oh!

Conversation

JellyO1 commented Feb 7, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Pre-launch Checklist

Uh oh!

flutter-dashboard bot commented Feb 7, 2023

Uh oh!

gspencergoog left a comment

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

JellyO1 commented Mar 1, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

flutter-dashboard bot commented Apr 4, 2023

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

goderbauer commented Apr 25, 2023

Uh oh!

JellyO1 commented Apr 25, 2023

Uh oh!

gspencergoog left a comment

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

gspencergoog left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Piinks left a comment

Choose a reason for hiding this comment

Uh oh!

auto-submit bot commented May 8, 2023

Uh oh!

Uh oh!

goderbauer commented May 16, 2023

Uh oh!

JellyO1 commented May 17, 2023

Uh oh!

Uh oh!

JellyO1 commented Feb 7, 2023 •

edited

Loading

JellyO1 commented Mar 1, 2023 •

edited

Loading