Skip to content

Update M3 IconButton unselected focused opacity #117321

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 7 commits into from
Dec 28, 2022
Merged

Update M3 IconButton unselected focused opacity #117321

merged 7 commits into from
Dec 28, 2022

Conversation

esouthren
Copy link
Contributor

Fixed b/263130438

Pre-launch Checklist

  • I read the [Contributor Guide] and followed the process outlined there for submitting PRs.
  • I read the [Tree Hygiene] wiki page, which explains my responsibilities.
  • I read and followed the [Flutter Style Guide], including [Features we expect every widget to implement].
  • I signed the [CLA].
  • I listed at least one issue that this PR fixes in the description above.
  • I updated/added relevant documentation (doc comments with ///).
  • I added new tests to check the change I am making, or this PR is [test-exempt].
  • All existing and new tests are passing.

If you need help, consider asking for advice on the #hackers-new channel on [Discord].

@flutter-dashboard flutter-dashboard bot added f: material design flutter/packages/flutter/material repository. framework flutter/packages/flutter repository. See also f: labels. c: contributor-productivity Team-specific productivity, code health, technical debt. labels Dec 19, 2022
@esouthren esouthren marked this pull request as ready for review December 19, 2022 18:58
@esouthren esouthren merged commit 0e83ada into flutter:master Dec 28, 2022
This was referenced Dec 29, 2022
Merged
Merged
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Dec 29, 2022
@engine-flutter-autoroll
0e83ada Update M3 IconButton unselected focused opacity (flutter/flut…
94a5cbf 
…ter#117321)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/plugins that referenced this pull request Dec 29, 2022
@engine-flutter-autoroll
0e83ada Update M3 IconButton unselected focused opacity (flutter/flut…
78e21dc 
…ter#117321)
auto-submit bot pushed a commit to flutter/packages that referenced this pull request Dec 29, 2022
@engine-flutter-autoroll
Roll Flutter from 17482fd to d2127ad (14 revisions) (#3009)
2fb470f 
* 9bb4ffe Roll Flutter Engine from 9e63c1ae1480 to 190f743a8506 (2 revisions) (flutter/flutter#117744)

* babeb61 cc8055d5f Roll Skia from 4b578d72dc2e to e4c86c2fed9a (1 revision) (flutter/engine#38535) (flutter/flutter#117745)

* 9afaf6b f3cc581d9 Roll Dart SDK from 6e07d9b025bd to f7b36d5e50a5 (1 revision) (flutter/engine#38536) (flutter/flutter#117749)

* 0e83ada Update M3 IconButton unselected focused opacity (flutter/flutter#117321)

* 2783d31 Roll Flutter Engine from f3cc581d97e1 to 3655bf981d4c (2 revisions) (flutter/flutter#117751)

* 4a6ab96 Roll Flutter Engine from 3655bf981d4c to 34f75ed27c9b (3 revisions) (flutter/flutter#117760)

* 2ffa65c e9e79180e Roll Skia from 2923399853d9 to 0027eb334691 (6 revisions) (flutter/engine#38545) (flutter/flutter#117763)

* cee9ec5 606e77f35 Roll Skia from 0027eb334691 to 668260c85e9d (1 revision) (flutter/engine#38547) (flutter/flutter#117766)

* c089c19 Revert "[reland] Add Material 3 support for `ListTile` - Part 1 (#116963)" (flutter/flutter#117756)

* bdefebc 9b534a5f8 Roll Skia from 668260c85e9d to 25ffa2b757e9 (1 revision) (flutter/engine#38548) (flutter/flutter#117768)

* aa70994 8655ec022 [Impeller Scene] Add ColorSourceContents for drawing a node (flutter/engine#38485) (flutter/flutter#117769)

* cbc184d Roll Flutter Engine from 8655ec022fe1 to ecd47e0b256a (2 revisions) (flutter/flutter#117772)

* 0b69719 Roll Flutter Engine from ecd47e0b256a to 45e689b15d1a (2 revisions) (flutter/flutter#117778)

* d2127ad e44a0de4c Roll Fuchsia Mac SDK from JLTTlcNPJeScjSO2B... to FeFYsNPy64-PEXPer... (flutter/engine#38558) (flutter/flutter#117779)
auto-submit bot pushed a commit to flutter/plugins that referenced this pull request Dec 29, 2022
@engine-flutter-autoroll
Roll Flutter from 17482fd to d2127ad (14 revisions) (#6892)
b202b3d 
* 9bb4ffe Roll Flutter Engine from 9e63c1ae1480 to 190f743a8506 (2 revisions) (flutter/flutter#117744)

* babeb61 cc8055d5f Roll Skia from 4b578d72dc2e to e4c86c2fed9a (1 revision) (flutter/engine#38535) (flutter/flutter#117745)

* 9afaf6b f3cc581d9 Roll Dart SDK from 6e07d9b025bd to f7b36d5e50a5 (1 revision) (flutter/engine#38536) (flutter/flutter#117749)

* 0e83ada Update M3 IconButton unselected focused opacity (flutter/flutter#117321)

* 2783d31 Roll Flutter Engine from f3cc581d97e1 to 3655bf981d4c (2 revisions) (flutter/flutter#117751)

* 4a6ab96 Roll Flutter Engine from 3655bf981d4c to 34f75ed27c9b (3 revisions) (flutter/flutter#117760)

* 2ffa65c e9e79180e Roll Skia from 2923399853d9 to 0027eb334691 (6 revisions) (flutter/engine#38545) (flutter/flutter#117763)

* cee9ec5 606e77f35 Roll Skia from 0027eb334691 to 668260c85e9d (1 revision) (flutter/engine#38547) (flutter/flutter#117766)

* c089c19 Revert "[reland] Add Material 3 support for `ListTile` - Part 1 (#116963)" (flutter/flutter#117756)

* bdefebc 9b534a5f8 Roll Skia from 668260c85e9d to 25ffa2b757e9 (1 revision) (flutter/engine#38548) (flutter/flutter#117768)

* aa70994 8655ec022 [Impeller Scene] Add ColorSourceContents for drawing a node (flutter/engine#38485) (flutter/flutter#117769)

* cbc184d Roll Flutter Engine from 8655ec022fe1 to ecd47e0b256a (2 revisions) (flutter/flutter#117772)

* 0b69719 Roll Flutter Engine from ecd47e0b256a to 45e689b15d1a (2 revisions) (flutter/flutter#117778)

* d2127ad e44a0de4c Roll Fuchsia Mac SDK from JLTTlcNPJeScjSO2B... to FeFYsNPy64-PEXPer... (flutter/engine#38558) (flutter/flutter#117779)
@esouthren esouthren deleted the iconbuttonopacity branch December 30, 2022 15:21
loic-sharma pushed a commit to fluttergithubbot/flutter that referenced this pull request Jan 6, 2023
@esouthren @loic-sharma
Update M3 IconButton unselected focused opacity (flutter#117321)
0050557 
* Bottom App Bar M3 background color fix

* update test

* test update

* remove whitespace

* Update IconButton unselected focused opacity

* Delete generated_plugins.cmake
gspencergoog pushed a commit to gspencergoog/flutter that referenced this pull request Jan 19, 2023
@esouthren @gspencergoog
Update M3 IconButton unselected focused opacity (flutter#117321)
c47c51e 
* Bottom App Bar M3 background color fix

* update test

* test update

* remove whitespace

* Update IconButton unselected focused opacity

* Delete generated_plugins.cmake
mauricioluz pushed a commit to mauricioluz/plugins that referenced this pull request Jan 26, 2023
@engine-flutter-autoroll @mauricioluz
Roll Flutter from 17482fd to d2127ad (14 revisions) (flutter#6892)
66b7749 
* 9bb4ffe Roll Flutter Engine from 9e63c1ae1480 to 190f743a8506 (2 revisions) (flutter/flutter#117744)

* babeb61 cc8055d5f Roll Skia from 4b578d72dc2e to e4c86c2fed9a (1 revision) (flutter/engine#38535) (flutter/flutter#117745)

* 9afaf6b f3cc581d9 Roll Dart SDK from 6e07d9b025bd to f7b36d5e50a5 (1 revision) (flutter/engine#38536) (flutter/flutter#117749)

* 0e83ada Update M3 IconButton unselected focused opacity (flutter/flutter#117321)

* 2783d31 Roll Flutter Engine from f3cc581d97e1 to 3655bf981d4c (2 revisions) (flutter/flutter#117751)

* 4a6ab96 Roll Flutter Engine from 3655bf981d4c to 34f75ed27c9b (3 revisions) (flutter/flutter#117760)

* 2ffa65c e9e79180e Roll Skia from 2923399853d9 to 0027eb334691 (6 revisions) (flutter/engine#38545) (flutter/flutter#117763)

* cee9ec5 606e77f35 Roll Skia from 0027eb334691 to 668260c85e9d (1 revision) (flutter/engine#38547) (flutter/flutter#117766)

* c089c19 Revert "[reland] Add Material 3 support for `ListTile` - Part 1 (#116963)" (flutter/flutter#117756)

* bdefebc 9b534a5f8 Roll Skia from 668260c85e9d to 25ffa2b757e9 (1 revision) (flutter/engine#38548) (flutter/flutter#117768)

* aa70994 8655ec022 [Impeller Scene] Add ColorSourceContents for drawing a node (flutter/engine#38485) (flutter/flutter#117769)

* cbc184d Roll Flutter Engine from 8655ec022fe1 to ecd47e0b256a (2 revisions) (flutter/flutter#117772)

* 0b69719 Roll Flutter Engine from ecd47e0b256a to 45e689b15d1a (2 revisions) (flutter/flutter#117778)

* d2127ad e44a0de4c Roll Fuchsia Mac SDK from JLTTlcNPJeScjSO2B... to FeFYsNPy64-PEXPer... (flutter/engine#38558) (flutter/flutter#117779)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@reidbaker reidbaker reidbaker approved these changes

@darrenaustin darrenaustin Awaiting requested review from darrenaustin

Assignees
No one assigned
Labels
c: contributor-productivity Team-specific productivity, code health, technical debt. f: material design flutter/packages/flutter/material repository. framework flutter/packages/flutter repository. See also f: labels.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@esouthren @reidbaker