Skip to content

[CP] Fix Snackbar TalkBack regression #116608

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Dec 9, 2022
Merged

[CP] Fix Snackbar TalkBack regression #116608

merged 2 commits into from
Dec 9, 2022

Conversation

zanderso
Copy link
Member

@zanderso zanderso commented Dec 6, 2022

CP of #116417.

@esouthren @zanderso
[CP] Fix Snackbar TalkBack regression (flutter#116417)
3130a79 
* Add M2 defaults and template skeleton

* add MaterialStateColor functionality to ActionTextColor (issue flutter#110402)

* Add M2 defaults and template skeleton

* updated material 3 tokens

* Updated snackbar demo

* add theme tests

* add gen defaults

* formatting

* more whitespace fixes

* add widget type

* update docs

* code review changes

* Add line overflow functionality

* whitespace fixes

* update M3 animation

* whitespace fixes

* add insetPadding param

* Modifed icon parameter to showCloseIcon

* white space fixes

* test fixes

* rename iconColor to closeIconColor

* debug test fix

* de-britishification

* g3fix

* g3fix

* debug test fix

* Fix Snackbar talkback regression

* fix merge weirdness

* test fix

* fix linux analysis error

* fix linux analysis error

* fix linux analysis error

* fix linux analysis error

* fix linux analysis error

* fix linux analysis error
@flutter-dashboard flutter-dashboard bot added f: material design flutter/packages/flutter/material repository. framework flutter/packages/flutter repository. See also f: labels. labels Dec 6, 2022
@zanderso zanderso mentioned this pull request Dec 6, 2022
Closed
guidezpl
guidezpl approved these changes Dec 6, 2022
View reviewed changes
Copy link
Member

@guidezpl guidezpl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more. 

  _    ___ _____ __  __ 
 | |  / __|_   _|  \/  |
 | |_| (_ | | | | |\/| |
 |____\___| |_| |_|  |_|

@zanderso zanderso mentioned this pull request Dec 6, 2022
Closed
@zanderso
Copy link
Member Author

zanderso commented Dec 6, 2022

Filed #116611 for the code signing failures.

@XilaiZhang XilaiZhang merged commit 84ea6a7 into flutter:flutter-3.7-candidate.1 Dec 9, 2022
@zanderso zanderso deleted the snack-bar-talk-back-cp branch December 12, 2022 18:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@guidezpl guidezpl guidezpl approved these changes

@jason-simmons jason-simmons Awaiting requested review from jason-simmons

Assignees
No one assigned
Labels
f: material design flutter/packages/flutter/material repository. framework flutter/packages/flutter repository. See also f: labels.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@zanderso @guidezpl @XilaiZhang @esouthren