Skip to content

Fix macOS migration nothing-to-upgrade test #114703

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Nov 6, 2022
Merged

Fix macOS migration nothing-to-upgrade test #114703

merged 1 commit into from
Nov 6, 2022

Conversation

cbracken
Copy link
Member

@cbracken cbracken commented Nov 4, 2022

When testing whether a macOS deployment target version migration is unnecessary due to already being at the target version, we were previously checking the iOS deployment target version rather than the macOS version. This updates it to test MACOSX_DEPLOYMENT_TARGET instead.

Issue: #107492
Issue: #107688

Pre-launch Checklist

  • I read the Contributor Guide and followed the process outlined there for submitting PRs.
  • I read the Tree Hygiene wiki page, which explains my responsibilities.
  • I read and followed the Flutter Style Guide, including Features we expect every widget to implement.
  • I signed the CLA.
  • I listed at least one issue that this PR fixes in the description above.
  • I updated/added relevant documentation (doc comments with ///).
  • I added new tests to check the change I am making, or this PR is test-exempt.
  • All existing and new tests are passing.

If you need help, consider asking for advice on the #hackers-new channel on Discord.

@cbracken
Fix macOS migration nothing-to-upgrade test
d33a11c 
When testing whether a macOS deployment target version migration is
unnecessary due to already being at the target version, we were
previously checking the iOS deployment target version rather than the
macOS version. This updates it to test MACOSX_DEPLOYMENT_TARGET instead.
@cbracken cbracken requested a review from jmagman November 4, 2022 18:31
@flutter-dashboard flutter-dashboard bot added the tool Affects the "flutter" command-line tool. See also t: labels. label Nov 4, 2022
jmagman
jmagman approved these changes Nov 4, 2022
View reviewed changes
Copy link
Member

@jmagman jmagman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

My bad... Thanks for fixing!

@cbracken cbracken mentioned this pull request Nov 4, 2022
Merged
8 tasks
@cbracken cbracken merged commit 5bc50c1 into flutter:master Nov 6, 2022
@cbracken cbracken deleted the fix-macos-migration-test branch November 6, 2022 00:02
This was referenced Nov 6, 2022
Merged
Merged
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Nov 6, 2022
@engine-flutter-autoroll
5bc50c1 Fix macOS migration nothing-to-upgrade test (flutter/flutter#…
21dccc6 
…114703)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/plugins that referenced this pull request Nov 6, 2022
@engine-flutter-autoroll
5bc50c1 Fix macOS migration nothing-to-upgrade test (flutter/flutter#…
e867389 
…114703)
auto-submit bot pushed a commit to flutter/plugins that referenced this pull request Nov 6, 2022
@engine-flutter-autoroll
Roll Flutter from e0e7027 to 5ea5a53 (7 revisions) (#6675)
3ca3410 
* cef4c2a ICU Message Syntax Parser (flutter/flutter#112390)

* 07d3a64 0886c7d0b Narrow the scope of the Windows Android arm hack (flutter/engine#37125) (flutter/flutter#114751)

* cf0cd06 Mark new_gallery__transition_perf as non-flaky (flutter/flutter#114694)

* 5bc50c1 Fix macOS migration nothing-to-upgrade test (flutter/flutter#114703)

* b1509ed 36cfa9e68 Apply the Windows friendly path solution in remaining spots (flutter/engine#37344) (flutter/flutter#114759)

* b45e628 b8218eacc Roll Fuchsia Mac SDK from Ua8Jtf8Zka9uxIVdl... to sNXsQVxntMX8f42LE... (flutter/engine#37352) (flutter/flutter#114760)

* 5ea5a53 6f3018a72 Roll Skia from a34882309d04 to c3c31be8729b (1 revision) (flutter/engine#37358) (flutter/flutter#114765)
auto-submit bot pushed a commit to flutter/packages that referenced this pull request Nov 7, 2022
@engine-flutter-autoroll
Roll Flutter from e0e7027 to 5ea5a53 (7 revisions) (#2783)
f3ac125 
* cef4c2a ICU Message Syntax Parser (flutter/flutter#112390)

* 07d3a64 0886c7d0b Narrow the scope of the Windows Android arm hack (flutter/engine#37125) (flutter/flutter#114751)

* cf0cd06 Mark new_gallery__transition_perf as non-flaky (flutter/flutter#114694)

* 5bc50c1 Fix macOS migration nothing-to-upgrade test (flutter/flutter#114703)

* b1509ed 36cfa9e68 Apply the Windows friendly path solution in remaining spots (flutter/engine#37344) (flutter/flutter#114759)

* b45e628 b8218eacc Roll Fuchsia Mac SDK from Ua8Jtf8Zka9uxIVdl... to sNXsQVxntMX8f42LE... (flutter/engine#37352) (flutter/flutter#114760)

* 5ea5a53 6f3018a72 Roll Skia from a34882309d04 to c3c31be8729b (1 revision) (flutter/engine#37358) (flutter/flutter#114765)
IVLIVS-III pushed a commit to IVLIVS-III/flutter_plugins_fork that referenced this pull request Nov 11, 2022
@engine-flutter-autoroll @IVLIVS-III
Roll Flutter from e0e7027 to 5ea5a53 (7 revisions) (flutter#6675)
85348c5 
* cef4c2a ICU Message Syntax Parser (flutter/flutter#112390)

* 07d3a64 0886c7d0b Narrow the scope of the Windows Android arm hack (flutter/engine#37125) (flutter/flutter#114751)

* cf0cd06 Mark new_gallery__transition_perf as non-flaky (flutter/flutter#114694)

* 5bc50c1 Fix macOS migration nothing-to-upgrade test (flutter/flutter#114703)

* b1509ed 36cfa9e68 Apply the Windows friendly path solution in remaining spots (flutter/engine#37344) (flutter/flutter#114759)

* b45e628 b8218eacc Roll Fuchsia Mac SDK from Ua8Jtf8Zka9uxIVdl... to sNXsQVxntMX8f42LE... (flutter/engine#37352) (flutter/flutter#114760)

* 5ea5a53 6f3018a72 Roll Skia from a34882309d04 to c3c31be8729b (1 revision) (flutter/engine#37358) (flutter/flutter#114765)
adam-harwood pushed a commit to adam-harwood/flutter_plugins that referenced this pull request Nov 21, 2022
@engine-flutter-autoroll
Roll Flutter from e0e7027 to 5ea5a53 (7 revisions) (flutter#6675)
4dbb5e8 
* cef4c2a ICU Message Syntax Parser (flutter/flutter#112390)

* 07d3a64 0886c7d0b Narrow the scope of the Windows Android arm hack (flutter/engine#37125) (flutter/flutter#114751)

* cf0cd06 Mark new_gallery__transition_perf as non-flaky (flutter/flutter#114694)

* 5bc50c1 Fix macOS migration nothing-to-upgrade test (flutter/flutter#114703)

* b1509ed 36cfa9e68 Apply the Windows friendly path solution in remaining spots (flutter/engine#37344) (flutter/flutter#114759)

* b45e628 b8218eacc Roll Fuchsia Mac SDK from Ua8Jtf8Zka9uxIVdl... to sNXsQVxntMX8f42LE... (flutter/engine#37352) (flutter/flutter#114760)

* 5ea5a53 6f3018a72 Roll Skia from a34882309d04 to c3c31be8729b (1 revision) (flutter/engine#37358) (flutter/flutter#114765)
@amdshrif
Copy link

I still see the issue in Flutter 3.3.9.

user:~/workspace/flutter_foundations
$ sw_vers
ProductName: macOS
ProductVersion: 13.0.1
BuildVersion: 22A400

user:~/workspace/flutter_foundations
$ flutter --version
Flutter 3.3.9 • channel stable •
https://github.com/flutter/flutter.git
Framework • revision b8f7f1f (6 days ago) • 2022-11-23 06:43:51
+0900
Engine • revision 8f2221fbef
Tools • Dart 2.18.5 • DevTools 2.15.0

user:~/workspace/flutter_foundations
$ flutter run -d macos
Launching lib/main.dart on macOS in debug mode...
/Users/user/workspace/flutter_foundations/macos/Runner.xcodeproj: warning: The macOS deployment target 'MACOSX_DEPLOYMENT_TARGET' is set to 10.11, but the range of supported deployment target versions is 10.13 to 13.0.99. (in target 'Flutter Assemble' from project 'Runner')
/Users/user/workspace/flutter_foundations/macos/Runner.xcodeproj: warning: The macOS deployment target 'MACOSX_DEPLOYMENT_TARGET' is set to 10.11, but the range of supported deployment target versions is 10.13 to 13.0.99. (in target 'Runner' from project 'Runner')
warning: Run script build phase 'Run Script' will be run during every build because it does not specify any outputs. To address this warning, either add output dependencies to the script phase, or configure it to run in every build by unchecking "Based on dependency analysis" in the script phase. (in target 'Runner' from project 'Runner')
Building macOS application...
Syncing files to device macOS... 61ms

Flutter run key commands.
r Hot reload. 🔥🔥🔥
R Hot restart.
h List all available interactive commands.
d Detach (terminate "flutter run" but leave application running).
c Clear the screen
q Quit (terminate the application on the device).

💪 Running with sound null safety 💪

@amdshrif
Copy link

amdshrif commented Nov 28, 2022 •
edited
Loading

Looks like the commit is not in stable branch yet

user:~/flutter ‹stable›
$ git pull
remote: Enumerating objects: 130, done.
remote: Counting objects: 100% (123/123), done.
remote: Total 130 (delta 122), reused 122 (delta 122), pack-reused 7
Receiving objects: 100% (130/130), 184.68 KiB | 3.62 MiB/s, done.
Resolving deltas: 100% (122/122), completed with 72 local objects.
From https://github.com/flutter/flutter
ff59250..2703a2b main -> origin/main
ff59250..2703a2b master -> origin/master

  • [new branch] revert-115009-fix_linux_remapped_capslock_throws -> origin/revert-115009-fix_linux_remapped_capslock_throws

Already up to date.
user:/flutter ‹stable›
$ git log | grep d33a11c
user:/flutter ‹stable›
$

@jmagman
Copy link
Member

jmagman commented Nov 28, 2022

This is available in 3.6.0-0.0.pre, see https://github.com/flutter/flutter/wiki/Where's-my-Commit%3F#finding-the-versions-that-contain-framework-commit-x

shogohida pushed a commit to shogohida/flutter that referenced this pull request Dec 7, 2022
@cbracken @shogohida
Fix macOS migration nothing-to-upgrade test (flutter#114703)
6ff5e56 
When testing whether a macOS deployment target version migration is
unnecessary due to already being at the target version, we were
previously checking the iOS deployment target version rather than the
macOS version. This updates it to test MACOSX_DEPLOYMENT_TARGET instead.
gspencergoog pushed a commit to gspencergoog/flutter that referenced this pull request Jan 19, 2023
@cbracken @gspencergoog
Fix macOS migration nothing-to-upgrade test (flutter#114703)
211f2ae 
When testing whether a macOS deployment target version migration is
unnecessary due to already being at the target version, we were
previously checking the iOS deployment target version rather than the
macOS version. This updates it to test MACOSX_DEPLOYMENT_TARGET instead.
mauricioluz pushed a commit to mauricioluz/plugins that referenced this pull request Jan 26, 2023
@engine-flutter-autoroll @mauricioluz
Roll Flutter from e0e7027 to 5ea5a53 (7 revisions) (flutter#6675)
e6599c7 
* cef4c2a ICU Message Syntax Parser (flutter/flutter#112390)

* 07d3a64 0886c7d0b Narrow the scope of the Windows Android arm hack (flutter/engine#37125) (flutter/flutter#114751)

* cf0cd06 Mark new_gallery__transition_perf as non-flaky (flutter/flutter#114694)

* 5bc50c1 Fix macOS migration nothing-to-upgrade test (flutter/flutter#114703)

* b1509ed 36cfa9e68 Apply the Windows friendly path solution in remaining spots (flutter/engine#37344) (flutter/flutter#114759)

* b45e628 b8218eacc Roll Fuchsia Mac SDK from Ua8Jtf8Zka9uxIVdl... to sNXsQVxntMX8f42LE... (flutter/engine#37352) (flutter/flutter#114760)

* 5ea5a53 6f3018a72 Roll Skia from a34882309d04 to c3c31be8729b (1 revision) (flutter/engine#37358) (flutter/flutter#114765)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jmagman jmagman jmagman approved these changes

Assignees
No one assigned
Labels
tool Affects the "flutter" command-line tool. See also t: labels.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@cbracken @amdshrif @jmagman