Skip to content

[tools]reland validation basic Xcode settings for build ipa #114634

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Nov 3, 2022
Merged

[tools]reland validation basic Xcode settings for build ipa #114634

merged 1 commit into from
Nov 3, 2022

Conversation

hellohuanlin
Copy link
Contributor

Relands #113412

List which issues are fixed by this PR. You must list at least one issue.
#97730

Pre-launch Checklist

  • I read the Contributor Guide and followed the process outlined there for submitting PRs.
  • I read the Tree Hygiene wiki page, which explains my responsibilities.
  • I read and followed the Flutter Style Guide, including Features we expect every widget to implement.
  • I signed the CLA.
  • I listed at least one issue that this PR fixes in the description above.
  • I updated/added relevant documentation (doc comments with ///).
  • I added new tests to check the change I am making, or this PR is test-exempt.
  • All existing and new tests are passing.

If you need help, consider asking for advice on the #hackers-new channel on Discord.

@flutter-dashboard flutter-dashboard bot added platform-ios iOS applications specifically tool Affects the "flutter" command-line tool. See also t: labels. labels Nov 3, 2022
jmagman
jmagman approved these changes Nov 3, 2022
View reviewed changes
Copy link
Member

@jmagman jmagman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

List which issues are fixed by this PR. You must list at least one issue.
#97730

If you format this as "Fixes #97730" then GitHub will link them in the UI and auto-close the issue.

@hellohuanlin
Copy link
Contributor Author

hellohuanlin commented Nov 3, 2022 •
edited
Loading

If you format this as "Fixes #97730" then GitHub will link them in the UI and auto-close the issue.

I think I still want a few more features like warning about using the default app icon, etc. So let's keep the issue open for now.

@hellohuanlin hellohuanlin added the autosubmit Merge PR when tree becomes green via auto submit App label Nov 3, 2022
@auto-submit auto-submit bot merged commit 8a9ddad into flutter:master Nov 3, 2022
This was referenced Nov 4, 2022
Merged
Merged
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Nov 4, 2022
@engine-flutter-autoroll
8a9ddad [tools]validation basic Xcode settings for build ipa (#113412) (
a57a577 
flutter/flutter#114634)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/plugins that referenced this pull request Nov 4, 2022
@engine-flutter-autoroll
8a9ddad [tools]validation basic Xcode settings for build ipa (#113412) (
abc6342 
flutter/flutter#114634)
auto-submit bot pushed a commit to flutter/packages that referenced this pull request Nov 4, 2022
@engine-flutter-autoroll
Roll Flutter from e6300da to 55e8cd1 (17 revisions) (#2780)
be60374 
* 0943693 Revert "[tools]validation basic Xcode settings for build ipa (#113412)" (flutter/flutter#114615)

* a440c46 Do not assume that pub is the first command run by "flutter create" (flutter/flutter#114621)

* 33b81ed fixes for incoming linter (flutter/flutter#113794)

* 0186b14 Fix the path where footer is written. (flutter/flutter#114469)

* 44ecbbc Roll Flutter Engine from 840a7b346216 to 66b244d9fa0a (25 revisions) (flutter/flutter#114640)

* 2ce62b3 Roll Flutter Engine from 66b244d9fa0a to e3c51631a9b5 (2 revisions) (flutter/flutter#114643)

* 8a9ddad [tools]validation basic Xcode settings for build ipa (#113412) (flutter/flutter#114634)

* 009fa69 Revert "Scribble mixin (#104128)" (flutter/flutter#114647)

* 125b9a7 Roll Flutter Engine from e3c51631a9b5 to ed31c3d76df5 (2 revisions) (flutter/flutter#114648)

* 9f6090c Revert "Fix text field label animation duration and curve" (flutter/flutter#114646)

* 44b6cd2 Roll Flutter Engine from ed31c3d76df5 to fb7cde697062 (2 revisions) (flutter/flutter#114651)

* fca260a Roll Flutter Engine from fb7cde697062 to 69a275300a28 (7 revisions) (flutter/flutter#114667)

* 7bee6e8 4b970fca0 Roll Dart SDK from c6e0307f3849 to 35b0cc8ac48b (2 revisions) (flutter/engine#37308) (flutter/flutter#114668)

* 43606d1 0a2d451b3 Roll Skia from b8209dce9a48 to 7eac7e7547e7 (1 revision) (flutter/engine#37309) (flutter/flutter#114670)

* 55fac57 2f90bda40 Merge AccessibilityBridge and AccessibilityBridgeDelegate (flutter/engine#36597) (flutter/flutter#114674)

* 4b7106c c5cc559db Roll Fuchsia Linux SDK from -0Xq1c-TncmWBWzqg... to 7e3H7isxOF6vqMDTT... (flutter/engine#37311) (flutter/flutter#114678)

* 55e8cd1 449fcc8b8 Roll Skia from 7eac7e7547e7 to c901cb6ae66f (1 revision) (flutter/engine#37313) (flutter/flutter#114683)
auto-submit bot pushed a commit to flutter/plugins that referenced this pull request Nov 4, 2022
@engine-flutter-autoroll
Roll Flutter from e6300da to 55e8cd1 (17 revisions) (#6670)
a279b9d 
* 0943693 Revert "[tools]validation basic Xcode settings for build ipa (#113412)" (flutter/flutter#114615)

* a440c46 Do not assume that pub is the first command run by "flutter create" (flutter/flutter#114621)

* 33b81ed fixes for incoming linter (flutter/flutter#113794)

* 0186b14 Fix the path where footer is written. (flutter/flutter#114469)

* 44ecbbc Roll Flutter Engine from 840a7b346216 to 66b244d9fa0a (25 revisions) (flutter/flutter#114640)

* 2ce62b3 Roll Flutter Engine from 66b244d9fa0a to e3c51631a9b5 (2 revisions) (flutter/flutter#114643)

* 8a9ddad [tools]validation basic Xcode settings for build ipa (#113412) (flutter/flutter#114634)

* 009fa69 Revert "Scribble mixin (#104128)" (flutter/flutter#114647)

* 125b9a7 Roll Flutter Engine from e3c51631a9b5 to ed31c3d76df5 (2 revisions) (flutter/flutter#114648)

* 9f6090c Revert "Fix text field label animation duration and curve" (flutter/flutter#114646)

* 44b6cd2 Roll Flutter Engine from ed31c3d76df5 to fb7cde697062 (2 revisions) (flutter/flutter#114651)

* fca260a Roll Flutter Engine from fb7cde697062 to 69a275300a28 (7 revisions) (flutter/flutter#114667)

* 7bee6e8 4b970fca0 Roll Dart SDK from c6e0307f3849 to 35b0cc8ac48b (2 revisions) (flutter/engine#37308) (flutter/flutter#114668)

* 43606d1 0a2d451b3 Roll Skia from b8209dce9a48 to 7eac7e7547e7 (1 revision) (flutter/engine#37309) (flutter/flutter#114670)

* 55fac57 2f90bda40 Merge AccessibilityBridge and AccessibilityBridgeDelegate (flutter/engine#36597) (flutter/flutter#114674)

* 4b7106c c5cc559db Roll Fuchsia Linux SDK from -0Xq1c-TncmWBWzqg... to 7e3H7isxOF6vqMDTT... (flutter/engine#37311) (flutter/flutter#114678)

* 55e8cd1 449fcc8b8 Roll Skia from 7eac7e7547e7 to c901cb6ae66f (1 revision) (flutter/engine#37313) (flutter/flutter#114683)
IVLIVS-III pushed a commit to IVLIVS-III/flutter_plugins_fork that referenced this pull request Nov 11, 2022
@engine-flutter-autoroll @IVLIVS-III
Roll Flutter from e6300da to 55e8cd1 (17 revisions) (flutter#6670)
36dbe9d 
* 0943693 Revert "[tools]validation basic Xcode settings for build ipa (#113412)" (flutter/flutter#114615)

* a440c46 Do not assume that pub is the first command run by "flutter create" (flutter/flutter#114621)

* 33b81ed fixes for incoming linter (flutter/flutter#113794)

* 0186b14 Fix the path where footer is written. (flutter/flutter#114469)

* 44ecbbc Roll Flutter Engine from 840a7b346216 to 66b244d9fa0a (25 revisions) (flutter/flutter#114640)

* 2ce62b3 Roll Flutter Engine from 66b244d9fa0a to e3c51631a9b5 (2 revisions) (flutter/flutter#114643)

* 8a9ddad [tools]validation basic Xcode settings for build ipa (#113412) (flutter/flutter#114634)

* 009fa69 Revert "Scribble mixin (#104128)" (flutter/flutter#114647)

* 125b9a7 Roll Flutter Engine from e3c51631a9b5 to ed31c3d76df5 (2 revisions) (flutter/flutter#114648)

* 9f6090c Revert "Fix text field label animation duration and curve" (flutter/flutter#114646)

* 44b6cd2 Roll Flutter Engine from ed31c3d76df5 to fb7cde697062 (2 revisions) (flutter/flutter#114651)

* fca260a Roll Flutter Engine from fb7cde697062 to 69a275300a28 (7 revisions) (flutter/flutter#114667)

* 7bee6e8 4b970fca0 Roll Dart SDK from c6e0307f3849 to 35b0cc8ac48b (2 revisions) (flutter/engine#37308) (flutter/flutter#114668)

* 43606d1 0a2d451b3 Roll Skia from b8209dce9a48 to 7eac7e7547e7 (1 revision) (flutter/engine#37309) (flutter/flutter#114670)

* 55fac57 2f90bda40 Merge AccessibilityBridge and AccessibilityBridgeDelegate (flutter/engine#36597) (flutter/flutter#114674)

* 4b7106c c5cc559db Roll Fuchsia Linux SDK from -0Xq1c-TncmWBWzqg... to 7e3H7isxOF6vqMDTT... (flutter/engine#37311) (flutter/flutter#114678)

* 55e8cd1 449fcc8b8 Roll Skia from 7eac7e7547e7 to c901cb6ae66f (1 revision) (flutter/engine#37313) (flutter/flutter#114683)
adam-harwood pushed a commit to adam-harwood/flutter_plugins that referenced this pull request Nov 21, 2022
@engine-flutter-autoroll
Roll Flutter from e6300da to 55e8cd1 (17 revisions) (flutter#6670)
5ee6847 
* 0943693 Revert "[tools]validation basic Xcode settings for build ipa (#113412)" (flutter/flutter#114615)

* a440c46 Do not assume that pub is the first command run by "flutter create" (flutter/flutter#114621)

* 33b81ed fixes for incoming linter (flutter/flutter#113794)

* 0186b14 Fix the path where footer is written. (flutter/flutter#114469)

* 44ecbbc Roll Flutter Engine from 840a7b346216 to 66b244d9fa0a (25 revisions) (flutter/flutter#114640)

* 2ce62b3 Roll Flutter Engine from 66b244d9fa0a to e3c51631a9b5 (2 revisions) (flutter/flutter#114643)

* 8a9ddad [tools]validation basic Xcode settings for build ipa (#113412) (flutter/flutter#114634)

* 009fa69 Revert "Scribble mixin (#104128)" (flutter/flutter#114647)

* 125b9a7 Roll Flutter Engine from e3c51631a9b5 to ed31c3d76df5 (2 revisions) (flutter/flutter#114648)

* 9f6090c Revert "Fix text field label animation duration and curve" (flutter/flutter#114646)

* 44b6cd2 Roll Flutter Engine from ed31c3d76df5 to fb7cde697062 (2 revisions) (flutter/flutter#114651)

* fca260a Roll Flutter Engine from fb7cde697062 to 69a275300a28 (7 revisions) (flutter/flutter#114667)

* 7bee6e8 4b970fca0 Roll Dart SDK from c6e0307f3849 to 35b0cc8ac48b (2 revisions) (flutter/engine#37308) (flutter/flutter#114668)

* 43606d1 0a2d451b3 Roll Skia from b8209dce9a48 to 7eac7e7547e7 (1 revision) (flutter/engine#37309) (flutter/flutter#114670)

* 55fac57 2f90bda40 Merge AccessibilityBridge and AccessibilityBridgeDelegate (flutter/engine#36597) (flutter/flutter#114674)

* 4b7106c c5cc559db Roll Fuchsia Linux SDK from -0Xq1c-TncmWBWzqg... to 7e3H7isxOF6vqMDTT... (flutter/engine#37311) (flutter/flutter#114678)

* 55e8cd1 449fcc8b8 Roll Skia from 7eac7e7547e7 to c901cb6ae66f (1 revision) (flutter/engine#37313) (flutter/flutter#114683)
shogohida pushed a commit to shogohida/flutter that referenced this pull request Dec 7, 2022
@hellohuanlin @shogohida
[tools]validation basic Xcode settings for build ipa (flutter#113412) (…
7a6f415 
…flutter#114634)
mauricioluz pushed a commit to mauricioluz/plugins that referenced this pull request Jan 26, 2023
@engine-flutter-autoroll @mauricioluz
Roll Flutter from e6300da to 55e8cd1 (17 revisions) (flutter#6670)
e4e071f 
* 0943693 Revert "[tools]validation basic Xcode settings for build ipa (#113412)" (flutter/flutter#114615)

* a440c46 Do not assume that pub is the first command run by "flutter create" (flutter/flutter#114621)

* 33b81ed fixes for incoming linter (flutter/flutter#113794)

* 0186b14 Fix the path where footer is written. (flutter/flutter#114469)

* 44ecbbc Roll Flutter Engine from 840a7b346216 to 66b244d9fa0a (25 revisions) (flutter/flutter#114640)

* 2ce62b3 Roll Flutter Engine from 66b244d9fa0a to e3c51631a9b5 (2 revisions) (flutter/flutter#114643)

* 8a9ddad [tools]validation basic Xcode settings for build ipa (#113412) (flutter/flutter#114634)

* 009fa69 Revert "Scribble mixin (#104128)" (flutter/flutter#114647)

* 125b9a7 Roll Flutter Engine from e3c51631a9b5 to ed31c3d76df5 (2 revisions) (flutter/flutter#114648)

* 9f6090c Revert "Fix text field label animation duration and curve" (flutter/flutter#114646)

* 44b6cd2 Roll Flutter Engine from ed31c3d76df5 to fb7cde697062 (2 revisions) (flutter/flutter#114651)

* fca260a Roll Flutter Engine from fb7cde697062 to 69a275300a28 (7 revisions) (flutter/flutter#114667)

* 7bee6e8 4b970fca0 Roll Dart SDK from c6e0307f3849 to 35b0cc8ac48b (2 revisions) (flutter/engine#37308) (flutter/flutter#114668)

* 43606d1 0a2d451b3 Roll Skia from b8209dce9a48 to 7eac7e7547e7 (1 revision) (flutter/engine#37309) (flutter/flutter#114670)

* 55fac57 2f90bda40 Merge AccessibilityBridge and AccessibilityBridgeDelegate (flutter/engine#36597) (flutter/flutter#114674)

* 4b7106c c5cc559db Roll Fuchsia Linux SDK from -0Xq1c-TncmWBWzqg... to 7e3H7isxOF6vqMDTT... (flutter/engine#37311) (flutter/flutter#114678)

* 55e8cd1 449fcc8b8 Roll Skia from 7eac7e7547e7 to c901cb6ae66f (1 revision) (flutter/engine#37313) (flutter/flutter#114683)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jmagman jmagman jmagman approved these changes

@zanderso zanderso zanderso approved these changes

Assignees
No one assigned
Labels
autosubmit Merge PR when tree becomes green via auto submit App platform-ios iOS applications specifically tool Affects the "flutter" command-line tool. See also t: labels.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@hellohuanlin @jmagman @zanderso