Skip to content

[RawKeyboard] Allow inconsistent modifiers for Web #114499

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Nov 7, 2022
Merged

[RawKeyboard] Allow inconsistent modifiers for Web #114499

merged 1 commit into from
Nov 7, 2022

Conversation

bleroux
Copy link
Contributor

@bleroux bleroux commented Nov 2, 2022

Description

This PR fixes AltGr key throwing on Web. On Linux, the web key event for AltGr might have an inconsistent modifier state.

This PR updates dev/tools/gen_keycodes/data/web_logical_location_mapping.json to get a consistent logical key resolution for the web AltGraph key value (see w3.org/TR/uievents-key/#keys-modifier).

This PR also updates dev/tools/gen_keycodes/data/keyboard_key.tmpl according to the change made by #111331 (using brackets instead of backticks).

Related Issue

Fixes #113836

Tests

Adds 2 tests

@flutter-dashboard flutter-dashboard bot added framework flutter/packages/flutter repository. See also f: labels. c: contributor-productivity Team-specific productivity, code health, technical debt. labels Nov 2, 2022
@bleroux bleroux requested a review from dkwingsmt November 2, 2022 13:53
dkwingsmt
dkwingsmt approved these changes Nov 2, 2022
View reviewed changes
Copy link
Contributor

@dkwingsmt dkwingsmt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@bleroux bleroux force-pushed the raw_keyboard_fix_alt_gr_on_web branch from d9c4a34 to 7594bab Compare November 3, 2022 07:53
@bleroux bleroux mentioned this pull request Nov 3, 2022
Merged
@bleroux bleroux force-pushed the raw_keyboard_fix_alt_gr_on_web branch 6 times, most recently from fab969d to 93c3689 Compare November 7, 2022 06:41
@bleroux bleroux force-pushed the raw_keyboard_fix_alt_gr_on_web branch from 93c3689 to 096f7ca Compare November 7, 2022 17:38
@bleroux bleroux added the autosubmit Merge PR when tree becomes green via auto submit App label Nov 7, 2022
@auto-submit auto-submit bot merged commit 5628ebf into flutter:master Nov 7, 2022
@bleroux bleroux deleted the raw_keyboard_fix_alt_gr_on_web branch November 8, 2022 07:44
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Nov 8, 2022
Merged
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Nov 8, 2022
@engine-flutter-autoroll
5628ebf [RawKeyboard] Allow inconsistent modifiers for Web (flutter/f…
cfc3ddb 
…lutter#114499)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Nov 8, 2022
Merged
engine-flutter-autoroll added a commit to engine-flutter-autoroll/plugins that referenced this pull request Nov 8, 2022
@engine-flutter-autoroll
5628ebf [RawKeyboard] Allow inconsistent modifiers for Web (flutter/f…
a60fac7 
…lutter#114499)
auto-submit bot pushed a commit to flutter/packages that referenced this pull request Nov 8, 2022
@engine-flutter-autoroll
Roll Flutter from 5ea5a53 to a1432a9 (30 revisions) (#2788)
becdee4 
* 5280135 ecd3c4857 Roll Fuchsia Mac SDK from sNXsQVxntMX8f42LE... to 9Jb1-3tRPQ2ZhpTQC... (flutter/engine#37363) (flutter/flutter#114772)

* a6da104 Adds support for the Material Badge widget, BadgeTheme, BadgeThemeData (flutter/flutter#114560)

* 19c5fc5 0cbdf464c Add Matrix::LookAt (flutter/engine#37361) (flutter/flutter#114786)

* c551fe3 4e45cfb4a Roll Fuchsia Mac SDK from 9Jb1-3tRPQ2ZhpTQC... to 5XOj9l5e2wkSpMKT1... (flutter/engine#37369) (flutter/flutter#114789)

* a54a46d 6b57fddd1 Bump github/codeql-action from 2.1.29 to 2.1.31 (flutter/engine#37374) (flutter/flutter#114798)

* 3c9288c Increase minimum supported macOS version from 10.13 to 10.14 (flutter/flutter#114713)

* a1289a4 891d4a357 Roll Skia from c3c31be8729b to 513f0fd34590 (2 revisions) (flutter/engine#37377) (flutter/flutter#114802)

* 04d6fd2 Roll Plugins from a279b9d to 3ca3410 (4 revisions) (flutter/flutter#114813)

* 151c831 92d9ad27f Roll Skia from 513f0fd34590 to da9fad017aee (2 revisions) (flutter/engine#37379) (flutter/flutter#114816)

* d6a8e92 Revert "Adds support for the Material Badge widget, BadgeTheme, BadgeThemeData (#114560)" (flutter/flutter#114819)

* 7de60bb 334549704 Roll buildroot to d13d64086f5e301bd0415eede895b34af220ef42 (flutter/engine#37380) (flutter/flutter#114821)

* 496cf62 Delegate TestWindow.updateSemantics to the wrapped SingletonFlutterWindow (flutter/flutter#114733)

* 497a528 Fix TextField/CupertinoTextField hint style overflow not work. (flutter/flutter#114335)

* 7e36cf1 Mac Page Up / Page Down in text fields (flutter/flutter#105497)

* 77c06c2 0075e10bc Move gclient var property to ci.yaml (flutter/engine#37351) (flutter/flutter#114828)

* 378387b when getting xcworkspace, exclude hidden files (flutter/flutter#114099)

* e901832 4e03d059d [Android] Speed up the method 'FlutterRenderer.getBitmap' (flutter/engine#37342) (flutter/flutter#114833)

* 3cde69e Revert "Revert "Scribble mixin (#104128)" (#114647)" (flutter/flutter#114698)

* e1adc96 feat: provide a way to set the initial child's alignment (flutter/flutter#114745)

* fe5eb2d ee48c0392 Roll Fuchsia Mac SDK from 5XOj9l5e2wkSpMKT1... to sa5bVGimNo3JwLV27... (flutter/engine#37386) (flutter/flutter#114836)

* 5628ebf [RawKeyboard] Allow inconsistent modifiers for Web (flutter/flutter#114499)

* f1cdfa2 Use AppBar.systemOverlayStyle to style system navigation bar (flutter/flutter#104827)

* e4e902d [flutter_tools] add compilation failure tests for new cases added in impellerc (flutter/flutter#114757)

* 7640f31 a81a715ce Revert "Remove deprecated calls to updateSemantics in `PlatformDispatcher` (#36673)" (flutter/engine#37388) (flutter/flutter#114842)

* 585d445 Roll Flutter Engine from a81a715ce6b2 to df602070ac4b (3 revisions) (flutter/flutter#114847)

* 1ca2e0b Fix `CastError` in `StadiumBorder.lerpTo` and  `StadiumBorder.lerpFrom` when using `BorderRadiusDirectional` (flutter/flutter#114826)

* 2e85e74 004a30516 [fuchsia] embedding-flutter test (flutter/engine#37052) (flutter/flutter#114854)

* 139b8f4 Roll Flutter Engine from 004a305166d5 to e7d7edab98ad (2 revisions) (flutter/flutter#114855)

* 53e6876 Allow Flutter golden file tests to be flaky (flutter/flutter#114450)

* a1432a9 Refactor fix_data.yaml (flutter/flutter#114192)
auto-submit bot pushed a commit to flutter/plugins that referenced this pull request Nov 8, 2022
@engine-flutter-autoroll
Roll Flutter from a1289a4 to a1432a9 (23 revisions) (#6681)
910b61d 
* 04d6fd2 Roll Plugins from a279b9d to 3ca3410 (4 revisions) (flutter/flutter#114813)

* 151c831 92d9ad27f Roll Skia from 513f0fd34590 to da9fad017aee (2 revisions) (flutter/engine#37379) (flutter/flutter#114816)

* d6a8e92 Revert "Adds support for the Material Badge widget, BadgeTheme, BadgeThemeData (#114560)" (flutter/flutter#114819)

* 7de60bb 334549704 Roll buildroot to d13d64086f5e301bd0415eede895b34af220ef42 (flutter/engine#37380) (flutter/flutter#114821)

* 496cf62 Delegate TestWindow.updateSemantics to the wrapped SingletonFlutterWindow (flutter/flutter#114733)

* 497a528 Fix TextField/CupertinoTextField hint style overflow not work. (flutter/flutter#114335)

* 7e36cf1 Mac Page Up / Page Down in text fields (flutter/flutter#105497)

* 77c06c2 0075e10bc Move gclient var property to ci.yaml (flutter/engine#37351) (flutter/flutter#114828)

* 378387b when getting xcworkspace, exclude hidden files (flutter/flutter#114099)

* e901832 4e03d059d [Android] Speed up the method 'FlutterRenderer.getBitmap' (flutter/engine#37342) (flutter/flutter#114833)

* 3cde69e Revert "Revert "Scribble mixin (#104128)" (#114647)" (flutter/flutter#114698)

* e1adc96 feat: provide a way to set the initial child's alignment (flutter/flutter#114745)

* fe5eb2d ee48c0392 Roll Fuchsia Mac SDK from 5XOj9l5e2wkSpMKT1... to sa5bVGimNo3JwLV27... (flutter/engine#37386) (flutter/flutter#114836)

* 5628ebf [RawKeyboard] Allow inconsistent modifiers for Web (flutter/flutter#114499)

* f1cdfa2 Use AppBar.systemOverlayStyle to style system navigation bar (flutter/flutter#104827)

* e4e902d [flutter_tools] add compilation failure tests for new cases added in impellerc (flutter/flutter#114757)

* 7640f31 a81a715ce Revert "Remove deprecated calls to updateSemantics in `PlatformDispatcher` (#36673)" (flutter/engine#37388) (flutter/flutter#114842)

* 585d445 Roll Flutter Engine from a81a715ce6b2 to df602070ac4b (3 revisions) (flutter/flutter#114847)

* 1ca2e0b Fix `CastError` in `StadiumBorder.lerpTo` and  `StadiumBorder.lerpFrom` when using `BorderRadiusDirectional` (flutter/flutter#114826)

* 2e85e74 004a30516 [fuchsia] embedding-flutter test (flutter/engine#37052) (flutter/flutter#114854)

* 139b8f4 Roll Flutter Engine from 004a305166d5 to e7d7edab98ad (2 revisions) (flutter/flutter#114855)

* 53e6876 Allow Flutter golden file tests to be flaky (flutter/flutter#114450)

* a1432a9 Refactor fix_data.yaml (flutter/flutter#114192)
IVLIVS-III pushed a commit to IVLIVS-III/flutter_plugins_fork that referenced this pull request Nov 11, 2022
@engine-flutter-autoroll @IVLIVS-III
Roll Flutter from a1289a4 to a1432a9 (23 revisions) (flutter#6681)
48a019c 
* 04d6fd2 Roll Plugins from a279b9d to 3ca3410 (4 revisions) (flutter/flutter#114813)

* 151c831 92d9ad27f Roll Skia from 513f0fd34590 to da9fad017aee (2 revisions) (flutter/engine#37379) (flutter/flutter#114816)

* d6a8e92 Revert "Adds support for the Material Badge widget, BadgeTheme, BadgeThemeData (#114560)" (flutter/flutter#114819)

* 7de60bb 334549704 Roll buildroot to d13d64086f5e301bd0415eede895b34af220ef42 (flutter/engine#37380) (flutter/flutter#114821)

* 496cf62 Delegate TestWindow.updateSemantics to the wrapped SingletonFlutterWindow (flutter/flutter#114733)

* 497a528 Fix TextField/CupertinoTextField hint style overflow not work. (flutter/flutter#114335)

* 7e36cf1 Mac Page Up / Page Down in text fields (flutter/flutter#105497)

* 77c06c2 0075e10bc Move gclient var property to ci.yaml (flutter/engine#37351) (flutter/flutter#114828)

* 378387b when getting xcworkspace, exclude hidden files (flutter/flutter#114099)

* e901832 4e03d059d [Android] Speed up the method 'FlutterRenderer.getBitmap' (flutter/engine#37342) (flutter/flutter#114833)

* 3cde69e Revert "Revert "Scribble mixin (#104128)" (#114647)" (flutter/flutter#114698)

* e1adc96 feat: provide a way to set the initial child's alignment (flutter/flutter#114745)

* fe5eb2d ee48c0392 Roll Fuchsia Mac SDK from 5XOj9l5e2wkSpMKT1... to sa5bVGimNo3JwLV27... (flutter/engine#37386) (flutter/flutter#114836)

* 5628ebf [RawKeyboard] Allow inconsistent modifiers for Web (flutter/flutter#114499)

* f1cdfa2 Use AppBar.systemOverlayStyle to style system navigation bar (flutter/flutter#104827)

* e4e902d [flutter_tools] add compilation failure tests for new cases added in impellerc (flutter/flutter#114757)

* 7640f31 a81a715ce Revert "Remove deprecated calls to updateSemantics in `PlatformDispatcher` (#36673)" (flutter/engine#37388) (flutter/flutter#114842)

* 585d445 Roll Flutter Engine from a81a715ce6b2 to df602070ac4b (3 revisions) (flutter/flutter#114847)

* 1ca2e0b Fix `CastError` in `StadiumBorder.lerpTo` and  `StadiumBorder.lerpFrom` when using `BorderRadiusDirectional` (flutter/flutter#114826)

* 2e85e74 004a30516 [fuchsia] embedding-flutter test (flutter/engine#37052) (flutter/flutter#114854)

* 139b8f4 Roll Flutter Engine from 004a305166d5 to e7d7edab98ad (2 revisions) (flutter/flutter#114855)

* 53e6876 Allow Flutter golden file tests to be flaky (flutter/flutter#114450)

* a1432a9 Refactor fix_data.yaml (flutter/flutter#114192)
adam-harwood pushed a commit to adam-harwood/flutter_plugins that referenced this pull request Nov 21, 2022
@engine-flutter-autoroll
Roll Flutter from a1289a4 to a1432a9 (23 revisions) (flutter#6681)
af8e15b 
* 04d6fd2 Roll Plugins from a279b9d to 3ca3410 (4 revisions) (flutter/flutter#114813)

* 151c831 92d9ad27f Roll Skia from 513f0fd34590 to da9fad017aee (2 revisions) (flutter/engine#37379) (flutter/flutter#114816)

* d6a8e92 Revert "Adds support for the Material Badge widget, BadgeTheme, BadgeThemeData (#114560)" (flutter/flutter#114819)

* 7de60bb 334549704 Roll buildroot to d13d64086f5e301bd0415eede895b34af220ef42 (flutter/engine#37380) (flutter/flutter#114821)

* 496cf62 Delegate TestWindow.updateSemantics to the wrapped SingletonFlutterWindow (flutter/flutter#114733)

* 497a528 Fix TextField/CupertinoTextField hint style overflow not work. (flutter/flutter#114335)

* 7e36cf1 Mac Page Up / Page Down in text fields (flutter/flutter#105497)

* 77c06c2 0075e10bc Move gclient var property to ci.yaml (flutter/engine#37351) (flutter/flutter#114828)

* 378387b when getting xcworkspace, exclude hidden files (flutter/flutter#114099)

* e901832 4e03d059d [Android] Speed up the method 'FlutterRenderer.getBitmap' (flutter/engine#37342) (flutter/flutter#114833)

* 3cde69e Revert "Revert "Scribble mixin (#104128)" (#114647)" (flutter/flutter#114698)

* e1adc96 feat: provide a way to set the initial child's alignment (flutter/flutter#114745)

* fe5eb2d ee48c0392 Roll Fuchsia Mac SDK from 5XOj9l5e2wkSpMKT1... to sa5bVGimNo3JwLV27... (flutter/engine#37386) (flutter/flutter#114836)

* 5628ebf [RawKeyboard] Allow inconsistent modifiers for Web (flutter/flutter#114499)

* f1cdfa2 Use AppBar.systemOverlayStyle to style system navigation bar (flutter/flutter#104827)

* e4e902d [flutter_tools] add compilation failure tests for new cases added in impellerc (flutter/flutter#114757)

* 7640f31 a81a715ce Revert "Remove deprecated calls to updateSemantics in `PlatformDispatcher` (#36673)" (flutter/engine#37388) (flutter/flutter#114842)

* 585d445 Roll Flutter Engine from a81a715ce6b2 to df602070ac4b (3 revisions) (flutter/flutter#114847)

* 1ca2e0b Fix `CastError` in `StadiumBorder.lerpTo` and  `StadiumBorder.lerpFrom` when using `BorderRadiusDirectional` (flutter/flutter#114826)

* 2e85e74 004a30516 [fuchsia] embedding-flutter test (flutter/engine#37052) (flutter/flutter#114854)

* 139b8f4 Roll Flutter Engine from 004a305166d5 to e7d7edab98ad (2 revisions) (flutter/flutter#114855)

* 53e6876 Allow Flutter golden file tests to be flaky (flutter/flutter#114450)

* a1432a9 Refactor fix_data.yaml (flutter/flutter#114192)
shogohida pushed a commit to shogohida/flutter that referenced this pull request Dec 7, 2022
@bleroux @shogohida
[RawKeyboard] Allow inconsistent modifiers for Web (flutter#114499)
6ce05d0 
Co-authored-by: Bruno Leroux <bruno.leroux@gmail.com>
gspencergoog pushed a commit to gspencergoog/flutter that referenced this pull request Jan 19, 2023
@bleroux @gspencergoog
[RawKeyboard] Allow inconsistent modifiers for Web (flutter#114499)
1ae087a 
Co-authored-by: Bruno Leroux <bruno.leroux@gmail.com>
mauricioluz pushed a commit to mauricioluz/plugins that referenced this pull request Jan 26, 2023
@engine-flutter-autoroll @mauricioluz
Roll Flutter from a1289a4 to a1432a9 (23 revisions) (flutter#6681)
7f2aa46 
* 04d6fd2 Roll Plugins from a279b9d to 3ca3410 (4 revisions) (flutter/flutter#114813)

* 151c831 92d9ad27f Roll Skia from 513f0fd34590 to da9fad017aee (2 revisions) (flutter/engine#37379) (flutter/flutter#114816)

* d6a8e92 Revert "Adds support for the Material Badge widget, BadgeTheme, BadgeThemeData (#114560)" (flutter/flutter#114819)

* 7de60bb 334549704 Roll buildroot to d13d64086f5e301bd0415eede895b34af220ef42 (flutter/engine#37380) (flutter/flutter#114821)

* 496cf62 Delegate TestWindow.updateSemantics to the wrapped SingletonFlutterWindow (flutter/flutter#114733)

* 497a528 Fix TextField/CupertinoTextField hint style overflow not work. (flutter/flutter#114335)

* 7e36cf1 Mac Page Up / Page Down in text fields (flutter/flutter#105497)

* 77c06c2 0075e10bc Move gclient var property to ci.yaml (flutter/engine#37351) (flutter/flutter#114828)

* 378387b when getting xcworkspace, exclude hidden files (flutter/flutter#114099)

* e901832 4e03d059d [Android] Speed up the method 'FlutterRenderer.getBitmap' (flutter/engine#37342) (flutter/flutter#114833)

* 3cde69e Revert "Revert "Scribble mixin (#104128)" (#114647)" (flutter/flutter#114698)

* e1adc96 feat: provide a way to set the initial child's alignment (flutter/flutter#114745)

* fe5eb2d ee48c0392 Roll Fuchsia Mac SDK from 5XOj9l5e2wkSpMKT1... to sa5bVGimNo3JwLV27... (flutter/engine#37386) (flutter/flutter#114836)

* 5628ebf [RawKeyboard] Allow inconsistent modifiers for Web (flutter/flutter#114499)

* f1cdfa2 Use AppBar.systemOverlayStyle to style system navigation bar (flutter/flutter#104827)

* e4e902d [flutter_tools] add compilation failure tests for new cases added in impellerc (flutter/flutter#114757)

* 7640f31 a81a715ce Revert "Remove deprecated calls to updateSemantics in `PlatformDispatcher` (#36673)" (flutter/engine#37388) (flutter/flutter#114842)

* 585d445 Roll Flutter Engine from a81a715ce6b2 to df602070ac4b (3 revisions) (flutter/flutter#114847)

* 1ca2e0b Fix `CastError` in `StadiumBorder.lerpTo` and  `StadiumBorder.lerpFrom` when using `BorderRadiusDirectional` (flutter/flutter#114826)

* 2e85e74 004a30516 [fuchsia] embedding-flutter test (flutter/engine#37052) (flutter/flutter#114854)

* 139b8f4 Roll Flutter Engine from 004a305166d5 to e7d7edab98ad (2 revisions) (flutter/flutter#114855)

* 53e6876 Allow Flutter golden file tests to be flaky (flutter/flutter#114450)

* a1432a9 Refactor fix_data.yaml (flutter/flutter#114192)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dkwingsmt dkwingsmt dkwingsmt approved these changes

Assignees
No one assigned
Labels
autosubmit Merge PR when tree becomes green via auto submit App c: contributor-productivity Team-specific productivity, code health, technical debt. framework flutter/packages/flutter repository. See also f: labels.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Getting an exception when pressing AltGr key for Flutter Web
2 participants
@bleroux @dkwingsmt