[flutter_tools/dap] Map org-dartlang-sdk URIs to the location of the source files found by the analyzer #114369

DanTup · 2022-10-31T19:30:11Z

@christopherfujino this is a fix for Dart-Code/Dart-Code#4128.

The issue is that when the user navigates to an SDK sources using Go-to-Definition in their editor, they go into a local file in the SDK folder. The running VMs know nothing about this path so any breakpoints set inside it will not resolve (and similarly, if the debugger breaks inside SDK sources, it does not map back to these files and gives the user a temporary downloaded-from-the-vm version of the file instead).

To fix this, we need to map between the org-dartlang-sdk:// URIs that the VM Service can give us and the local file paths we know on the users machine. This (currently) needs to be done in DAP because it's the only place that has access to both.

I previously fixed this for Dart in dart-lang/sdk@08db718 however I subsequently found that Flutter apps have different URIs for the Dart SDK (org-dartlang-sdk:///third_party/dart instead of org-dartlang-sdk://dart) as well as having a dart:ui that maps to org-dartlang-sdk:///flutter.

So, I've updated DDS/DAP to allow debug adapters to contribute their own mappings, and this change adds the mappings for the Dart SDK and dart:ui based on their current locations. With this change, you can Go-to-Definition into both Dart SDK sources and dart:ui sources (both of which live in pkg/sky_engine on disk) and add breakpoints, and they will be hit while debugging.

I read the Contributor Guide and followed the process outlined there for submitting PRs.
I read the Tree Hygiene wiki page, which explains my responsibilities.
I read and followed the Flutter Style Guide, including Features we expect every widget to implement.
I signed the CLA.
I listed at least one issue that this PR fixes in the description above.
I updated/added relevant documentation (doc comments with ///).
I added new tests to check the change I am making, or this PR is test-exempt.
All existing and new tests are passing.

If you need help, consider asking for advice on the #hackers-new channel on Discord.

…source files found by the analyzer Fixes Dart-Code/Dart-Code#4128. Also related: - dart-lang/sdk#49863 - dart-lang/sdk#48435

christopherfujino · 2022-10-31T20:25:00Z

packages/flutter_tools/lib/src/debug_adapters/flutter_test_adapter.dart

@@ -19,7 +19,7 @@ import 'mixins.dart';

 /// A DAP Debug Adapter for running and debugging Flutter tests.
 class FlutterTestDebugAdapter extends DartDebugAdapter<FlutterLaunchRequestArguments, FlutterAttachRequestArguments>


Out of curiosity, any reason this doesn't implement FlutterDebugAdapter?

It probably could, but it would inherit some stuff that doesn't make sense for tests (eg. code that spawns flutter run processes).

Perhaps we should have an additional abstract base class for both Flutter debug adapters that has the shared stuff (but none of the specific stuff). I'll make a note to have a look at this and see if it can be cleaned up a little (in a separate PR).

Ahh, true, if you just implemented it, you might have to reproduce some functionality. And then extending you might over-inherit.

christopherfujino

LGTM

auto-submit · 2022-10-31T23:53:14Z

auto label is removed for flutter/flutter, pr: 114369, due to - The status or check suite Google testing has failed. Please fix the issues identified (or deflake) before re-applying this label.

DanTup · 2022-11-01T12:00:58Z

@christopherfujino are you able to check what the failure in Google testing is? Thanks!

… of the source files found by the analyzer (flutter/flutter#114369)

* 210a2aa Revert "Add Material 3 support for BottomAppBar" (flutter/flutter#114421) * 2bf666c Roll Flutter Engine from f721db653dd1 to 78ca5609d1cb (2 revisions) (flutter/flutter#114396) * d2ad439 Roll Flutter Engine from 78ca5609d1cb to 31a21c75d016 (1 revision) (flutter/flutter#114426) * b03a7b5 Roll Plugins from 91d7fe5 to 5c11747 (7 revisions) (flutter/flutter#114427) * 70a95d5 Mark `Linux_android new_gallery__transition_perf` flaky (flutter/flutter#114429) * 0d65b63 Roll Flutter Engine from 31a21c75d016 to e013908440cd (1 revision) (flutter/flutter#114430) * 8a8b361 Use hintText's TextStyle overflow (flutter/flutter#114378) * e6b4296 Roll Flutter Engine from e013908440cd to a98c82a5e583 (1 revision) (flutter/flutter#114438) * d0afbd7 Revert "Overlay always applies clip (#113770)" (flutter/flutter#114442) * 93b0042 Handle dragging improvements (flutter/flutter#114042) * dc1cedd Roll Flutter Engine from a98c82a5e583 to c1e1a089fa16 (4 revisions) (flutter/flutter#114444) * 8fe8728 Roll Flutter Engine from c1e1a089fa16 to f4da34f1f6a8 (4 revisions) (flutter/flutter#114449) * eadda3c Add Material 3 Popup Menu example and update existing example (flutter/flutter#114228) * fb9065f `Layer ... was previously used as oldLayer` assertion error in debug mode, and page being blank in release mode, caused by LeaderLayer addToScene bug (flutter/flutter#113998) * e37ab48 Introduce debugWithActiveLayoutCleared to avoid duplicated code (flutter/flutter#114003) * c23b5ca Fix `addToScene` documentation (flutter/flutter#113987) * 61deaef Fix bug that`timeDilation` is not reset, causing subsequent test errors, and add verifications to ensure such problem does not exist in the future (flutter/flutter#113830) * 17ec3b1 [flutter_tools] Introducing arg option for specifying the output directory for web (flutter/flutter#113076) * 17df76b Roll Flutter Engine from f4da34f1f6a8 to e95a7ae83097 (1 revision) (flutter/flutter#114453) * f10021b Roll Flutter Engine from e95a7ae83097 to 81f5c30b23f3 (6 revisions) (flutter/flutter#114464) * 97d0247 Add Material 3 support for `Slider` - Part 1 (flutter/flutter#114079) * 0b0e348 Roll Flutter Engine from 81f5c30b23f3 to 85c23bc12c56 (3 revisions) (flutter/flutter#114471) * 6c87d73 Roll Flutter Engine from 85c23bc12c56 to c05c8a8834ca (1 revision) (flutter/flutter#114476) * dbc6123 Roll Flutter Engine from c05c8a8834ca to 32faadb330fc (2 revisions) (flutter/flutter#114479) * 4b31473 Roll Flutter Engine from 32faadb330fc to f9abfc5964c9 (1 revision) (flutter/flutter#114480) * b2d9f9e Roll Flutter Engine from f9abfc5964c9 to 9a741295e793 (2 revisions) (flutter/flutter#114487) * 9d9b0e5 Roll Flutter Engine from 9a741295e793 to 03d5b933164c (1 revision) (flutter/flutter#114489) * 1a150ff Roll Flutter Engine from 03d5b933164c to 9ef5c9b0107b (2 revisions) (flutter/flutter#114492) * 6a66aa2 Add Material 3 support for BottomAppBar (reland #106525) (flutter/flutter#114439) * dca6f10 Roll Flutter Engine from 9ef5c9b0107b to f5eb26e3f763 (1 revision) (flutter/flutter#114494) * 45c3b02 Roll Flutter Engine from f5eb26e3f763 to fed311918037 (2 revisions) (flutter/flutter#114501) * 9f23391 [web] Changes to web keyboard selection shortcuts for more consistent behavior (flutter/flutter#114264) * db381d7 Roll Flutter Engine from fed311918037 to cdfd9d0ad69b (2 revisions) (flutter/flutter#114513) * 1cfdac4 Always invoke impeller ios shader target (flutter/flutter#114451) * 0e70a97 Refactor Animated[List, Grid, SliverList, SliverGrid] to share common code (flutter/flutter#113793) * 1f7bacf Marks Linux build_tests_2_3 to be unflaky (flutter/flutter#114527) * 3079873 [flutter_tools/dap] Map org-dartlang-sdk URIs to the location of the source files found by the analyzer (flutter/flutter#114369) * 78dbe66 Roll Flutter Engine from cdfd9d0ad69b to 4d1d7a41ebd2 (1 revision) (flutter/flutter#114532) * 3b0f833 [flutter_tools/dap] Add a base Flutter adapter class to avoid duplication between adapters (flutter/flutter#114533) * 0211df9 [flutter_tools] provide --timeout option to flutter drive (flutter/flutter#114458) * 475ccd4 Roll Flutter Engine from 4d1d7a41ebd2 to edb049257b52 (2 revisions) (flutter/flutter#114534) * 89418ef Added tokens for Snackbar widget. (flutter/flutter#114466) * b23c780 Roll Flutter Engine from edb049257b52 to e43555ad3b94 (1 revision) (flutter/flutter#114540) * 15867a6 Roll gallery to b6728704a6441ac37a21e433a1e43c990780d47b (flutter/flutter#114537) * 92a6668 Roll Flutter Engine from e43555ad3b94 to 840a7b346216 (4 revisions) (flutter/flutter#114546) * e6300da [tools]validation basic Xcode settings for build ipa (flutter/flutter#113412)

* 4f19a9f [flutter_tools] Add support for compiling shaders to JSON bundle for web (flutter/flutter#114295) * f186e1b Roll pub packages (flutter/flutter#114363) * 0c7ee58 Make `Linux_android android_semantics_integration_test` flaky (flutter/flutter#114361) * 7ab2bf8 Delete flutter_migrate code (flutter/flutter#114253) * 0d26c51 Roll Flutter Engine from e432d6fc3a9b to ef4acbfe67ac (2 revisions) (flutter/flutter#114367) * af44c05 Roll Flutter Engine from ef4acbfe67ac to 9ba3de8f078d (1 revision) (flutter/flutter#114368) * 7979c87 Roll Flutter Engine from 9ba3de8f078d to ef45b5ac5b4b (1 revision) (flutter/flutter#114370) * c1a0846 Roll Flutter Engine from ef45b5ac5b4b to 96c0353790a2 (2 revisions) (flutter/flutter#114372) * a75c1ff Roll Flutter Engine from 96c0353790a2 to 1a8ba7c5521a (1 revision) (flutter/flutter#114375) * b20b7d9 Roll Flutter Engine from 1a8ba7c5521a to c16e2c08724c (1 revision) (flutter/flutter#114379) * 37b7234 Add `maybeOf` for all the cases where `of` returns nullable. (flutter/flutter#114120) * 6edbaa7 Roll Flutter Engine from c16e2c08724c to 034a2da497d9 (2 revisions) (flutter/flutter#114387) * 4851401 Roll Flutter Engine from 034a2da497d9 to f721db653dd1 (1 revision) (flutter/flutter#114389) * c2edb20 Added token files for badges and lists. (flutter/flutter#114382) * 0f1d0e3 🎨 Improve exceptions thrown by asset bundle (flutter/flutter#114313) * 3894a06 Minor code cleanup: remove redundant return (flutter/flutter#114290) * 0e98194 Add Material 3 support for BottomAppBar (flutter/flutter#106525) * 210a2aa Revert "Add Material 3 support for BottomAppBar" (flutter/flutter#114421) * 2bf666c Roll Flutter Engine from f721db653dd1 to 78ca5609d1cb (2 revisions) (flutter/flutter#114396) * d2ad439 Roll Flutter Engine from 78ca5609d1cb to 31a21c75d016 (1 revision) (flutter/flutter#114426) * b03a7b5 Roll Plugins from 91d7fe5 to 5c11747 (7 revisions) (flutter/flutter#114427) * 70a95d5 Mark `Linux_android new_gallery__transition_perf` flaky (flutter/flutter#114429) * 0d65b63 Roll Flutter Engine from 31a21c75d016 to e013908440cd (1 revision) (flutter/flutter#114430) * 8a8b361 Use hintText's TextStyle overflow (flutter/flutter#114378) * e6b4296 Roll Flutter Engine from e013908440cd to a98c82a5e583 (1 revision) (flutter/flutter#114438) * d0afbd7 Revert "Overlay always applies clip (#113770)" (flutter/flutter#114442) * 93b0042 Handle dragging improvements (flutter/flutter#114042) * dc1cedd Roll Flutter Engine from a98c82a5e583 to c1e1a089fa16 (4 revisions) (flutter/flutter#114444) * 8fe8728 Roll Flutter Engine from c1e1a089fa16 to f4da34f1f6a8 (4 revisions) (flutter/flutter#114449) * eadda3c Add Material 3 Popup Menu example and update existing example (flutter/flutter#114228) * fb9065f `Layer ... was previously used as oldLayer` assertion error in debug mode, and page being blank in release mode, caused by LeaderLayer addToScene bug (flutter/flutter#113998) * e37ab48 Introduce debugWithActiveLayoutCleared to avoid duplicated code (flutter/flutter#114003) * c23b5ca Fix `addToScene` documentation (flutter/flutter#113987) * 61deaef Fix bug that`timeDilation` is not reset, causing subsequent test errors, and add verifications to ensure such problem does not exist in the future (flutter/flutter#113830) * 17ec3b1 [flutter_tools] Introducing arg option for specifying the output directory for web (flutter/flutter#113076) * 17df76b Roll Flutter Engine from f4da34f1f6a8 to e95a7ae83097 (1 revision) (flutter/flutter#114453) * f10021b Roll Flutter Engine from e95a7ae83097 to 81f5c30b23f3 (6 revisions) (flutter/flutter#114464) * 97d0247 Add Material 3 support for `Slider` - Part 1 (flutter/flutter#114079) * 0b0e348 Roll Flutter Engine from 81f5c30b23f3 to 85c23bc12c56 (3 revisions) (flutter/flutter#114471) * 6c87d73 Roll Flutter Engine from 85c23bc12c56 to c05c8a8834ca (1 revision) (flutter/flutter#114476) * dbc6123 Roll Flutter Engine from c05c8a8834ca to 32faadb330fc (2 revisions) (flutter/flutter#114479) * 4b31473 Roll Flutter Engine from 32faadb330fc to f9abfc5964c9 (1 revision) (flutter/flutter#114480) * b2d9f9e Roll Flutter Engine from f9abfc5964c9 to 9a741295e793 (2 revisions) (flutter/flutter#114487) * 9d9b0e5 Roll Flutter Engine from 9a741295e793 to 03d5b933164c (1 revision) (flutter/flutter#114489) * 1a150ff Roll Flutter Engine from 03d5b933164c to 9ef5c9b0107b (2 revisions) (flutter/flutter#114492) * 6a66aa2 Add Material 3 support for BottomAppBar (reland #106525) (flutter/flutter#114439) * dca6f10 Roll Flutter Engine from 9ef5c9b0107b to f5eb26e3f763 (1 revision) (flutter/flutter#114494) * 45c3b02 Roll Flutter Engine from f5eb26e3f763 to fed311918037 (2 revisions) (flutter/flutter#114501) * 9f23391 [web] Changes to web keyboard selection shortcuts for more consistent behavior (flutter/flutter#114264) * db381d7 Roll Flutter Engine from fed311918037 to cdfd9d0ad69b (2 revisions) (flutter/flutter#114513) * 1cfdac4 Always invoke impeller ios shader target (flutter/flutter#114451) * 0e70a97 Refactor Animated[List, Grid, SliverList, SliverGrid] to share common code (flutter/flutter#113793) * 1f7bacf Marks Linux build_tests_2_3 to be unflaky (flutter/flutter#114527) * 3079873 [flutter_tools/dap] Map org-dartlang-sdk URIs to the location of the source files found by the analyzer (flutter/flutter#114369) * 78dbe66 Roll Flutter Engine from cdfd9d0ad69b to 4d1d7a41ebd2 (1 revision) (flutter/flutter#114532) * 3b0f833 [flutter_tools/dap] Add a base Flutter adapter class to avoid duplication between adapters (flutter/flutter#114533) * 0211df9 [flutter_tools] provide --timeout option to flutter drive (flutter/flutter#114458) * 475ccd4 Roll Flutter Engine from 4d1d7a41ebd2 to edb049257b52 (2 revisions) (flutter/flutter#114534) * 89418ef Added tokens for Snackbar widget. (flutter/flutter#114466) * b23c780 Roll Flutter Engine from edb049257b52 to e43555ad3b94 (1 revision) (flutter/flutter#114540) * 15867a6 Roll gallery to b6728704a6441ac37a21e433a1e43c990780d47b (flutter/flutter#114537) * 92a6668 Roll Flutter Engine from e43555ad3b94 to 840a7b346216 (4 revisions) (flutter/flutter#114546) * e6300da [tools]validation basic Xcode settings for build ipa (flutter/flutter#113412)

* 210a2aa Revert "Add Material 3 support for BottomAppBar" (flutter/flutter#114421) * 2bf666c Roll Flutter Engine from f721db653dd1 to 78ca5609d1cb (2 revisions) (flutter/flutter#114396) * d2ad439 Roll Flutter Engine from 78ca5609d1cb to 31a21c75d016 (1 revision) (flutter/flutter#114426) * b03a7b5 Roll Plugins from 91d7fe5 to 5c11747 (7 revisions) (flutter/flutter#114427) * 70a95d5 Mark `Linux_android new_gallery__transition_perf` flaky (flutter/flutter#114429) * 0d65b63 Roll Flutter Engine from 31a21c75d016 to e013908440cd (1 revision) (flutter/flutter#114430) * 8a8b361 Use hintText's TextStyle overflow (flutter/flutter#114378) * e6b4296 Roll Flutter Engine from e013908440cd to a98c82a5e583 (1 revision) (flutter/flutter#114438) * d0afbd7 Revert "Overlay always applies clip (#113770)" (flutter/flutter#114442) * 93b0042 Handle dragging improvements (flutter/flutter#114042) * dc1cedd Roll Flutter Engine from a98c82a5e583 to c1e1a089fa16 (4 revisions) (flutter/flutter#114444) * 8fe8728 Roll Flutter Engine from c1e1a089fa16 to f4da34f1f6a8 (4 revisions) (flutter/flutter#114449) * eadda3c Add Material 3 Popup Menu example and update existing example (flutter/flutter#114228) * fb9065f `Layer ... was previously used as oldLayer` assertion error in debug mode, and page being blank in release mode, caused by LeaderLayer addToScene bug (flutter/flutter#113998) * e37ab48 Introduce debugWithActiveLayoutCleared to avoid duplicated code (flutter/flutter#114003) * c23b5ca Fix `addToScene` documentation (flutter/flutter#113987) * 61deaef Fix bug that`timeDilation` is not reset, causing subsequent test errors, and add verifications to ensure such problem does not exist in the future (flutter/flutter#113830) * 17ec3b1 [flutter_tools] Introducing arg option for specifying the output directory for web (flutter/flutter#113076) * 17df76b Roll Flutter Engine from f4da34f1f6a8 to e95a7ae83097 (1 revision) (flutter/flutter#114453) * f10021b Roll Flutter Engine from e95a7ae83097 to 81f5c30b23f3 (6 revisions) (flutter/flutter#114464) * 97d0247 Add Material 3 support for `Slider` - Part 1 (flutter/flutter#114079) * 0b0e348 Roll Flutter Engine from 81f5c30b23f3 to 85c23bc12c56 (3 revisions) (flutter/flutter#114471) * 6c87d73 Roll Flutter Engine from 85c23bc12c56 to c05c8a8834ca (1 revision) (flutter/flutter#114476) * dbc6123 Roll Flutter Engine from c05c8a8834ca to 32faadb330fc (2 revisions) (flutter/flutter#114479) * 4b31473 Roll Flutter Engine from 32faadb330fc to f9abfc5964c9 (1 revision) (flutter/flutter#114480) * b2d9f9e Roll Flutter Engine from f9abfc5964c9 to 9a741295e793 (2 revisions) (flutter/flutter#114487) * 9d9b0e5 Roll Flutter Engine from 9a741295e793 to 03d5b933164c (1 revision) (flutter/flutter#114489) * 1a150ff Roll Flutter Engine from 03d5b933164c to 9ef5c9b0107b (2 revisions) (flutter/flutter#114492) * 6a66aa2 Add Material 3 support for BottomAppBar (reland #106525) (flutter/flutter#114439) * dca6f10 Roll Flutter Engine from 9ef5c9b0107b to f5eb26e3f763 (1 revision) (flutter/flutter#114494) * 45c3b02 Roll Flutter Engine from f5eb26e3f763 to fed311918037 (2 revisions) (flutter/flutter#114501) * 9f23391 [web] Changes to web keyboard selection shortcuts for more consistent behavior (flutter/flutter#114264) * db381d7 Roll Flutter Engine from fed311918037 to cdfd9d0ad69b (2 revisions) (flutter/flutter#114513) * 1cfdac4 Always invoke impeller ios shader target (flutter/flutter#114451) * 0e70a97 Refactor Animated[List, Grid, SliverList, SliverGrid] to share common code (flutter/flutter#113793) * 1f7bacf Marks Linux build_tests_2_3 to be unflaky (flutter/flutter#114527) * 3079873 [flutter_tools/dap] Map org-dartlang-sdk URIs to the location of the source files found by the analyzer (flutter/flutter#114369) * 78dbe66 Roll Flutter Engine from cdfd9d0ad69b to 4d1d7a41ebd2 (1 revision) (flutter/flutter#114532) * 3b0f833 [flutter_tools/dap] Add a base Flutter adapter class to avoid duplication between adapters (flutter/flutter#114533) * 0211df9 [flutter_tools] provide --timeout option to flutter drive (flutter/flutter#114458) * 475ccd4 Roll Flutter Engine from 4d1d7a41ebd2 to edb049257b52 (2 revisions) (flutter/flutter#114534) * 89418ef Added tokens for Snackbar widget. (flutter/flutter#114466) * b23c780 Roll Flutter Engine from edb049257b52 to e43555ad3b94 (1 revision) (flutter/flutter#114540) * 15867a6 Roll gallery to b6728704a6441ac37a21e433a1e43c990780d47b (flutter/flutter#114537) * 92a6668 Roll Flutter Engine from e43555ad3b94 to 840a7b346216 (4 revisions) (flutter/flutter#114546) * e6300da [tools]validation basic Xcode settings for build ipa (flutter/flutter#113412)

[flutter_tools/dap] Map org-dartlang-sdk URIs to the location of the …

78f0254

…source files found by the analyzer Fixes Dart-Code/Dart-Code#4128. Also related: - dart-lang/sdk#49863 - dart-lang/sdk#48435

DanTup requested a review from christopherfujino October 31, 2022 19:30

flutter-dashboard bot added the tool Affects the "flutter" command-line tool. See also t: labels. label Oct 31, 2022

DanTup mentioned this pull request Oct 31, 2022

Dart SDK files are not correctly mapped to local sources when debugging a Flutter app Dart-Code/Dart-Code#4128

Closed

christopherfujino reviewed Oct 31, 2022

View reviewed changes

christopherfujino approved these changes Oct 31, 2022

View reviewed changes

DanTup added the autosubmit Merge PR when tree becomes green via auto submit App label Oct 31, 2022

auto-submit bot removed the autosubmit Merge PR when tree becomes green via auto submit App label Oct 31, 2022

christopherfujino added the autosubmit Merge PR when tree becomes green via auto submit App label Nov 2, 2022

auto-submit bot merged commit 3079873 into flutter:master Nov 2, 2022

engine-flutter-autoroll mentioned this pull request Nov 2, 2022

Roll Flutter from 0e98194681fd to 307987339ede (37 revisions) flutter/plugins#6655

Closed

engine-flutter-autoroll added a commit to engine-flutter-autoroll/plugins that referenced this pull request Nov 2, 2022

3079873 [flutter_tools/dap] Map org-dartlang-sdk URIs to the location…

7bc4fc0

… of the source files found by the analyzer (flutter/flutter#114369)

DanTup deleted the map-uris branch November 2, 2022 17:45

engine-flutter-autoroll mentioned this pull request Nov 2, 2022

Roll Flutter from 0e98194681fd to 78dbe6661b35 (38 revisions) flutter/plugins#6658

Closed

engine-flutter-autoroll added a commit to engine-flutter-autoroll/plugins that referenced this pull request Nov 2, 2022

3079873 [flutter_tools/dap] Map org-dartlang-sdk URIs to the location…

e3da97c

… of the source files found by the analyzer (flutter/flutter#114369)

engine-flutter-autoroll mentioned this pull request Nov 2, 2022

Roll Flutter from 37beffe2a98b to 92a66683a1ed (62 revisions) flutter/packages#2774

Closed

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Nov 2, 2022

3079873 [flutter_tools/dap] Map org-dartlang-sdk URIs to the location…

e6df1a7

… of the source files found by the analyzer (flutter/flutter#114369)

engine-flutter-autoroll mentioned this pull request Nov 3, 2022

Roll Flutter from 0e98194681fd to 92a66683a1ed (45 revisions) flutter/plugins#6663

Closed

engine-flutter-autoroll added a commit to engine-flutter-autoroll/plugins that referenced this pull request Nov 3, 2022

3079873 [flutter_tools/dap] Map org-dartlang-sdk URIs to the location…

938c15d

… of the source files found by the analyzer (flutter/flutter#114369)

This was referenced Nov 3, 2022

Roll Flutter from 37beffe2a98b to e6300da2c39f (63 revisions) flutter/packages#2776

Merged

Roll Flutter from 0e98194681fd to e6300da2c39f (46 revisions) flutter/plugins#6668

Merged

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Nov 3, 2022

3079873 [flutter_tools/dap] Map org-dartlang-sdk URIs to the location…

7c43b4a

… of the source files found by the analyzer (flutter/flutter#114369)

engine-flutter-autoroll added a commit to engine-flutter-autoroll/plugins that referenced this pull request Nov 3, 2022

3079873 [flutter_tools/dap] Map org-dartlang-sdk URIs to the location…

b77ad67

… of the source files found by the analyzer (flutter/flutter#114369)

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

[flutter_tools/dap] Map org-dartlang-sdk URIs to the location of the source files found by the analyzer #114369

[flutter_tools/dap] Map org-dartlang-sdk URIs to the location of the source files found by the analyzer #114369

Uh oh!

DanTup commented Oct 31, 2022

Uh oh!

christopherfujino Oct 31, 2022

Uh oh!

DanTup Oct 31, 2022

Uh oh!

christopherfujino Oct 31, 2022

Uh oh!

christopherfujino left a comment

Uh oh!

auto-submit bot commented Oct 31, 2022

Uh oh!

DanTup commented Nov 1, 2022

Uh oh!

Uh oh!

		@@ -19,7 +19,7 @@ import 'mixins.dart';

		/// A DAP Debug Adapter for running and debugging Flutter tests.
		class FlutterTestDebugAdapter extends DartDebugAdapter<FlutterLaunchRequestArguments, FlutterAttachRequestArguments>

[flutter_tools/dap] Map org-dartlang-sdk URIs to the location of the source files found by the analyzer #114369

[flutter_tools/dap] Map org-dartlang-sdk URIs to the location of the source files found by the analyzer #114369

Uh oh!

Conversation

DanTup commented Oct 31, 2022

Pre-launch Checklist

Uh oh!

christopherfujino Oct 31, 2022

Choose a reason for hiding this comment

Uh oh!

DanTup Oct 31, 2022

Choose a reason for hiding this comment

Uh oh!

christopherfujino Oct 31, 2022

Choose a reason for hiding this comment

Uh oh!

christopherfujino left a comment

Choose a reason for hiding this comment

Uh oh!

auto-submit bot commented Oct 31, 2022

Uh oh!

DanTup commented Nov 1, 2022

Uh oh!

Uh oh!