Skip to content

Deprecate ThemeData.bottomAppBarColor #111080

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 14 commits into from
Sep 8, 2022
Merged

Deprecate ThemeData.bottomAppBarColor #111080

merged 14 commits into from
Sep 8, 2022

Conversation

esouthren
Copy link
Contributor

Related: #91772

Pre-launch Checklist

  • I read the Contributor Guide and followed the process outlined there for submitting PRs.
  • I read the Tree Hygiene wiki page, which explains my responsibilities.
  • I read and followed the Flutter Style Guide, including Features we expect every widget to implement.
  • I signed the CLA.
  • I listed at least one issue that this PR fixes in the description above.
  • I updated/added relevant documentation (doc comments with ///).
  • I added new tests to check the change I am making, or this PR is test-exempt.
  • All existing and new tests are passing.

If you need help, consider asking for advice on the #hackers-new channel on Discord.

@flutter-dashboard flutter-dashboard bot added f: material design flutter/packages/flutter/material repository. framework flutter/packages/flutter repository. See also f: labels. c: contributor-productivity Team-specific productivity, code health, technical debt. c: tech-debt Technical debt, code quality, testing, etc. labels Sep 7, 2022
guidezpl
guidezpl reviewed Sep 7, 2022
View reviewed changes
@esouthren esouthren marked this pull request as ready for review September 8, 2022 09:06
@esouthren esouthren requested a review from guidezpl September 8, 2022 09:07
guidezpl
guidezpl approved these changes Sep 8, 2022
View reviewed changes
Copy link
Member

@guidezpl guidezpl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Another one bits the dust!

  _    ___ _____ __  __ 
 | |  / __|_   _|  \/  |
 | |_| (_ | | | | |\/| |
 |____\___| |_| |_|  |_|

@esouthren esouthren merged commit 1ed2312 into flutter:master Sep 8, 2022
@esouthren esouthren mentioned this pull request Sep 8, 2022
Open
42 tasks
This was referenced Sep 8, 2022
Closed
Merged
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Sep 8, 2022
@engine-flutter-autoroll
1ed2312 Deprecate ThemeDate.bottomAppBarColor (flutter/flutter#111080)
f047ee3
engine-flutter-autoroll added a commit to engine-flutter-autoroll/plugins that referenced this pull request Sep 8, 2022
@engine-flutter-autoroll
1ed2312 Deprecate ThemeDate.bottomAppBarColor (flutter/flutter#111080)
d580ace
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Sep 8, 2022
Merged
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Sep 8, 2022
@engine-flutter-autoroll
1ed2312 Deprecate ThemeDate.bottomAppBarColor (flutter/flutter#111080)
30b80b7
XilaiZhang added a commit that referenced this pull request Sep 8, 2022
@XilaiZhang
Revert "Deprecate ThemeDate.bottomAppBarColor (#111080)"
523a5f7 
This reverts commit 1ed2312.
@XilaiZhang XilaiZhang mentioned this pull request Sep 8, 2022
Closed
@HansMuller HansMuller changed the title Deprecate ThemeDate.bottomAppBarColor Deprecate ThemeData.bottomAppBarColor Sep 9, 2022
This was referenced Feb 24, 2024
Merged
Merged
Merged
auto-submit bot pushed a commit that referenced this pull request Feb 28, 2024
@QuncCccccc
Remove bottomAppBarColor from ThemeData (#144080)
e707f0d 
This PR is to remove deprecated ThemeData.bottomAppBarColor.

These parameters are made obsolete in #110162.
Part of #111080
auto-submit bot pushed a commit that referenced this pull request Feb 29, 2024
@QuncCccccc
Remove toggleableActiveColor from ThemeData (#144178)
1349c59 
This PR is to remove deprecated ThemeData.toggleableActiveColor.

These parameters are made obsolete in #97972.
Part of #111080
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@guidezpl guidezpl guidezpl approved these changes

Assignees
No one assigned
Labels
c: contributor-productivity Team-specific productivity, code health, technical debt. c: tech-debt Technical debt, code quality, testing, etc. f: material design flutter/packages/flutter/material repository. framework flutter/packages/flutter repository. See also f: labels.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@esouthren @guidezpl