Skip to content

Add outlineVariant and scrim colors to ColorScheme #109071

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 7 commits into from
Aug 8, 2022
Merged

Add outlineVariant and scrim colors to ColorScheme #109071

merged 7 commits into from
Aug 8, 2022

Conversation

guidezpl
Copy link
Member

@guidezpl guidezpl commented Aug 5, 2022

These colors were added to the M3 spec, and the material_color_utilities package has already been updated and rolled in.

Fixes #108948

Pre-launch Checklist

  • I read the Contributor Guide and followed the process outlined there for submitting PRs.
  • I read the Tree Hygiene wiki page, which explains my responsibilities.
  • I read and followed the Flutter Style Guide, including Features we expect every widget to implement.
  • I signed the CLA.
  • I listed at least one issue that this PR fixes in the description above.
  • I updated/added relevant documentation (doc comments with ///).
  • I added new tests to check the change I am making, or this PR is test-exempt.
  • All existing and new tests are passing.

If you need help, consider asking for advice on the #hackers-new channel on Discord.

@flutter-dashboard flutter-dashboard bot added f: material design flutter/packages/flutter/material repository. framework flutter/packages/flutter repository. See also f: labels. labels Aug 5, 2022
QuncCccccc
QuncCccccc approved these changes Aug 8, 2022
View reviewed changes
Copy link
Contributor

@QuncCccccc QuncCccccc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM:)

@guidezpl guidezpl added the autosubmit Merge PR when tree becomes green via auto submit App label Aug 8, 2022
@auto-submit auto-submit bot merged commit d880c33 into flutter:master Aug 8, 2022
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Aug 8, 2022
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Aug 8, 2022
@engine-flutter-autoroll
d880c33 Add outlineVariant and scrim colors to ColorScheme (flu…
8387f54 
…tter/flutter#109071)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Aug 8, 2022
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Aug 8, 2022
@engine-flutter-autoroll
d880c33 Add outlineVariant and scrim colors to ColorScheme (flu…
6d59ee6 
…tter/flutter#109071)
@guidezpl guidezpl deleted the new-colors branch August 8, 2022 18:30
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Aug 8, 2022
Merged
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Aug 8, 2022
@engine-flutter-autoroll
d880c33 Add outlineVariant and scrim colors to ColorScheme (flu…
72abfac 
…tter/flutter#109071)
CaseyHillers added a commit that referenced this pull request Aug 9, 2022
@CaseyHillers
Revert "Add outlineVariant and scrim colors to ColorScheme (#10…
62361e6 
…9071)"

This reverts commit d880c33.
@CaseyHillers CaseyHillers mentioned this pull request Aug 9, 2022
Merged
CaseyHillers pushed a commit that referenced this pull request Aug 9, 2022
Revert "Add outlineVariant and scrim colors to ColorScheme (#10…
87f1684 
…9071)" (#109199)

This reverts commit d880c33.
guidezpl added a commit to guidezpl/flutter that referenced this pull request Aug 9, 2022
@guidezpl
Add outlineVariant and scrim colors to ColorScheme (flutter#109071
319a7c5 
)
@guidezpl guidezpl mentioned this pull request Aug 9, 2022
Merged
8 tasks
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Aug 9, 2022
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/plugins that referenced this pull request Aug 9, 2022
@engine-flutter-autoroll
d880c33 Add outlineVariant and scrim colors to ColorScheme (flu…
b12747f 
…tter/flutter#109071)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Aug 9, 2022
Merged
engine-flutter-autoroll added a commit to engine-flutter-autoroll/plugins that referenced this pull request Aug 9, 2022
@engine-flutter-autoroll
d880c33 Add outlineVariant and scrim colors to ColorScheme (flu…
d16079b 
…tter/flutter#109071)
guidezpl added a commit that referenced this pull request Aug 10, 2022
@guidezpl
Add outlineVariant and scrim colors to ColorScheme (#109071) (#…
4b7380c 
…109203)
camsim99 pushed a commit to camsim99/flutter that referenced this pull request Aug 10, 2022
@guidezpl @camsim99
Add outlineVariant and scrim colors to ColorScheme (flutter#109071
51aa047 
)
camsim99 pushed a commit to camsim99/flutter that referenced this pull request Aug 10, 2022
@camsim99
Revert "Add outlineVariant and scrim colors to ColorScheme (flu…
1ba2c4a 
…tter#109071)" (flutter#109199)

This reverts commit d880c33.
camsim99 pushed a commit to camsim99/flutter that referenced this pull request Aug 10, 2022
@guidezpl @camsim99
Add outlineVariant and scrim colors to ColorScheme (flutter#109071
360640c 
) (flutter#109203)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@QuncCccccc QuncCccccc QuncCccccc approved these changes

@darrenaustin darrenaustin Awaiting requested review from darrenaustin

Assignees
No one assigned
Labels
autosubmit Merge PR when tree becomes green via auto submit App f: material design flutter/packages/flutter/material repository. framework flutter/packages/flutter repository. See also f: labels.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add two new ColorScheme colors: outlineVariant, scrim
2 participants
@guidezpl @QuncCccccc