Skip to content

Update Chips examples and rename files #108538

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jul 29, 2022
Merged

Update Chips examples and rename files #108538

merged 1 commit into from
Jul 29, 2022

Conversation

TahaTesser
Copy link
Member

part of #101048

Pre-launch Checklist

  • I read the Contributor Guide and followed the process outlined there for submitting PRs.
  • I read the Tree Hygiene wiki page, which explains my responsibilities.
  • I read and followed the Flutter Style Guide, including Features we expect every widget to implement.
  • I signed the CLA.
  • I listed at least one issue that this PR fixes in the description above.
  • I updated/added relevant documentation (doc comments with ///).
  • I added new tests to check the change I am making, or this PR is test-exempt.
  • All existing and new tests are passing.

If you need help, consider asking for advice on the #hackers-new channel on Discord.

@flutter-dashboard flutter-dashboard bot added d: api docs Issues with https://api.flutter.dev/ d: examples Sample code and demos documentation f: material design flutter/packages/flutter/material repository. framework flutter/packages/flutter repository. See also f: labels. c: contributor-productivity Team-specific productivity, code health, technical debt. labels Jul 28, 2022
@TahaTesser TahaTesser requested a review from gspencergoog July 28, 2022 13:30
gspencergoog
gspencergoog requested changes Jul 28, 2022
View reviewed changes
@TahaTesser TahaTesser changed the title Update Chips examples Update Chips examples and rename files Jul 28, 2022
@TahaTesser TahaTesser requested a review from gspencergoog July 28, 2022 21:19
@TahaTesser
Copy link
Member Author

TahaTesser commented Jul 28, 2022 •
edited
Loading

@gspencergoog

Updated chip files and examples links
packages/flutter/lib/src/material/action_chip.dart
which contains
examples/api/lib/material/action_chip/action_chip.0.dart

gspencergoog
gspencergoog approved these changes Jul 28, 2022
View reviewed changes
Copy link
Contributor

@gspencergoog gspencergoog left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

32384589-a60f0e74-c078-11e7-9bc1-e5b5287aea9d

Looks great! Thanks for adding these.

@TahaTesser TahaTesser added the autosubmit Merge PR when tree becomes green via auto submit App label Jul 29, 2022
@auto-submit auto-submit bot merged commit 76df736 into flutter:master Jul 29, 2022
@TahaTesser TahaTesser deleted the m3_chips_examples branch July 29, 2022 07:17
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Jul 29, 2022
Merged
engine-flutter-autoroll added a commit to engine-flutter-autoroll/plugins that referenced this pull request Jul 29, 2022
@engine-flutter-autoroll
76df736 Update Chips examples and rename files (flutter/flutter#108538)
0a8be83
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Jul 29, 2022
Merged
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jul 29, 2022
@engine-flutter-autoroll
76df736 Update Chips examples and rename files (flutter/flutter#108538)
9c67587
camsim99 pushed a commit to camsim99/flutter that referenced this pull request Aug 10, 2022
@TahaTesser @camsim99
Update Chips examples and rename files (flutter#108538)
0a781de
@werainkhatri werainkhatri mentioned this pull request Sep 3, 2022
Closed
8 tasks
@werainkhatri werainkhatri mentioned this pull request Sep 11, 2022
Merged
8 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gspencergoog gspencergoog gspencergoog approved these changes

Assignees
No one assigned
Labels
autosubmit Merge PR when tree becomes green via auto submit App c: contributor-productivity Team-specific productivity, code health, technical debt. d: api docs Issues with https://api.flutter.dev/ d: examples Sample code and demos f: material design flutter/packages/flutter/material repository. framework flutter/packages/flutter repository. See also f: labels.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@TahaTesser @gspencergoog