Remove doc for --ignore-deprecation and check for pubspec before v1 embedding check #108523
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
stuartmorgan-g
approved these changes
Jul 28, 2022
| @@ -599,14 +599,11 @@ class AndroidProject extends FlutterProjectPlatform { | |||
| Warning | |||
| ────────────────────────────────────────────────────────────────────────────── | |||
| Your Flutter application is created using an older version of the Android | |||
| embedding. It is being deprecated in favor of Android embedding v2. Follow the | |||
| steps at | |||
| embedding. It is being deprecated in favor of Android embedding v2. Migrate | |||
There was a problem hiding this comment.
Maybe "To migrate your project, follow the steps at" per the recommendation against telling people to do something in the style guide. (That's in the documentation section, but seems relevant here.)
|
This pull request is not suitable for automatic merging in its current state.
|
|
This pull request is not suitable for automatic merging in its current state.
|
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/plugins
that referenced
this pull request
Jul 29, 2022
…ore v1 embedding check (flutter/flutter#108523)
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Jul 29, 2022
…ore v1 embedding check (flutter/flutter#108523)
camsim99
pushed a commit
to camsim99/flutter
that referenced
this pull request
Aug 10, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #96642
Also removes the documentation for the
--ignore-deprecationflag as we no longer want developers to ignore this warning. The flag still works and can be used, but developers will no longer see the suggestion to use it anymore.The next step is to deprecate the
--ignore-deprecationflag entirely to disable building for v1 embedding.