Skip to content

Reland "Upgrade Gradle and AGP versions to 7.5/7.2 and migrate benchmarks+examples" #108472 #108510

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 24 commits into from
Jul 29, 2022
Merged

Reland "Upgrade Gradle and AGP versions to 7.5/7.2 and migrate benchmarks+examples" #108472 #108510

merged 24 commits into from
Jul 29, 2022

Conversation

GaryQian
Copy link
Contributor

@GaryQian GaryQian commented Jul 28, 2022 •
edited
Loading

Upgraded projects requires android:exported="true"

GaryQian added 24 commits July 27, 2022 20:48
@flutter-dashboard flutter-dashboard bot added d: api docs Issues with https://api.flutter.dev/ d: examples Sample code and demos documentation c: contributor-productivity Team-specific productivity, code health, technical debt. tool Affects the "flutter" command-line tool. See also t: labels. labels Jul 28, 2022
@christopherfujino
Copy link
Contributor

Were you able to run the devicelab tests via LED for this?

@GaryQian
Copy link
Contributor Author

I was able to run and verify the tests locally with devicelab/bin/run.dart, but the LED tests were a bit finnicky to get all of them running, so it may not be worth the time for this PR. In any case, the failures on post submit were mostly build issues anyways, not CI env related.

christopherfujino
christopherfujino approved these changes Jul 28, 2022
View reviewed changes
Copy link
Contributor

@christopherfujino christopherfujino left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@fluttergithubbot fluttergithubbot merged commit 7cfbdad into flutter:master Jul 29, 2022
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Jul 29, 2022
Merged
engine-flutter-autoroll added a commit to engine-flutter-autoroll/plugins that referenced this pull request Jul 29, 2022
@engine-flutter-autoroll
7cfbdad Reland "Upgrade Gradle and AGP versions to 7.5/7.2 and migrat…
f6649a8 
…e benchmarks+examples" #108472 (flutter/flutter#108510)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Jul 29, 2022
Merged
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jul 29, 2022
@engine-flutter-autoroll
7cfbdad Reland "Upgrade Gradle and AGP versions to 7.5/7.2 and migrat…
5f5df29 
…e benchmarks+examples" #108472 (flutter/flutter#108510)
@GaryQian GaryQian mentioned this pull request Jul 29, 2022
Closed
camsim99 pushed a commit to camsim99/flutter that referenced this pull request Aug 10, 2022
@GaryQian @camsim99
Reland "Upgrade Gradle and AGP versions to 7.5/7.2 and migrate benchm…
b60c3c9 
…arks+examples" flutter#108472 (flutter#108510)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
1 more reviewer

@christopherfujino christopherfujino christopherfujino approved these changes

Reviewers whose approvals may not affect merge requirements
Assignees
No one assigned
Labels
c: contributor-productivity Team-specific productivity, code health, technical debt. d: api docs Issues with https://api.flutter.dev/ d: examples Sample code and demos tool Affects the "flutter" command-line tool. See also t: labels.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@GaryQian @christopherfujino @fluttergithubbot