Skip to content

Remove failing test Linux_android android_lifecycles_test. #108587

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jul 29, 2022
Merged

Remove failing test Linux_android android_lifecycles_test. #108587

merged 1 commit into from
Jul 29, 2022

Conversation

yusuf-goog
Copy link
Contributor

Bug:#108054

Pre-launch Checklist

  • I read the Contributor Guide and followed the process outlined there for submitting PRs.
  • I read the Tree Hygiene wiki page, which explains my responsibilities.
  • I read and followed the Flutter Style Guide, including Features we expect every widget to implement.
  • I signed the CLA.
  • I listed at least one issue that this PR fixes in the description above.
  • I updated/added relevant documentation (doc comments with ///).
  • I added new tests to check the change I am making, or this PR is test-exempt.
  • All existing and new tests are passing.

If you need help, consider asking for advice on the #hackers-new channel on Discord.

@yusuf-goog yusuf-goog requested a review from keyonghan as a code owner July 28, 2022 23:20
@yusuf-goog yusuf-goog self-assigned this Jul 29, 2022
@yusuf-goog yusuf-goog added the autosubmit Merge PR when tree becomes green via auto submit App label Jul 29, 2022
keyonghan
keyonghan approved these changes Jul 29, 2022
View reviewed changes
Copy link
Contributor

@keyonghan keyonghan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@auto-submit auto-submit bot merged commit 4aa3d74 into flutter:master Jul 29, 2022
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Jul 29, 2022
Merged
engine-flutter-autoroll added a commit to engine-flutter-autoroll/plugins that referenced this pull request Jul 29, 2022
@engine-flutter-autoroll
4aa3d74 Remove failing test Linux_android android_lifecycles_test. (f…
cee401e 
…lutter/flutter#108587)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Jul 29, 2022
Merged
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jul 29, 2022
@engine-flutter-autoroll
4aa3d74 Remove failing test Linux_android android_lifecycles_test. (f…
b1c3efb 
…lutter/flutter#108587)
camsim99 pushed a commit to camsim99/flutter that referenced this pull request Aug 10, 2022
@yusuf-goog @camsim99
Remove failing test Linux_android android_lifecycles_test. (flutter#1…
6b007bc 
…08587)
@reidbaker reidbaker mentioned this pull request Aug 24, 2023
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
1 more reviewer

@keyonghan keyonghan keyonghan approved these changes

Reviewers whose approvals may not affect merge requirements
Assignees

@yusuf-goog yusuf-goog

Labels
autosubmit Merge PR when tree becomes green via auto submit App
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@yusuf-goog @keyonghan