Skip to content

Conversation

jonahwilliams
Copy link
Contributor

@jonahwilliams jonahwilliams commented Jul 28, 2022

Reverts default usage of toPictureSync while we work through #108389

@flutter-dashboard flutter-dashboard bot added f: material design flutter/packages/flutter/material repository. framework flutter/packages/flutter repository. See also f: labels. labels Jul 28, 2022
@flutter-dashboard
Copy link

It looks like this pull request may not have tests. Please make sure to add tests before merging. If you need an exemption to this rule, contact Hixie on the #hackers channel in Chat (don't just cc him here, he won't see it! He's on Discord!).

If you are not sure if you need tests, consider this rule of thumb: the purpose of a test is to make sure someone doesn't accidentally revert the fix. Ask yourself, is there anything in your PR that you feel it is important we not accidentally revert back to how it was before your fix?

Reviewers: Read the Tree Hygiene page and make sure this patch meets those guidelines before LGTMing.

@jonahwilliams jonahwilliams requested a review from dnfield July 28, 2022 18:39
@jonahwilliams
Copy link
Contributor Author

Waiting to see what tests fail...

Copy link
Contributor

@dnfield dnfield left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM assuming tests pass.

@jonahwilliams
Copy link
Contributor Author

Test updated

@jonahwilliams jonahwilliams added the autosubmit Merge PR when tree becomes green via auto submit App label Jul 28, 2022
@auto-submit auto-submit bot merged commit 6cb2f5d into flutter:master Jul 28, 2022
@gaaclarke
Copy link
Member

@jonahwilliams jonahwilliams deleted the disable_new_transition branch July 28, 2022 23:50
@dnfield
Copy link
Contributor

dnfield commented Jul 28, 2022

This caused an expected regression in worst_frame_rasterizer_time: https://flutter-flutter-perf.skia.org/e/?begin=1659024246&end=1659047228&keys=X33785e9f2188721ac4d7c41915b31f19&num_commits=50&request_type=1&xbaroffset=30154

Yes - we're losing the benefits we had gained from this change, but for now we need to because the API has a race condition in it that can cause crashes, which I'm working on fixing.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
autosubmit Merge PR when tree becomes green via auto submit App f: material design flutter/packages/flutter/material repository. framework flutter/packages/flutter repository. See also f: labels.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants