Skip to content

Conversation

stuartmorgan-g
Copy link
Contributor

Picks up a fix to an out-of-band analyze failure due to a Mockito release.

Should fix the tree.

Picks up a fix to an out-of-band analyze failure due to a Mockito release.

Should fix the tree.
@flutter-dashboard
Copy link

It looks like this pull request may not have tests. Please make sure to add tests before merging. If you need an exemption to this rule, contact Hixie on the #hackers channel in Chat (don't just cc him here, he won't see it! He's on Discord!).

If you are not sure if you need tests, consider this rule of thumb: the purpose of a test is to make sure someone doesn't accidentally revert the fix. Ask yourself, is there anything in your PR that you feel it is important we not accidentally revert back to how it was before your fix?

Reviewers: Read the Tree Hygiene page and make sure this patch meets those guidelines before LGTMing.

Copy link
Contributor

@christopherfujino christopherfujino left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Piinks Piinks added warning: land on red to fix tree breakage autosubmit Merge PR when tree becomes green via auto submit App labels Jul 28, 2022
@auto-submit auto-submit bot merged commit 8d3ef0a into master Jul 28, 2022
@auto-submit auto-submit bot deleted the plugins-manual-roll-mockito branch July 28, 2022 17:47
@Hixie
Copy link
Contributor

Hixie commented Jul 29, 2022

test-exempt: roll

engine-flutter-autoroll added a commit to engine-flutter-autoroll/plugins that referenced this pull request Jul 29, 2022
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jul 29, 2022
godofredoc added a commit that referenced this pull request Aug 2, 2022
…108831)

* Guard against usage after async callbacks in RenderAndroidView, unregister listener (#108496)

* Roll flutter/plugins (#108556)

Co-authored-by: Dan Field <dnfield@google.com>
Co-authored-by: stuartmorgan <stuartmorgan@google.com>
@KourosBey KourosBey mentioned this pull request Aug 10, 2022
8 tasks
camsim99 pushed a commit to camsim99/flutter that referenced this pull request Aug 10, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
autosubmit Merge PR when tree becomes green via auto submit App
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants