Skip to content

Change default value of effectiveInactivePressedOverlayColor in Switch to refer to effectiveInactiveThumbColor #108477

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Jul 28, 2022
Merged

Change default value of effectiveInactivePressedOverlayColor in Switch to refer to effectiveInactiveThumbColor #108477

merged 2 commits into from
Jul 28, 2022

Conversation

QuncCccccc
Copy link
Contributor

The default value of effectiveInactivePressedOverlayColor was determined by effectiveActiveThumbColor which supposed to be effectiveInactiveThumbColor.

This PR fixes the typo.

Pre-launch Checklist

  • I read the [Contributor Guide] and followed the process outlined there for submitting PRs.
  • I read the [Tree Hygiene] wiki page, which explains my responsibilities.
  • I read and followed the [Flutter Style Guide], including [Features we expect every widget to implement].
  • I signed the [CLA].
  • I listed at least one issue that this PR fixes in the description above.
  • I updated/added relevant documentation (doc comments with ///).
  • I added new tests to check the change I am making, or this PR is [test-exempt].
  • All existing and new tests are passing.

@flutter-dashboard flutter-dashboard bot added f: material design flutter/packages/flutter/material repository. framework flutter/packages/flutter repository. See also f: labels. labels Jul 27, 2022
@QuncCccccc QuncCccccc marked this pull request as ready for review July 27, 2022 20:45
HansMuller
HansMuller approved these changes Jul 27, 2022
View reviewed changes
Copy link
Contributor

@HansMuller HansMuller left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@QuncCccccc QuncCccccc merged commit 8a8ed75 into flutter:master Jul 28, 2022
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Jul 29, 2022
Merged
engine-flutter-autoroll added a commit to engine-flutter-autoroll/plugins that referenced this pull request Jul 29, 2022
@engine-flutter-autoroll
8a8ed75 Change default value of `effectiveInactivePressedOverlayColor…
6dc6453 
…` in Switch to refer to `effectiveInactiveThumbColor` (flutter/flutter#108477)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Jul 29, 2022
Merged
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jul 29, 2022
@engine-flutter-autoroll
8a8ed75 Change default value of `effectiveInactivePressedOverlayColor…
c55bbba 
…` in Switch to refer to `effectiveInactiveThumbColor` (flutter/flutter#108477)
camsim99 pushed a commit to camsim99/flutter that referenced this pull request Aug 10, 2022
@QuncCccccc @camsim99
Change default value of effectiveInactivePressedOverlayColor in Swi…
c79c35d 
…tch to refer to `effectiveInactiveThumbColor` (flutter#108477)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@darrenaustin darrenaustin Awaiting requested review from darrenaustin

1 more reviewer

@HansMuller HansMuller HansMuller approved these changes

Reviewers whose approvals may not affect merge requirements
Assignees
No one assigned
Labels
f: material design flutter/packages/flutter/material repository. framework flutter/packages/flutter repository. See also f: labels.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@QuncCccccc @HansMuller