Skip to content

Conversation

GaryQian
Copy link
Contributor

Relands #108355, previous version missed updating lockfiles for benchmarks/platform_views_layout due to v1 embedding warning.

@flutter-dashboard flutter-dashboard bot added d: api docs Issues with https://api.flutter.dev/ d: examples Sample code and demos documentation c: contributor-productivity Team-specific productivity, code health, technical debt. tool Affects the "flutter" command-line tool. See also t: labels. labels Jul 27, 2022
@GaryQian
Copy link
Contributor Author

One more time, Hopefully it sticks this time. Verified all lockfiles are in place for every project changed.

Copy link
Member

@zanderso zanderso left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

rslgtm 🤞🏻

Copy link
Contributor

@christopherfujino christopherfujino left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

RSLGTM

@zanderso
Copy link
Member

Looks like this is breaking the tree again.

@Piinks
Copy link
Contributor

Piinks commented Jul 27, 2022

@zanderso is quicker on the draw again! 😛

@GaryQian
Copy link
Contributor Author

Is there a good way to run all the postsubmit tests in a PR on CI? I'd like to avoid more PR bouncing if possible

@zanderso
Copy link
Member

Is there a good way to run all the postsubmit tests in a PR on CI? I'd like to avoid more PR bouncing if possible

I believe this is difficult and requires a bunch of infra changes to understand the branch you want to test, but cc @keyonghan just in case he can suggest an easy way.

@christopherfujino
Copy link
Contributor

christopherfujino commented Jul 27, 2022

Is there a good way to run all the postsubmit tests in a PR on CI? I'd like to avoid more PR bouncing if possible

I remember implementing the flag --match-host-platform to try to do this: https://github.com/flutter/flutter/blob/master/dev/devicelab/bin/run.dart#L295; note this is for local use only, doesn't get run on CI

@keyonghan
Copy link
Contributor

Is there a good way to run all the postsubmit tests in a PR on CI? I'd like to avoid more PR bouncing if possible

I believe this is difficult and requires a bunch of infra changes to understand the branch you want to test, but cc @keyonghan just in case he can suggest an easy way.

That is true. I would suggest LED runs. A simple shell script to loop through all android targets, for which you need to change the git_url and git_ref to point to your PR (https://cs.opensource.google/flutter/recipes/+/main:recipes/devicelab/devicelab_drone.py;l=51).
As for the led command in the loop, here is a quick command

led get-builder "luci.flutter.prod:<Builder Name>” | led edit-system -p 40 | led edit-recipe-bundle | led launch

You may want to run this with a lower priority (40) to avoid affecting PROD queue time.

engine-flutter-autoroll added a commit to engine-flutter-autoroll/plugins that referenced this pull request Jul 28, 2022
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jul 28, 2022
camsim99 pushed a commit to camsim99/flutter that referenced this pull request Aug 10, 2022
camsim99 pushed a commit to camsim99/flutter that referenced this pull request Aug 10, 2022
camsim99 pushed a commit to camsim99/flutter that referenced this pull request Aug 10, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
c: contributor-productivity Team-specific productivity, code health, technical debt. d: api docs Issues with https://api.flutter.dev/ d: examples Sample code and demos tool Affects the "flutter" command-line tool. See also t: labels.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants