Skip to content

[web] define $flutterDriverResult variable early in driver test initalization #107337

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Jul 23, 2022
Merged

[web] define $flutterDriverResult variable early in driver test initalization #107337

merged 2 commits into from
Jul 23, 2022

Conversation

yjbanov
Copy link
Contributor

@yjbanov yjbanov commented Jul 9, 2022 •
edited by ditman
Loading

Define $flutterDriverResult during driver VM service extension initialization, so that by the time web_driver.dart is checking for its value it is guaranteed to be available. Otherwise, there's a race between the time the variable is checked, and the time the first driver command initializes it.

Fixes #102660
Fixes #107545

@flutter-dashboard flutter-dashboard bot added a: tests "flutter test", flutter_test, or one of our tests framework flutter/packages/flutter repository. See also f: labels. f: integration_test The flutter/packages/integration_test plugin labels Jul 9, 2022
@flutter-dashboard
Copy link

It looks like this pull request may not have tests. Please make sure to add tests before merging. If you need an exemption to this rule, contact Hixie on the #hackers channel in Chat (don't just cc him here, he won't see it! He's on Discord!).

If you are not sure if you need tests, consider this rule of thumb: the purpose of a test is to make sure someone doesn't accidentally revert the fix. Ask yourself, is there anything in your PR that you feel it is important we not accidentally revert back to how it was before your fix?

Reviewers: Read the Tree Hygiene page and make sure this patch meets those guidelines before LGTMing.

@yjbanov yjbanov mentioned this pull request Jul 12, 2022
Closed
@ditman
Copy link
Member

ditman commented Jul 20, 2022

Linked #107545 as well, that looks like a dup of the original issue this was fixing (in a different shard)

@ditman ditman mentioned this pull request Jul 20, 2022
Closed
@yjbanov yjbanov force-pushed the flaky-web-driver branch from 7bb372f to f0a14c4 Compare July 22, 2022 04:44
ditman
ditman approved these changes Jul 22, 2022
View reviewed changes
Copy link
Member

@ditman ditman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Only little nitpicks with the js-interop style, and maybe adding a watchdog to the self-check bits of the sendCommand method.

@ditman ditman added autosubmit Merge PR when tree becomes green via auto submit App and removed waiting for tree to go green labels Jul 23, 2022
@auto-submit auto-submit bot merged commit e505529 into flutter:master Jul 23, 2022
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Jul 23, 2022
Merged
engine-flutter-autoroll added a commit to engine-flutter-autoroll/plugins that referenced this pull request Jul 23, 2022
@engine-flutter-autoroll
e505529 [web] define $flutterDriverResult variable early in driver te…
a69c601 
…st initalization (flutter/flutter#107337)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Jul 23, 2022
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jul 23, 2022
@engine-flutter-autoroll
e505529 [web] define $flutterDriverResult variable early in driver te…
9611b6d 
…st initalization (flutter/flutter#107337)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Jul 23, 2022
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jul 23, 2022
@engine-flutter-autoroll
e505529 [web] define $flutterDriverResult variable early in driver te…
064b246 
…st initalization (flutter/flutter#107337)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Jul 24, 2022
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jul 24, 2022
@engine-flutter-autoroll
e505529 [web] define $flutterDriverResult variable early in driver te…
1be140c 
…st initalization (flutter/flutter#107337)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Jul 24, 2022
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jul 24, 2022
@engine-flutter-autoroll
e505529 [web] define $flutterDriverResult variable early in driver te…
fb05b80 
…st initalization (flutter/flutter#107337)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Jul 25, 2022
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jul 25, 2022
@engine-flutter-autoroll
e505529 [web] define $flutterDriverResult variable early in driver te…
2df1153 
…st initalization (flutter/flutter#107337)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Jul 25, 2022
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jul 25, 2022
@engine-flutter-autoroll
e505529 [web] define $flutterDriverResult variable early in driver te…
739c28e 
…st initalization (flutter/flutter#107337)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Jul 25, 2022
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jul 25, 2022
@engine-flutter-autoroll
e505529 [web] define $flutterDriverResult variable early in driver te…
f3c46bc 
…st initalization (flutter/flutter#107337)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Jul 25, 2022
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jul 25, 2022
@engine-flutter-autoroll
e505529 [web] define $flutterDriverResult variable early in driver te…
54d5746 
…st initalization (flutter/flutter#107337)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Jul 25, 2022
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jul 25, 2022
@engine-flutter-autoroll
e505529 [web] define $flutterDriverResult variable early in driver te…
bc65009 
…st initalization (flutter/flutter#107337)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Jul 25, 2022
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jul 25, 2022
@engine-flutter-autoroll
e505529 [web] define $flutterDriverResult variable early in driver te…
faa5988 
…st initalization (flutter/flutter#107337)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Jul 25, 2022
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jul 25, 2022
@engine-flutter-autoroll
e505529 [web] define $flutterDriverResult variable early in driver te…
5353995 
…st initalization (flutter/flutter#107337)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Jul 25, 2022
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jul 25, 2022
@engine-flutter-autoroll
e505529 [web] define $flutterDriverResult variable early in driver te…
e9b6cda 
…st initalization (flutter/flutter#107337)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Jul 25, 2022
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jul 25, 2022
@engine-flutter-autoroll
e505529 [web] define $flutterDriverResult variable early in driver te…
6b63420 
…st initalization (flutter/flutter#107337)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Jul 25, 2022
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jul 25, 2022
@engine-flutter-autoroll
e505529 [web] define $flutterDriverResult variable early in driver te…
9341f8a 
…st initalization (flutter/flutter#107337)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Jul 25, 2022
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jul 25, 2022
@engine-flutter-autoroll
e505529 [web] define $flutterDriverResult variable early in driver te…
e8f6577 
…st initalization (flutter/flutter#107337)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Jul 25, 2022
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jul 25, 2022
@engine-flutter-autoroll
e505529 [web] define $flutterDriverResult variable early in driver te…
8722c24 
…st initalization (flutter/flutter#107337)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Jul 26, 2022
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jul 26, 2022
@engine-flutter-autoroll
e505529 [web] define $flutterDriverResult variable early in driver te…
ddb2abe 
…st initalization (flutter/flutter#107337)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Jul 26, 2022
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jul 26, 2022
@engine-flutter-autoroll
e505529 [web] define $flutterDriverResult variable early in driver te…
af0f1d5 
…st initalization (flutter/flutter#107337)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jul 26, 2022
@engine-flutter-autoroll
e505529 [web] define $flutterDriverResult variable early in driver te…
74a5045 
…st initalization (flutter/flutter#107337)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jul 26, 2022
@engine-flutter-autoroll
e505529 [web] define $flutterDriverResult variable early in driver te…
f3fa2ba 
…st initalization (flutter/flutter#107337)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jul 26, 2022
@engine-flutter-autoroll
e505529 [web] define $flutterDriverResult variable early in driver te…
42272ed 
…st initalization (flutter/flutter#107337)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jul 26, 2022
@engine-flutter-autoroll
e505529 [web] define $flutterDriverResult variable early in driver te…
770baec 
…st initalization (flutter/flutter#107337)
camsim99 pushed a commit to camsim99/flutter that referenced this pull request Aug 10, 2022
@yjbanov @camsim99
[web] define $flutterDriverResult variable early in driver test inita…
965d221 
…lization (flutter#107337)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ditman ditman ditman approved these changes

Assignees
No one assigned
Labels
a: tests "flutter test", flutter_test, or one of our tests autosubmit Merge PR when tree becomes green via auto submit App f: integration_test The flutter/packages/integration_test plugin framework flutter/packages/flutter repository. See also f: labels.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Linux web_long_running_tests_4_5 is 2.00% flaky Linux web_long_running_tests_1_5 is 2.00% flaky
2 participants
@yjbanov @ditman