Skip to content

Fix RawScrollbar colors #107177

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jul 7, 2022
Merged

Fix RawScrollbar colors #107177

merged 1 commit into from
Jul 7, 2022

Conversation

Piinks
Copy link
Contributor

@Piinks Piinks commented Jul 6, 2022

Fixes #106917

This fixes a bug where the track colors are not applied in RawScrollbar.

Pre-launch Checklist

  • I read the Contributor Guide and followed the process outlined there for submitting PRs.
  • I read the Tree Hygiene wiki page, which explains my responsibilities.
  • I read and followed the Flutter Style Guide, including Features we expect every widget to implement.
  • I signed the CLA.
  • I listed at least one issue that this PR fixes in the description above.
  • I updated/added relevant documentation (doc comments with ///).
  • I added new tests to check the change I am making, or this PR is test-exempt.
  • All existing and new tests are passing.

If you need help, consider asking for advice on the #hackers-new channel on Discord.

@Piinks Piinks added framework flutter/packages/flutter repository. See also f: labels. f: scrolling Viewports, list views, slivers, etc. a: quality A truly polished experience labels Jul 6, 2022
@Piinks Piinks requested review from xu-baolin, snat-s and DavBot02 July 6, 2022 18:28
This was referenced Jul 6, 2022
Closed
Merged
Closed
xu-baolin
xu-baolin approved these changes Jul 7, 2022
View reviewed changes
Copy link
Member

@xu-baolin xu-baolin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@xu-baolin xu-baolin added the autosubmit Merge PR when tree becomes green via auto submit App label Jul 7, 2022
@auto-submit auto-submit bot merged commit 017fc6c into flutter:master Jul 7, 2022
This was referenced Jul 7, 2022
Merged
Merged
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jul 7, 2022
@engine-flutter-autoroll
017fc6c Fix RawScrollbar colors (flutter/flutter#107177)
e4196a5
engine-flutter-autoroll added a commit to engine-flutter-autoroll/plugins that referenced this pull request Jul 7, 2022
@engine-flutter-autoroll
017fc6c Fix RawScrollbar colors (flutter/flutter#107177)
31c5e87
camsim99 pushed a commit to camsim99/flutter that referenced this pull request Aug 10, 2022
@Piinks @camsim99
Fix RawScrollbar colors (flutter#107177)
42edbb8
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Aug 30, 2022
@engine-flutter-autoroll
017fc6c Fix RawScrollbar colors (flutter/flutter#107177)
c234e16
engine-flutter-autoroll added a commit to engine-flutter-autoroll/plugins that referenced this pull request Aug 30, 2022
@engine-flutter-autoroll
017fc6c Fix RawScrollbar colors (flutter/flutter#107177)
d101127
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@xu-baolin xu-baolin xu-baolin approved these changes

@snat-s snat-s Awaiting requested review from snat-s

@DavBot02 DavBot02 Awaiting requested review from DavBot02

Assignees
No one assigned
Labels
a: quality A truly polished experience autosubmit Merge PR when tree becomes green via auto submit App f: scrolling Viewports, list views, slivers, etc. framework flutter/packages/flutter repository. See also f: labels.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

RawScrollbar does not apply track or border color
2 participants
@Piinks @xu-baolin