Improve pub root directory interface #106567
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
CoderDake
commented
Jun 24, 2022
There was a problem hiding this comment.
I'm posting this PR up as a draft so I can ask Jacob a couple of questions.
@jacob314 this diff makes the test changes look way more complicated than they are.
the 'addPubRootDirectories' and 'pubRootDirectories' have been added separately, only a couple of small changes have been made to other tests. I've just fixed up the other tests to use 'resetPubRootDirectories' so that their usage of 'setPubRootDirectories' doesn't break.
CoderDake
commented
Jun 27, 2022
This reverts commit 35734ed6f2a87ed96f34358ec58a9c02f7afff9c.
reorganize tests to improve diff
This reverts commit 02c8d5971bcb0d3ff41809cb1998065703e64246.
|
Details about the follow up clean up have been added to #107186 |
CoderDake
commented
Jul 6, 2022
kenzieschmoll
approved these changes
Jul 7, 2022
This was referenced Jul 8, 2022
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/plugins
that referenced
this pull request
Jul 8, 2022
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Jul 8, 2022
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/plugins
that referenced
this pull request
Jul 8, 2022
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/plugins
that referenced
this pull request
Jul 8, 2022
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/plugins
that referenced
this pull request
Jul 8, 2022
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/plugins
that referenced
this pull request
Jul 9, 2022
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/plugins
that referenced
this pull request
Jul 9, 2022
camsim99
pushed a commit
to camsim99/flutter
that referenced
this pull request
Aug 10, 2022
The pubRoot directory interface is being changed to promote adding and removing directories
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Aug 30, 2022
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/plugins
that referenced
this pull request
Aug 30, 2022
8 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In order to improve interaction with the pubroot directories. The pubRoot directory interface is being changed to promote adding and removing directories. This will make it so that IDEs and Devtools can't overwrite each other's changes to the pub root directories if they call
setPubRootDirectoriesat the same time.Fixes #105730
Pre-launch Checklist
///).