Skip to content

Revert "Removing minor version from device_os value." #104755

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
May 26, 2022
Merged

Revert "Removing minor version from device_os value." #104755

merged 1 commit into from
May 26, 2022

Conversation

keyonghan
Copy link
Contributor

Reverts #104727

This is blocking the tree:
Screen Shot 2022-05-26 at 2 23 59 PM

@keyonghan keyonghan mentioned this pull request May 26, 2022
Merged
8 tasks
@keyonghan
Copy link
Contributor Author

Manually submit to unblock.

@keyonghan keyonghan merged commit b2eafd7 into master May 26, 2022
@keyonghan keyonghan deleted the revert-104727-master branch May 26, 2022 21:26
@yusuf-goog yusuf-goog mentioned this pull request May 26, 2022
Closed
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request May 27, 2022
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request May 27, 2022
@engine-flutter-autoroll
b2eafd7 Revert "Removing minor version from device_os value. (#104727…
3dd0f1c 
…)" (flutter/flutter#104755)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request May 27, 2022
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request May 27, 2022
@engine-flutter-autoroll
b2eafd7 Revert "Removing minor version from device_os value. (#104727…
b0f90b8 
…)" (flutter/flutter#104755)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request May 27, 2022
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request May 27, 2022
@engine-flutter-autoroll
b2eafd7 Revert "Removing minor version from device_os value. (#104727…
ea5370b 
…)" (flutter/flutter#104755)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request May 27, 2022
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request May 27, 2022
@engine-flutter-autoroll
b2eafd7 Revert "Removing minor version from device_os value. (#104727…
47c3d46 
…)" (flutter/flutter#104755)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request May 27, 2022
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request May 27, 2022
@engine-flutter-autoroll
b2eafd7 Revert "Removing minor version from device_os value. (#104727…
4ae6b8a 
…)" (flutter/flutter#104755)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request May 27, 2022
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request May 27, 2022
@engine-flutter-autoroll
b2eafd7 Revert "Removing minor version from device_os value. (#104727…
a40fcd6 
…)" (flutter/flutter#104755)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request May 28, 2022
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request May 28, 2022
@engine-flutter-autoroll
b2eafd7 Revert "Removing minor version from device_os value. (#104727…
dc4b490 
…)" (flutter/flutter#104755)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request May 28, 2022
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request May 28, 2022
@engine-flutter-autoroll
b2eafd7 Revert "Removing minor version from device_os value. (#104727…
8e5f9a6 
…)" (flutter/flutter#104755)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request May 28, 2022
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request May 28, 2022
@engine-flutter-autoroll
b2eafd7 Revert "Removing minor version from device_os value. (#104727…
a51b13e 
…)" (flutter/flutter#104755)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request May 28, 2022
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request May 28, 2022
@engine-flutter-autoroll
b2eafd7 Revert "Removing minor version from device_os value. (#104727…
c3eb20c 
…)" (flutter/flutter#104755)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request May 28, 2022
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request May 28, 2022
@engine-flutter-autoroll
b2eafd7 Revert "Removing minor version from device_os value. (#104727…
d3ec886 
…)" (flutter/flutter#104755)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request May 28, 2022
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jun 2, 2022
@engine-flutter-autoroll
b2eafd7 Revert "Removing minor version from device_os value. (#104727…
65f50b7 
…)" (flutter/flutter#104755)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jun 2, 2022
@engine-flutter-autoroll
b2eafd7 Revert "Removing minor version from device_os value. (#104727…
b663106 
…)" (flutter/flutter#104755)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jun 2, 2022
@engine-flutter-autoroll
b2eafd7 Revert "Removing minor version from device_os value. (#104727…
f98615b 
…)" (flutter/flutter#104755)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jun 2, 2022
@engine-flutter-autoroll
b2eafd7 Revert "Removing minor version from device_os value. (#104727…
4def295 
…)" (flutter/flutter#104755)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jun 2, 2022
@engine-flutter-autoroll
b2eafd7 Revert "Removing minor version from device_os value. (#104727…
552cb00 
…)" (flutter/flutter#104755)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jun 3, 2022
@engine-flutter-autoroll
b2eafd7 Revert "Removing minor version from device_os value. (#104727…
b555079 
…)" (flutter/flutter#104755)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jun 3, 2022
@engine-flutter-autoroll
b2eafd7 Revert "Removing minor version from device_os value. (#104727…
a49dc1b 
…)" (flutter/flutter#104755)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jun 3, 2022
@engine-flutter-autoroll
b2eafd7 Revert "Removing minor version from device_os value. (#104727…
a774a76 
…)" (flutter/flutter#104755)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/plugins that referenced this pull request Jun 3, 2022
@engine-flutter-autoroll
b2eafd7 Revert "Removing minor version from device_os value. (#104727…
4d29e2b 
…)" (flutter/flutter#104755)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jun 4, 2022
@engine-flutter-autoroll
b2eafd7 Revert "Removing minor version from device_os value. (#104727…
a581fdf 
…)" (flutter/flutter#104755)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jun 4, 2022
@engine-flutter-autoroll
b2eafd7 Revert "Removing minor version from device_os value. (#104727…
5a3a9f3 
…)" (flutter/flutter#104755)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jun 4, 2022
@engine-flutter-autoroll
b2eafd7 Revert "Removing minor version from device_os value. (#104727…
b17c962 
…)" (flutter/flutter#104755)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jun 5, 2022
@engine-flutter-autoroll
b2eafd7 Revert "Removing minor version from device_os value. (#104727…
f258667 
…)" (flutter/flutter#104755)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jun 5, 2022
@engine-flutter-autoroll
b2eafd7 Revert "Removing minor version from device_os value. (#104727…
93af125 
…)" (flutter/flutter#104755)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jun 5, 2022
@engine-flutter-autoroll
b2eafd7 Revert "Removing minor version from device_os value. (#104727…
05d10b9 
…)" (flutter/flutter#104755)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jun 6, 2022
@engine-flutter-autoroll
b2eafd7 Revert "Removing minor version from device_os value. (#104727…
14d761d 
…)" (flutter/flutter#104755)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jun 6, 2022
@engine-flutter-autoroll
b2eafd7 Revert "Removing minor version from device_os value. (#104727…
dedd21b 
…)" (flutter/flutter#104755)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jun 6, 2022
@engine-flutter-autoroll
b2eafd7 Revert "Removing minor version from device_os value. (#104727…
0bfd52e 
…)" (flutter/flutter#104755)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jun 6, 2022
@engine-flutter-autoroll
b2eafd7 Revert "Removing minor version from device_os value. (#104727…
f1ed43c 
…)" (flutter/flutter#104755)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jun 6, 2022
@engine-flutter-autoroll
b2eafd7 Revert "Removing minor version from device_os value. (#104727…
9478192 
…)" (flutter/flutter#104755)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jun 7, 2022
@engine-flutter-autoroll
b2eafd7 Revert "Removing minor version from device_os value. (#104727…
73ba13f 
…)" (flutter/flutter#104755)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jun 7, 2022
@engine-flutter-autoroll
b2eafd7 Revert "Removing minor version from device_os value. (#104727…
fbea719 
…)" (flutter/flutter#104755)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jun 7, 2022
@engine-flutter-autoroll
b2eafd7 Revert "Removing minor version from device_os value. (#104727…
e7566ea 
…)" (flutter/flutter#104755)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jun 7, 2022
@engine-flutter-autoroll
b2eafd7 Revert "Removing minor version from device_os value. (#104727…
9f0634d 
…)" (flutter/flutter#104755)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jun 7, 2022
@engine-flutter-autoroll
b2eafd7 Revert "Removing minor version from device_os value. (#104727…
56708ed 
…)" (flutter/flutter#104755)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jun 7, 2022
@engine-flutter-autoroll
b2eafd7 Revert "Removing minor version from device_os value. (#104727…
627b7e5 
…)" (flutter/flutter#104755)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jun 7, 2022
@engine-flutter-autoroll
b2eafd7 Revert "Removing minor version from device_os value. (#104727…
d1f7678 
…)" (flutter/flutter#104755)
camsim99 pushed a commit to camsim99/flutter that referenced this pull request Aug 10, 2022
@keyonghan @jmagman @camsim99
Revert "Removing minor version from device_os value. (flutter#104727)" (
c7efaed 
flutter#104755)

This reverts commit 8461e57.

Co-authored-by: Jenn Magder <magder@google.com>
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Aug 30, 2022
@engine-flutter-autoroll
b2eafd7 Revert "Removing minor version from device_os value. (#104727…
1d1d743 
…)" (flutter/flutter#104755)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/plugins that referenced this pull request Aug 30, 2022
@engine-flutter-autoroll
b2eafd7 Revert "Removing minor version from device_os value. (#104727…
3bdafc1 
…)" (flutter/flutter#104755)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jmagman jmagman jmagman approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@keyonghan @jmagman