Skip to content

Retry getting tabs in chrome launcher on ConnectionException #104218

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 8 commits into from
May 26, 2022
Merged

Retry getting tabs in chrome launcher on ConnectionException #104218

merged 8 commits into from
May 26, 2022

Conversation

annagrin
Copy link
Contributor

@annagrin annagrin commented May 20, 2022 •
edited
Loading

Add more information and potentially resolve web_tool_tests flakes caused by failure to get a tab list from Chrome on launch.

  • run flutter update-packages --force-upgrade to bring new package:webkit_inspection_protocol.dart and more.
  • update ChromeLauncher to pass a retryFor duration so we try getting tabs for a couple of seconds.
  • make ChromeLauncher.connect API available for testing.
  • add tests for ChromeLauncher.connect.

Closes: #94886

Pre-launch Checklist

  • [v] I read the [Contributor Guide] and followed the process outlined there for submitting PRs.
  • [v] I read the [Tree Hygiene] wiki page, which explains my responsibilities.
  • [v] I read and followed the [Flutter Style Guide], including [Features we expect every widget to implement].
  • [v] I signed the [CLA].
  • [v] I listed at least one issue that this PR fixes in the description above.
  • [v] I updated/added relevant documentation (doc comments with ///).
  • [v] I added new tests to check the change I am making, or this PR is [test-exempt].
  • [v] All existing and new tests are passing.

@annagrin annagrin requested a review from Piinks as a code owner May 20, 2022 00:12
@flutter-dashboard flutter-dashboard bot added c: contributor-productivity Team-specific productivity, code health, technical debt. tool Affects the "flutter" command-line tool. See also t: labels. labels May 20, 2022
@annagrin annagrin requested review from christopherfujino and removed request for Piinks May 20, 2022 00:12
@annagrin annagrin mentioned this pull request May 20, 2022
Closed
@annagrin annagrin requested a review from devoncarew May 20, 2022 17:42
devoncarew
devoncarew reviewed May 20, 2022
View reviewed changes
christopherfujino
christopherfujino reviewed May 20, 2022
View reviewed changes
christopherfujino
christopherfujino approved these changes May 20, 2022
View reviewed changes
Copy link
Contributor

@christopherfujino christopherfujino left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM with 1 nit

@christopherfujino
Update packages/flutter_tools/lib/src/web/chrome.dart
7b7f552 
Co-authored-by: Christopher Fujino <fujino@google.com>
@christopherfujino
Copy link
Contributor

@annagrin marked "Google testing" green because the CL says pre-submits passed, I'm guessing this is a FRoB bug. This is good to go!

@fluttergithubbot fluttergithubbot merged commit 5cd979e into flutter:master May 26, 2022
@annagrin
Copy link
Contributor Author

@christopherfujino

marked "Google testing" green because the CL says pre-submits passed, I'm guessing this is a FRoB bug. This is good to go!

Thanks, they were failing of a reason at first - package:webkit_inspection_protocol needed to be updated - so I fixed it and rerun the tests (that's why they were showing as passing) but the CI did not detect it for some reason.

@annagrin annagrin deleted the annagrin/web-tests-flakes branch May 26, 2022 22:21
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request May 27, 2022
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request May 27, 2022
@engine-flutter-autoroll
5cd979e Retry getting tabs in chrome launcher on ConnectionException (f…
65761a7 
…lutter/flutter#104218)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request May 27, 2022
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request May 27, 2022
@engine-flutter-autoroll
5cd979e Retry getting tabs in chrome launcher on ConnectionException (f…
5386371 
…lutter/flutter#104218)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request May 27, 2022
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request May 27, 2022
@engine-flutter-autoroll
5cd979e Retry getting tabs in chrome launcher on ConnectionException (f…
d7dc94f 
…lutter/flutter#104218)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request May 27, 2022
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jun 2, 2022
@engine-flutter-autoroll
5cd979e Retry getting tabs in chrome launcher on ConnectionException (f…
a805fc0 
…lutter/flutter#104218)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jun 2, 2022
@engine-flutter-autoroll
5cd979e Retry getting tabs in chrome launcher on ConnectionException (f…
b3bf29e 
…lutter/flutter#104218)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jun 2, 2022
@engine-flutter-autoroll
5cd979e Retry getting tabs in chrome launcher on ConnectionException (f…
a06a96e 
…lutter/flutter#104218)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jun 2, 2022
@engine-flutter-autoroll
5cd979e Retry getting tabs in chrome launcher on ConnectionException (f…
73f56ed 
…lutter/flutter#104218)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jun 2, 2022
@engine-flutter-autoroll
5cd979e Retry getting tabs in chrome launcher on ConnectionException (f…
e5731c8 
…lutter/flutter#104218)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jun 3, 2022
@engine-flutter-autoroll
5cd979e Retry getting tabs in chrome launcher on ConnectionException (f…
dd77fc1 
…lutter/flutter#104218)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jun 3, 2022
@engine-flutter-autoroll
5cd979e Retry getting tabs in chrome launcher on ConnectionException (f…
e6d962a 
…lutter/flutter#104218)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jun 3, 2022
@engine-flutter-autoroll
5cd979e Retry getting tabs in chrome launcher on ConnectionException (f…
c0a303f 
…lutter/flutter#104218)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/plugins that referenced this pull request Jun 3, 2022
@engine-flutter-autoroll
5cd979e Retry getting tabs in chrome launcher on ConnectionException (f…
4a265a1 
…lutter/flutter#104218)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jun 4, 2022
@engine-flutter-autoroll
5cd979e Retry getting tabs in chrome launcher on ConnectionException (f…
48b577a 
…lutter/flutter#104218)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jun 4, 2022
@engine-flutter-autoroll
5cd979e Retry getting tabs in chrome launcher on ConnectionException (f…
6346a62 
…lutter/flutter#104218)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jun 4, 2022
@engine-flutter-autoroll
5cd979e Retry getting tabs in chrome launcher on ConnectionException (f…
2bca70a 
…lutter/flutter#104218)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jun 5, 2022
@engine-flutter-autoroll
5cd979e Retry getting tabs in chrome launcher on ConnectionException (f…
8786566 
…lutter/flutter#104218)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jun 5, 2022
@engine-flutter-autoroll
5cd979e Retry getting tabs in chrome launcher on ConnectionException (f…
e39c45d 
…lutter/flutter#104218)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jun 5, 2022
@engine-flutter-autoroll
5cd979e Retry getting tabs in chrome launcher on ConnectionException (f…
0111b53 
…lutter/flutter#104218)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jun 6, 2022
@engine-flutter-autoroll
5cd979e Retry getting tabs in chrome launcher on ConnectionException (f…
6a57aa0 
…lutter/flutter#104218)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jun 6, 2022
@engine-flutter-autoroll
5cd979e Retry getting tabs in chrome launcher on ConnectionException (f…
db6c373 
…lutter/flutter#104218)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jun 6, 2022
@engine-flutter-autoroll
5cd979e Retry getting tabs in chrome launcher on ConnectionException (f…
0469fa1 
…lutter/flutter#104218)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jun 6, 2022
@engine-flutter-autoroll
5cd979e Retry getting tabs in chrome launcher on ConnectionException (f…
17a3aea 
…lutter/flutter#104218)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jun 6, 2022
@engine-flutter-autoroll
5cd979e Retry getting tabs in chrome launcher on ConnectionException (f…
526cd32 
…lutter/flutter#104218)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jun 7, 2022
@engine-flutter-autoroll
5cd979e Retry getting tabs in chrome launcher on ConnectionException (f…
8d3aa78 
…lutter/flutter#104218)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jun 7, 2022
@engine-flutter-autoroll
5cd979e Retry getting tabs in chrome launcher on ConnectionException (f…
50e02e1 
…lutter/flutter#104218)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jun 7, 2022
@engine-flutter-autoroll
5cd979e Retry getting tabs in chrome launcher on ConnectionException (f…
cfd9c15 
…lutter/flutter#104218)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jun 7, 2022
@engine-flutter-autoroll
5cd979e Retry getting tabs in chrome launcher on ConnectionException (f…
f68d771 
…lutter/flutter#104218)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jun 7, 2022
@engine-flutter-autoroll
5cd979e Retry getting tabs in chrome launcher on ConnectionException (f…
f5360bc 
…lutter/flutter#104218)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jun 7, 2022
@engine-flutter-autoroll
5cd979e Retry getting tabs in chrome launcher on ConnectionException (f…
c609405 
…lutter/flutter#104218)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jun 7, 2022
@engine-flutter-autoroll
5cd979e Retry getting tabs in chrome launcher on ConnectionException (f…
282d0f6 
…lutter/flutter#104218)
camsim99 pushed a commit to camsim99/flutter that referenced this pull request Aug 10, 2022
@camsim99
Retry getting tabs in chrome launcher on ConnectionException (flutter…
c5a3071 
…#104218)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Aug 30, 2022
@engine-flutter-autoroll
5cd979e Retry getting tabs in chrome launcher on ConnectionException (f…
d41f795 
…lutter/flutter#104218)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/plugins that referenced this pull request Aug 30, 2022
@engine-flutter-autoroll
5cd979e Retry getting tabs in chrome launcher on ConnectionException (f…
903741f 
…lutter/flutter#104218)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@devoncarew devoncarew devoncarew left review comments

+1 more reviewer

@christopherfujino christopherfujino christopherfujino approved these changes

Reviewers whose approvals may not affect merge requirements
Assignees
No one assigned
Labels
c: contributor-productivity Team-specific productivity, code health, technical debt. tool Affects the "flutter" command-line tool. See also t: labels.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Intermittent failure to connect to chrome tabs on test bots
4 participants
@annagrin @christopherfujino @devoncarew @fluttergithubbot