Skip to content

[Reland]: Fix DropdownButton menu clip #104251

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
May 25, 2022
Merged

[Reland]: Fix DropdownButton menu clip #104251

merged 1 commit into from
May 25, 2022

Conversation

TahaTesser
Copy link
Member

reland #102970 (based on #102970 (comment))

fixes #102914

Pre-launch Checklist

  • I read the Contributor Guide and followed the process outlined there for submitting PRs.
  • I read the Tree Hygiene wiki page, which explains my responsibilities.
  • I read and followed the Flutter Style Guide, including Features we expect every widget to implement.
  • I signed the CLA.
  • I listed at least one issue that this PR fixes in the description above.
  • I updated/added relevant documentation (doc comments with ///).
  • I added new tests to check the change I am making, or this PR is test-exempt.
  • All existing and new tests are passing.

If you need help, consider asking for advice on the #hackers-new channel on Discord.

@flutter-dashboard flutter-dashboard bot added f: material design flutter/packages/flutter/material repository. framework flutter/packages/flutter repository. See also f: labels. labels May 20, 2022
@TahaTesser TahaTesser requested a review from Piinks May 20, 2022 12:52
Piinks
Piinks approved these changes May 25, 2022
View reviewed changes
Copy link
Contributor

@Piinks Piinks left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM - but do not land this yet. Running internal tests to make sure this will not be reverted again.

@TahaTesser
Copy link
Member Author

LGTM - but do not land this yet. Running internal tests to make sure this will not be reverted again.

Thank you so much for running internal tests!

@Piinks
Copy link
Contributor

Piinks commented May 25, 2022

Good to go! 🎉

@fluttergithubbot fluttergithubbot merged commit a9c71d7 into flutter:master May 25, 2022
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request May 25, 2022
Merged
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request May 25, 2022
@engine-flutter-autoroll
a9c71d7 [Reland]: Fix DropdownButton menu clip (flutter/flutter#104251
48c2d01 
)
@TahaTesser TahaTesser deleted the reland_dropdown_clip branch May 26, 2022 06:49
engine-flutter-autoroll added a commit to engine-flutter-autoroll/plugins that referenced this pull request Jun 3, 2022
@engine-flutter-autoroll
a9c71d7 [Reland]: Fix DropdownButton menu clip (flutter/flutter#104251
c02eeaa 
)
@TahaTesser TahaTesser mentioned this pull request Jun 29, 2022
Closed
camsim99 pushed a commit to camsim99/flutter that referenced this pull request Aug 10, 2022
@TahaTesser @camsim99
[Reland]: Fix DropdownButton menu clip (flutter#104251)
e0d89e0
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Aug 30, 2022
@engine-flutter-autoroll
a9c71d7 [Reland]: Fix DropdownButton menu clip (flutter/flutter#104251
7672e20 
)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/plugins that referenced this pull request Aug 30, 2022
@engine-flutter-autoroll
a9c71d7 [Reland]: Fix DropdownButton menu clip (flutter/flutter#104251
a3c5e3d 
)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Piinks Piinks Piinks approved these changes

Assignees
No one assigned
Labels
f: material design flutter/packages/flutter/material repository. framework flutter/packages/flutter repository. See also f: labels.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

DropdownButton scrollbar is not clipped within the menu border radius
3 participants
@TahaTesser @Piinks @fluttergithubbot