Fix NavigationDestination API doc
#103031
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
HansMuller
reviewed
May 4, 2022
| /// ======= | ||
| /// A Material 3 [NavigationBar] destination. | ||
| /// | ||
| /// Displays a label below an icon. Use with [NavigationBar.destinations]. |
There was a problem hiding this comment.
You could preserve the original diagram by enclosing it in triple backquotes. Or you could generate a labeled diagram like the one that appears in the AppBar class API doc, using https://flutter.github.io/assets-for-api-docs/
There was a problem hiding this comment.
I don't think it's all that useful, given NavigationBar has a runnable code sample. I can add it to a new See also section
HansMuller
approved these changes
May 4, 2022
|
Thanks! |
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
May 4, 2022
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
May 4, 2022
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/plugins
that referenced
this pull request
May 4, 2022
egramond
pushed a commit
to egramond/flutter
that referenced
this pull request
May 5, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #103032
Pre-launch Checklist
///).If you need help, consider asking for advice on the #hackers-new channel on Discord.