Skip to content

Add Material 3 NavigationRail example and improve Material 2 example #101345

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 5 commits into from
Apr 18, 2022
Merged

Add Material 3 NavigationRail example and improve Material 2 example #101345

merged 5 commits into from
Apr 18, 2022

Conversation

TahaTesser
Copy link
Member

@TahaTesser TahaTesser commented Apr 5, 2022 •
edited
Loading

part of #101048

M2 NavRail M3 NavRail

Pre-launch Checklist

  • I read the Contributor Guide and followed the process outlined there for submitting PRs.
  • I read the Tree Hygiene wiki page, which explains my responsibilities.
  • I read and followed the Flutter Style Guide, including Features we expect every widget to implement.
  • I signed the CLA.
  • I listed at least one issue that this PR fixes in the description above.
  • I updated/added relevant documentation (doc comments with ///).
  • I added new tests to check the change I am making, or this PR is test-exempt.
  • All existing and new tests are passing.

If you need help, consider asking for advice on the #hackers-new channel on Discord.

@flutter-dashboard flutter-dashboard bot added d: api docs Issues with https://api.flutter.dev/ d: examples Sample code and demos documentation f: material design flutter/packages/flutter/material repository. framework flutter/packages/flutter repository. See also f: labels. c: contributor-productivity Team-specific productivity, code health, technical debt. labels Apr 5, 2022
gspencergoog
gspencergoog approved these changes Apr 5, 2022
View reviewed changes
Copy link
Contributor

@gspencergoog gspencergoog left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

32384589-a60f0e74-c078-11e7-9bc1-e5b5287aea9d

@TahaTesser TahaTesser force-pushed the m3_nav_rail branch 2 times, most recently from 5de3e84 to 14b3d7e Compare April 7, 2022 07:38
This was referenced Apr 7, 2022
Closed
Merged
@fluttergithubbot
Copy link
Contributor

This pull request is not suitable for automatic merging in its current state.

  • The status or check suite Google testing has failed. Please fix the issues identified (or deflake) before re-applying this label.

@TahaTesser TahaTesser mentioned this pull request Apr 8, 2022
Merged
8 tasks
@TahaTesser
Copy link
Member Author

cc: @guidezpl

After rebasing
Google testing — No tests has been executed due to internal error. Ask a Googler to investigate.

@TahaTesser TahaTesser force-pushed the m3_nav_rail branch 3 times, most recently from 6a1f62b to 5158a92 Compare April 14, 2022 14:04
@fluttergithubbot fluttergithubbot merged commit eca0925 into flutter:master Apr 18, 2022
@TahaTesser TahaTesser deleted the m3_nav_rail branch April 18, 2022 14:31
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Apr 18, 2022
Merged
engine-flutter-autoroll added a commit to engine-flutter-autoroll/plugins that referenced this pull request Apr 18, 2022
@engine-flutter-autoroll
eca0925 Add Material 3 NavigationRail example and improve Material …
ab7090b 
…2 example (flutter/flutter#101345)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Apr 21, 2022
@engine-flutter-autoroll
eca0925 Add Material 3 NavigationRail example and improve Material …
71218a9 
…2 example (flutter/flutter#101345)
@guidezpl guidezpl mentioned this pull request May 19, 2022
Closed
7 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@guidezpl guidezpl guidezpl approved these changes

@gspencergoog gspencergoog gspencergoog approved these changes

Assignees
No one assigned
Labels
c: contributor-productivity Team-specific productivity, code health, technical debt. d: api docs Issues with https://api.flutter.dev/ d: examples Sample code and demos f: material design flutter/packages/flutter/material repository. framework flutter/packages/flutter repository. See also f: labels.
Projects
Nevercode
Status: Done (PR merged)
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@TahaTesser @fluttergithubbot @guidezpl @gspencergoog