Skip to content

Migrate Card widget to support Material 3 #100532

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Mar 22, 2022
Merged

Migrate Card widget to support Material 3 #100532

merged 2 commits into from
Mar 22, 2022

Conversation

darrenaustin
Copy link
Contributor

@darrenaustin darrenaustin commented Mar 22, 2022 •
edited
Loading

Part of: #91605

Updated the Card widget with support for Material Design 3.

M3 Card

M3 Card Dark

In order to use the Card with the new Material 3 defaults, turn on the useMaterial3 flag in the ThemeData:

  return MaterialApp(
    theme: ThemeData(useMaterial3: true),
    // ...
  );

Fixes: #99023

Pre-launch Checklist

  • I read the [Contributor Guide] and followed the process outlined there for submitting PRs.
  • I read the [Tree Hygiene] wiki page, which explains my responsibilities.
  • I read and followed the [Flutter Style Guide], including [Features we expect every widget to implement].
  • I signed the [CLA].
  • I listed at least one issue that this PR fixes in the description above.
  • I updated/added relevant documentation (doc comments with ///).
  • I added new tests to check the change I am making, or this PR is [test-exempt].
  • All existing and new tests are passing.

@flutter-dashboard flutter-dashboard bot added d: api docs Issues with https://api.flutter.dev/ d: examples Sample code and demos documentation f: material design flutter/packages/flutter/material repository. framework flutter/packages/flutter repository. See also f: labels. c: contributor-productivity Team-specific productivity, code health, technical debt. labels Mar 22, 2022
@skia-gold
Copy link

Gold has detected about 1 new digest(s) on patchset 1.
View them at https://flutter-gold.skia.org/cl/github/100532

@flutter-dashboard
Copy link

Golden file changes have been found for this pull request. Click here to view and triage (e.g. because this is an intentional change).

If you are still iterating on this change and are not ready to resolve the images on the Flutter Gold dashboard, consider marking this PR as a draft pull request above. You will still be able to view image results on the dashboard, commenting will be silenced, and the check will not try to resolve itself until marked ready for review.

For more guidance, visit Writing a golden file test for package:flutter.

Reviewers: Read the Tree Hygiene page and make sure this patch meets those guidelines before LGTMing.

Changes reported for pull request #100532 at sha f07591d

@flutter-dashboard flutter-dashboard bot added the will affect goldens Changes to golden files label Mar 22, 2022
@guidezpl
Copy link
Member

LGTM but the corner radius for the first two cards in the example looks off

@darrenaustin
Copy link
Contributor Author

LGTM but the corner radius for the first two cards in the example looks off

That's because I took a screen shot of the wrong thing 🤯 . Updated with the correct images. Thx.

HansMuller
HansMuller approved these changes Mar 22, 2022
View reviewed changes
Copy link
Contributor

@HansMuller HansMuller left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@skia-gold
Copy link

Gold has detected about 1 new digest(s) on patchset 2.
View them at https://flutter-gold.skia.org/cl/github/100532

@flutter-dashboard
Copy link

Golden file changes are available for triage from new commit, Click here to view.

For more guidance, visit Writing a golden file test for package:flutter.

Reviewers: Read the Tree Hygiene page and make sure this patch meets those guidelines before LGTMing.

Changes reported for pull request #100532 at sha a523cd4

@darrenaustin darrenaustin merged commit 86c02e9 into flutter:master Mar 22, 2022
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Mar 22, 2022
Merged
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 22, 2022
@engine-flutter-autoroll
86c02e9 Migrate Card widget to Material 3. (flutter/flutter#100532)
ba1c0fd
engine-flutter-autoroll added a commit to engine-flutter-autoroll/plugins that referenced this pull request Mar 29, 2022
@engine-flutter-autoroll
86c02e9 Migrate Card widget to Material 3. (flutter/flutter#100532)
5fc271d
engine-flutter-autoroll added a commit to engine-flutter-autoroll/plugins that referenced this pull request Mar 29, 2022
@engine-flutter-autoroll
86c02e9 Migrate Card widget to Material 3. (flutter/flutter#100532)
5cf2c1f
engine-flutter-autoroll added a commit to engine-flutter-autoroll/plugins that referenced this pull request Mar 29, 2022
@engine-flutter-autoroll
86c02e9 Migrate Card widget to Material 3. (flutter/flutter#100532)
7cd7ea4
engine-flutter-autoroll added a commit to engine-flutter-autoroll/plugins that referenced this pull request Mar 29, 2022
@engine-flutter-autoroll
86c02e9 Migrate Card widget to Material 3. (flutter/flutter#100532)
761fd3b
engine-flutter-autoroll added a commit to engine-flutter-autoroll/plugins that referenced this pull request Mar 29, 2022
@engine-flutter-autoroll
86c02e9 Migrate Card widget to Material 3. (flutter/flutter#100532)
5478225
engine-flutter-autoroll added a commit to engine-flutter-autoroll/plugins that referenced this pull request Mar 29, 2022
@engine-flutter-autoroll
86c02e9 Migrate Card widget to Material 3. (flutter/flutter#100532)
ceb149e
engine-flutter-autoroll added a commit to engine-flutter-autoroll/plugins that referenced this pull request Mar 29, 2022
@engine-flutter-autoroll
86c02e9 Migrate Card widget to Material 3. (flutter/flutter#100532)
0e95ee4
@darrenaustin darrenaustin mentioned this pull request Mar 31, 2022
Closed
7 tasks
@guidezpl guidezpl changed the title Migrate Card widget to Material 3. Migrate Card widget to support Material 3 Mar 31, 2022
@guidezpl guidezpl changed the title Migrate Card widget to support Material 3 Migrate Card widget to support Material 3 Mar 31, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@guidezpl guidezpl Awaiting requested review from guidezpl

1 more reviewer

@HansMuller HansMuller HansMuller approved these changes

Reviewers whose approvals may not affect merge requirements
Assignees
No one assigned
Labels
c: contributor-productivity Team-specific productivity, code health, technical debt. d: api docs Issues with https://api.flutter.dev/ d: examples Sample code and demos f: material design flutter/packages/flutter/material repository. framework flutter/packages/flutter repository. See also f: labels. will affect goldens Changes to golden files
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Update Cards to support Material 3
4 participants
@darrenaustin @skia-gold @guidezpl @HansMuller