Fix a race in FlutterEngineTest.CanLogToStdout #172025

jason-simmons · 2025-07-11T18:56:56Z

FlutterEngineTest.CanLogToStdout has been flaking on CI. This fixes a potential cause of the flakes that could happen if other strings are logged by the Dart VM after the print statement run by the test.

flutter-dashboard · 2025-07-11T23:11:53Z

CI had a failure that stopped further tests from running. We need to investigate to determine the root cause.

SHA at time of execution: a8d318c.

Possible causes:

Configuration Changes: The .ci.yaml file might have been modified between the creation of this pull request and the start of this test run. This can lead to ci yaml validation errors.
Infrastructure Issues: Problems with the CI environment itself (e.g., quota) could have caused the failure.

A blank commit, or merging to head, will be required to resume running CI for this PR.

Error Details:

GitHub Error: You have exceeded a secondary rate limit. Please wait a few minutes before you try again. If you reach out to GitHub Support for help, please include the request ID AA00:5CECB:125CB76:251047D:68719A38.

Stack trace:

#0      GitHub.handleStatusCode (package:github/src/common/github.dart:486:5)
#1      GitHub.request (package:github/src/common/github.dart:422:7)
<asynchronous suspension>
#2      GitHub.requestJson (package:github/src/common/github.dart:323:22)
<asynchronous suspension>
#3      RetryOptions.retry (package:retry/retry.dart:131:16)
<asynchronous suspension>
#4      LuciBuildService.scheduleTryBuilds (package:cocoon_service/src/service/luci_build_service.dart:246:24)
<asynchronous suspension>
#5      Scheduler._runCiTestingStage (package:cocoon_service/src/service/scheduler.dart:1248:9)
<asynchronous suspension>
#6      Scheduler.proceedToCiTestingStage (package:cocoon_service/src/service/scheduler.dart:1309:7)
<asynchronous suspension>
#7      Scheduler._closeSuccessfulEngineBuildStage (package:cocoon_service/src/service/scheduler.dart:1120:5)
<asynchronous suspension>
#8      Scheduler.processCheckRunCompletion (package:cocoon_service/src/service/scheduler.dart:1053:9)
<asynchronous suspension>
#9      Scheduler.processCheckRun (package:cocoon_service/src/service/scheduler.dart:1393:9)
<asynchronous suspension>
#10     GithubWebhookSubscription.post (package:cocoon_service/src/request_handlers/github/webhook_subscription.dart:118:24)
<asynchronous suspension>
#11     RequestHandler.service (package:cocoon_service/src/request_handling/request_handler.dart:45:20)
<asynchronous suspension>
#12     SubscriptionHandler.service (package:cocoon_service/src/request_handling/subscription_handler.dart:140:5)
<asynchronous suspension>
#13     createServer.<anonymous closure> (package:cocoon_service/server.dart:329:7)
<asynchronous suspension>

FlutterEngineTest.CanLogToStdout has been flaking on CI. This fixes a potential cause of the flakes that could happen if other strings are logged by the Dart VM after the print statement run by the test.

…tter#172025)

flutter/flutter@9c626d9...440713c 2025-07-18 stuartmorgan@google.com Add OS version support section to plugin docs (flutter/flutter#172316) 2025-07-18 engine-flutter-autoroll@skia.org Roll Dart SDK from 7fcc5f48c335 to fe2232bd5b9f (2 revisions) (flutter/flutter#172339) 2025-07-18 robert.ancell@canonical.com Refactor handling of frame waiting. (flutter/flutter#172277) 2025-07-18 137456488+flutter-pub-roller-bot@users.noreply.github.com Roll pub packages (flutter/flutter#172332) 2025-07-17 matanlurey@users.noreply.github.com Refactor and forbid `base/exit.dart` outside of `lib/runner.dart` (flutter/flutter#171923) 2025-07-17 matanlurey@users.noreply.github.com Use UTC timezone for `stamp_command_test` to avoid local TZ flakes (flutter/flutter#172319) 2025-07-17 1961493+harryterkelsen@users.noreply.github.com [web] Add tests for unified platform view embedding behavior (flutter/flutter#172313) 2025-07-17 jmccandless@google.com Platform views shouldn't receive pointer events when not laid out (flutter/flutter#172043) 2025-07-17 ahmedsameha1@gmail.com Fix Size.isEmpty description (flutter/flutter#172021) 2025-07-17 iamtoricool@gmail.com feat: Add `maxCount` parameter to `Badge.count` constructor. (flutter/flutter#171054) 2025-07-17 31859944+LongCatIsLooong@users.noreply.github.com add `debugPaintTextLayoutBoxes` for debugging text layout (flutter/flutter#168876) 2025-07-17 engine-flutter-autoroll@skia.org Roll Packages from 4a231ae to cb8fef6 (31 revisions) (flutter/flutter#172303) 2025-07-17 jmccandless@google.com Fix mutating Paint bug (flutter/flutter#171180) 2025-07-17 jmccandless@google.com No SystemContextMenu when readOnly is true (flutter/flutter#171242) 2025-07-17 muhammad.mohiuddin@live.com Add a getter to get the recorder used by painting context (flutter/flutter#170223) 2025-07-17 jason-simmons@users.noreply.github.com [Impeller] Add missing SetPipeline call for the vertices uber pipeline in AtlasContents (flutter/flutter#172273) 2025-07-17 engine-flutter-autoroll@skia.org Roll Dart SDK from 486f9c0663bc to 7fcc5f48c335 (1 revision) (flutter/flutter#172279) 2025-07-17 engine-flutter-autoroll@skia.org Roll Skia from 3673a1f26a63 to 9587301e33bc (3 revisions) (flutter/flutter#172281) 2025-07-17 jason-simmons@users.noreply.github.com Fix a race in FlutterEngineTest.CanLogToStdout (flutter/flutter#172025) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-packages Please CC bmparr@google.com,stuartmorgan@google.com on the revert to ensure that a human is aware of the problem. To file a bug in Packages: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

FlutterEngineTest.CanLogToStdout has been flaking on CI. This fixes a potential cause of the flakes that could happen if other strings are logged by the Dart VM after the print statement run by the test.

…r#9646) flutter/flutter@9c626d9...440713c 2025-07-18 stuartmorgan@google.com Add OS version support section to plugin docs (flutter/flutter#172316) 2025-07-18 engine-flutter-autoroll@skia.org Roll Dart SDK from 7fcc5f48c335 to fe2232bd5b9f (2 revisions) (flutter/flutter#172339) 2025-07-18 robert.ancell@canonical.com Refactor handling of frame waiting. (flutter/flutter#172277) 2025-07-18 137456488+flutter-pub-roller-bot@users.noreply.github.com Roll pub packages (flutter/flutter#172332) 2025-07-17 matanlurey@users.noreply.github.com Refactor and forbid `base/exit.dart` outside of `lib/runner.dart` (flutter/flutter#171923) 2025-07-17 matanlurey@users.noreply.github.com Use UTC timezone for `stamp_command_test` to avoid local TZ flakes (flutter/flutter#172319) 2025-07-17 1961493+harryterkelsen@users.noreply.github.com [web] Add tests for unified platform view embedding behavior (flutter/flutter#172313) 2025-07-17 jmccandless@google.com Platform views shouldn't receive pointer events when not laid out (flutter/flutter#172043) 2025-07-17 ahmedsameha1@gmail.com Fix Size.isEmpty description (flutter/flutter#172021) 2025-07-17 iamtoricool@gmail.com feat: Add `maxCount` parameter to `Badge.count` constructor. (flutter/flutter#171054) 2025-07-17 31859944+LongCatIsLooong@users.noreply.github.com add `debugPaintTextLayoutBoxes` for debugging text layout (flutter/flutter#168876) 2025-07-17 engine-flutter-autoroll@skia.org Roll Packages from 4a231ae to cb8fef6 (31 revisions) (flutter/flutter#172303) 2025-07-17 jmccandless@google.com Fix mutating Paint bug (flutter/flutter#171180) 2025-07-17 jmccandless@google.com No SystemContextMenu when readOnly is true (flutter/flutter#171242) 2025-07-17 muhammad.mohiuddin@live.com Add a getter to get the recorder used by painting context (flutter/flutter#170223) 2025-07-17 jason-simmons@users.noreply.github.com [Impeller] Add missing SetPipeline call for the vertices uber pipeline in AtlasContents (flutter/flutter#172273) 2025-07-17 engine-flutter-autoroll@skia.org Roll Dart SDK from 486f9c0663bc to 7fcc5f48c335 (1 revision) (flutter/flutter#172279) 2025-07-17 engine-flutter-autoroll@skia.org Roll Skia from 3673a1f26a63 to 9587301e33bc (3 revisions) (flutter/flutter#172281) 2025-07-17 jason-simmons@users.noreply.github.com Fix a race in FlutterEngineTest.CanLogToStdout (flutter/flutter#172025) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-packages Please CC bmparr@google.com,stuartmorgan@google.com on the revert to ensure that a human is aware of the problem. To file a bug in Packages: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

FlutterEngineTest.CanLogToStdout has been flaking on CI. This fixes a potential cause of the flakes that could happen if other strings are logged by the Dart VM after the print statement run by the test.

jason-simmons requested a review from cbracken July 11, 2025 18:56

jason-simmons requested a review from a team as a code owner July 11, 2025 18:56

github-actions bot added platform-ios iOS applications specifically engine flutter/engine related. See also e: labels. a: desktop Running on desktop team-ios Owned by iOS platform team platform-macos labels Jul 11, 2025

jason-simmons force-pushed the mac_flake_can_log_stdout branch from 6badee6 to a8d318c Compare July 11, 2025 22:53

chinmaygarde approved these changes Jul 14, 2025

View reviewed changes

jason-simmons force-pushed the mac_flake_can_log_stdout branch from a8d318c to ad3edb0 Compare July 15, 2025 18:58

Fix a race in FlutterEngineTest.CanLogToStdout

0bdad7b

FlutterEngineTest.CanLogToStdout has been flaking on CI. This fixes a potential cause of the flakes that could happen if other strings are logged by the Dart VM after the print statement run by the test.

jason-simmons force-pushed the mac_flake_can_log_stdout branch from ad3edb0 to 0bdad7b Compare July 16, 2025 20:43

jason-simmons added the autosubmit Merge PR when tree becomes green via auto submit App label Jul 17, 2025

auto-submit bot added this pull request to the merge queue Jul 17, 2025

Merged via the queue into flutter:master with commit 2309aa3 Jul 17, 2025
179 checks passed

flutter-dashboard bot removed the autosubmit Merge PR when tree becomes green via auto submit App label Jul 17, 2025

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jul 18, 2025

2309aa3a9 Fix a race in FlutterEngineTest.CanLogToStdout (flutter/flu…

303485b

…tter#172025)

engine-flutter-autoroll mentioned this pull request Jul 18, 2025

Roll Flutter from 9c626d9f9afa to 440713c3b287 (19 revisions) flutter/packages#9646

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Fix a race in FlutterEngineTest.CanLogToStdout #172025

Fix a race in FlutterEngineTest.CanLogToStdout #172025

Uh oh!

jason-simmons commented Jul 11, 2025

Uh oh!

flutter-dashboard bot commented Jul 11, 2025

Uh oh!

Uh oh!

Uh oh!

Fix a race in FlutterEngineTest.CanLogToStdout #172025

Fix a race in FlutterEngineTest.CanLogToStdout #172025

Uh oh!

Conversation

jason-simmons commented Jul 11, 2025

Uh oh!

flutter-dashboard bot commented Jul 11, 2025

Uh oh!

Uh oh!

Uh oh!